Fix quick action route-selected expense tabs#90493
Draft
kaziiza wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #76229
Summary
Root Cause
Quick-action routes can include a nested request tab, such as scan receipt or odometer, but the Onyx-backed tab navigator initialized from persisted selected tab state first. If a stale draft had the same request type but belonged to a previous report, the reset hook returned early and the user could land on the wrong create flow after login.
Tests
npm test -- tests/unit/OnyxTabNavigatorTest.ts tests/unit/QuickActionNavigationTest.ts tests/actions/IOU/MoneyRequestTest.ts tests/ui/IOURequestStartPageTest.tsx --runInBandnpx eslinton the changed filesnpm run typecheckgit diff --checkon the changed files