Skip to content

Disable lazy loading on search on web#90517

Merged
mountiny merged 2 commits into
Expensify:mainfrom
software-mansion-labs:perf/disable-lazy-loading-search-on-web
May 18, 2026
Merged

Disable lazy loading on search on web#90517
mountiny merged 2 commits into
Expensify:mainfrom
software-mansion-labs:perf/disable-lazy-loading-search-on-web

Conversation

@jmusial
Copy link
Copy Markdown
Contributor

@jmusial jmusial commented May 13, 2026

Explanation of Change

This PR removes lazy load from SearchFullscreenNavigatorScreen due to performance reasons. More details in the comment below.

Fixed Issues

$ #90758
PROPOSAL:

Slack convo

Tests

  1. Start @ Home
  2. Click Spend
  3. Observe no spinner on page transition

Offline tests

Same as tests

QA Steps

Same as tests

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Changes only affect web

MacOS: Chrome / Safari
Screen.Recording.2026-05-14.at.17.47.45.mov

@luacmartins luacmartins self-requested a review May 13, 2026 14:03
@github-actions
Copy link
Copy Markdown
Contributor

🚧 @luacmartins has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@jmusial
Copy link
Copy Markdown
Contributor Author

jmusial commented May 14, 2026

ManualNavigateToReports Span Summary

The data shows 10 trials per build. Each trial consists of 1 cold navigation (first entry into Reports) followed by 2 warm navigations (subsequent visits). The cold/warm split is clearly visible: cold runs are ~30–60× slower than warm ones.

Note: is_warm (data) was't monitored but onyx state has not beed reset during test. I predict that in cold data navigation the difference is going to be bigger.

Ad hoc build (vendors-359697571784f55a01db)

Cold navigation (1st visit)

Trial Duration (ms)
1 1217
2 1344
3 1375
4 1322
5 1300
6 1404
7 1385
8 1488
9 1373
10 1029
  • Avg: 1323.7 ms
  • Min / Max: 1029 / 1488 ms

Warm navigation (2nd & 3rd visits)

  • Samples: 20
  • Avg: 39.1 ms
  • Min / Max: 23 / 43 ms

Prod build (vendors-51ebbb0f262077a56ed2)

Cold navigation (1st visit)

Trial Duration (ms)
1 1592
2 2117
3 1644
4 1603
5 1794
6 1571
7 1685
8 1881
9 1528
10 1580
  • Avg: 1699.5 ms
  • Min / Max: 1528 / 2117 ms

Warm navigation (2nd & 3rd visits)

  • Samples: 20
  • Avg: 32.7 ms
  • Min / Max: 29 / 38 ms

Head-to-head

Metric Ad hoc Prod Δ (Prod − Ad hoc)
Cold avg 1323.7 ms 1699.5 ms +375.8 ms (+28.4%)
Cold min 1029 ms 1528 ms +499 ms
Cold max 1488 ms 2117 ms +629 ms
Warm avg 39.1 ms 32.7 ms −6.4 ms (−16.3%)
Warm min 23 ms 29 ms +6 ms
Warm max 43 ms 38 ms −5 ms

Takeaways

  • Cold path regresses on Prod by ~376 ms on average (~28% slower). Prod's worst cold run hit 2.1 s vs. Ad hoc's worst at 1.5 s.
  • Warm path is slightly faster on Prod (~6 ms / 16%), and notably more consistent (range 29–38 ms vs. 23–43 ms).
  • Warm timings are tight enough (~30–40 ms) that the cost is dominated by something amortized on first navigation — likely module/init work or first-render data shaping that isn't repeated on subsequent visits.

Sample test

Screen.Recording.2026-05-14.at.17.47.45.mov
Data

Ad hoc

vendors-359697571784f55a01db.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (1217ms) {spanId: 'ManualNavigateToReports', durationMs: 1217, timestamp: 10373, attributes: {…}}
vendors-359697571784f55a01db.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (40ms) {spanId: 'ManualNavigateToReports', durationMs: 40, timestamp: 13255.800000000745, attributes: {…}}
vendors-359697571784f55a01db.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (38ms) {spanId: 'ManualNavigateToReports', durationMs: 38, timestamp: 17160.60000000056, attributes: {…}}

vendors-359697571784f55a01db.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (1344ms) {spanId: 'ManualNavigateToReports', durationMs: 1344, timestamp: 42831.700000000186, attributes: {…}}
vendors-359697571784f55a01db.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (40ms) {spanId: 'ManualNavigateToReports', durationMs: 40, timestamp: 45504.89999999944, attributes: {…}}
vendors-359697571784f55a01db.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (39ms) {spanId: 'ManualNavigateToReports', durationMs: 39, timestamp: 47767.799999999814, attributes: {…}}

vendors-359697571784f55a01db.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (1375ms) {spanId: 'ManualNavigateToReports', durationMs: 1375, timestamp: 19964.599999999627, attributes: {…}}
vendors-359697571784f55a01db.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (41ms) {spanId: 'ManualNavigateToReports', durationMs: 41, timestamp: 23215.89999999944, attributes: {…}}
vendors-359697571784f55a01db.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (39ms) {spanId: 'ManualNavigateToReports', durationMs: 39, timestamp: 25697.299999999814, attributes: {…}}

vendors-359697571784f55a01db.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (1322ms) {spanId: 'ManualNavigateToReports', durationMs: 1322, timestamp: 11659.899999999441, attributes: {…}}
vendors-359697571784f55a01db.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (39ms) {spanId: 'ManualNavigateToReports', durationMs: 39, timestamp: 14543.099999999627, attributes: {…}}
vendors-359697571784f55a01db.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (41ms) {spanId: 'ManualNavigateToReports', durationMs: 41, timestamp: 17512.599999999627, attributes: {…}}

vendors-359697571784f55a01db.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (1300ms) {spanId: 'ManualNavigateToReports', durationMs: 1300, timestamp: 19169.89999999944, attributes: {…}}
vendors-359697571784f55a01db.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (39ms) {spanId: 'ManualNavigateToReports', durationMs: 39, timestamp: 21860.099999999627, attributes: {…}}
vendors-359697571784f55a01db.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (40ms) {spanId: 'ManualNavigateToReports', durationMs: 40, timestamp: 23908.599999999627, attributes: {…}}

vendors-359697571784f55a01db.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (1404ms) {spanId: 'ManualNavigateToReports', durationMs: 1404, timestamp: 42983.10000000056, attributes: {…}}
vendors-359697571784f55a01db.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (42ms) {spanId: 'ManualNavigateToReports', durationMs: 42, timestamp: 46205.10000000056, attributes: {…}}
vendors-359697571784f55a01db.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (34ms) {spanId: 'ManualNavigateToReports', durationMs: 34, timestamp: 51818.60000000056, attributes: {…}}

vendors-359697571784f55a01db.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (1385ms) {spanId: 'ManualNavigateToReports', durationMs: 1385, timestamp: 23121.5, attributes: {…}}
vendors-359697571784f55a01db.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (41ms) {spanId: 'ManualNavigateToReports', durationMs: 41, timestamp: 25704.599999999627, attributes: {…}}
vendors-359697571784f55a01db.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (38ms) {spanId: 'ManualNavigateToReports', durationMs: 38, timestamp: 28590.799999999814, attributes: {…}}

vendors-359697571784f55a01db.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (1488ms) {spanId: 'ManualNavigateToReports', durationMs: 1488, timestamp: 15907.699999999255, attributes: {…}}
vendors-359697571784f55a01db.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (42ms) {spanId: 'ManualNavigateToReports', durationMs: 42, timestamp: 18613.199999999255, attributes: {…}}
vendors-359697571784f55a01db.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (39ms) {spanId: 'ManualNavigateToReports', durationMs: 39, timestamp: 21710.199999999255, attributes: {…}}

vendors-359697571784f55a01db.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (1373ms) {spanId: 'ManualNavigateToReports', durationMs: 1373, timestamp: 37331.5, attributes: {…}}
vendors-359697571784f55a01db.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (23ms) {spanId: 'ManualNavigateToReports', durationMs: 23, timestamp: 39860.5, attributes: {…}}
vendors-359697571784f55a01db.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (43ms) {spanId: 'ManualNavigateToReports', durationMs: 43, timestamp: 44053.300000000745, attributes: {…}}

vendors-359697571784f55a01db.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (1029ms) {spanId: 'ManualNavigateToReports', durationMs: 1029, timestamp: 10203.5, attributes: {…}}
vendors-359697571784f55a01db.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (41ms) {spanId: 'ManualNavigateToReports', durationMs: 41, timestamp: 13319.800000000745, attributes: {…}}
vendors-359697571784f55a01db.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (42ms) {spanId: 'ManualNavigateToReports', durationMs: 42, timestamp: 16337.800000000745, attributes: {…}}

Prod

vendors-51ebbb0f262077a56ed2.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (1592ms) {spanId: 'ManualNavigateToReports', durationMs: 1592, timestamp: 32523.599999999627, attributes: {…}}
vendors-51ebbb0f262077a56ed2.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (33ms) {spanId: 'ManualNavigateToReports', durationMs: 33, timestamp: 34855.5, attributes: {…}}
vendors-51ebbb0f262077a56ed2.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (32ms) {spanId: 'ManualNavigateToReports', durationMs: 32, timestamp: 37189.09999999963, attributes: {…}}

vendors-51ebbb0f262077a56ed2.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (2117ms) {spanId: 'ManualNavigateToReports', durationMs: 2117, timestamp: 27153.700000000186, attributes: {…}}
vendors-51ebbb0f262077a56ed2.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (33ms) {spanId: 'ManualNavigateToReports', durationMs: 33, timestamp: 29787, attributes: {…}}
vendors-51ebbb0f262077a56ed2.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (38ms) {spanId: 'ManualNavigateToReports', durationMs: 38, timestamp: 32494.299999999814, attributes: {…}}

vendors-51ebbb0f262077a56ed2.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (1644ms) {spanId: 'ManualNavigateToReports', durationMs: 1644, timestamp: 34116.299999999814, attributes: {…}}
vendors-51ebbb0f262077a56ed2.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (32ms) {spanId: 'ManualNavigateToReports', durationMs: 32, timestamp: 36671.40000000037, attributes: {…}}
vendors-51ebbb0f262077a56ed2.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (31ms) {spanId: 'ManualNavigateToReports', durationMs: 31, timestamp: 39186.700000000186, attributes: {…}}

vendors-51ebbb0f262077a56ed2.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (1603ms) {spanId: 'ManualNavigateToReports', durationMs: 1603, timestamp: 24408.10000000056, attributes: {…}}
vendors-51ebbb0f262077a56ed2.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (30ms) {spanId: 'ManualNavigateToReports', durationMs: 30, timestamp: 26818.200000000186, attributes: {…}}
vendors-51ebbb0f262077a56ed2.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (35ms) {spanId: 'ManualNavigateToReports', durationMs: 35, timestamp: 30045, attributes: {…}}

vendors-51ebbb0f262077a56ed2.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (1794ms) {spanId: 'ManualNavigateToReports', durationMs: 1794, timestamp: 39263.799999999814, attributes: {…}}
vendors-51ebbb0f262077a56ed2.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (33ms) {spanId: 'ManualNavigateToReports', durationMs: 33, timestamp: 42103.39999999944, attributes: {…}}
vendors-51ebbb0f262077a56ed2.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (33ms) {spanId: 'ManualNavigateToReports', durationMs: 33, timestamp: 44618.09999999963, attributes: {…}}

vendors-51ebbb0f262077a56ed2.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (1571ms) {spanId: 'ManualNavigateToReports', durationMs: 1571, timestamp: 17508.60000000056, attributes: {…}}
vendors-51ebbb0f262077a56ed2.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (30ms) {spanId: 'ManualNavigateToReports', durationMs: 30, timestamp: 20304.800000000745, attributes: {…}}
vendors-51ebbb0f262077a56ed2.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (31ms) {spanId: 'ManualNavigateToReports', durationMs: 31, timestamp: 22918.10000000056, attributes: {…}}

vendors-51ebbb0f262077a56ed2.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (1685ms) {spanId: 'ManualNavigateToReports', durationMs: 1685, timestamp: 13125.800000000745, attributes: {…}}
vendors-51ebbb0f262077a56ed2.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (32ms) {spanId: 'ManualNavigateToReports', durationMs: 32, timestamp: 15622.900000000373, attributes: {…}}
vendors-51ebbb0f262077a56ed2.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (32ms) {spanId: 'ManualNavigateToReports', durationMs: 32, timestamp: 17939.900000000373, attributes: {…}}

vendors-51ebbb0f262077a56ed2.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (1881ms) {spanId: 'ManualNavigateToReports', durationMs: 1881, timestamp: 23241.799999999814, attributes: {…}}
vendors-51ebbb0f262077a56ed2.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (32ms) {spanId: 'ManualNavigateToReports', durationMs: 32, timestamp: 25671.60000000056, attributes: {…}}
vendors-51ebbb0f262077a56ed2.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (34ms) {spanId: 'ManualNavigateToReports', durationMs: 34, timestamp: 27658.10000000056, attributes: {…}}

vendors-51ebbb0f262077a56ed2.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (1528ms) {spanId: 'ManualNavigateToReports', durationMs: 1528, timestamp: 27996, attributes: {…}}
vendors-51ebbb0f262077a56ed2.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (33ms) {spanId: 'ManualNavigateToReports', durationMs: 33, timestamp: 33119.20000000112, attributes: {…}}
vendors-51ebbb0f262077a56ed2.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (37ms) {spanId: 'ManualNavigateToReports', durationMs: 37, timestamp: 35056.20000000112, attributes: {…}}

vendors-51ebbb0f262077a56ed2.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (1580ms) {spanId: 'ManualNavigateToReports', durationMs: 1580, timestamp: 34943.199999999255, attributes: {…}}
vendors-51ebbb0f262077a56ed2.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (33ms) {spanId: 'ManualNavigateToReports', durationMs: 33, timestamp: 37528.5, attributes: {…}}
vendors-51ebbb0f262077a56ed2.bundle.js:23 [Sentry][ManualNavigateToReports] Ending span (29ms) {spanId: 'ManualNavigateToReports', durationMs: 29, timestamp: 39903.89999999851, attributes: {…}}

import CONST from '@src/CONST';
import NAVIGATORS from '@src/NAVIGATORS';
import SCREENS from '@src/SCREENS';
// Were not lazy loading SearchFullscreenNavigator, due to over 50% users visiting it only once during session.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Were not lazy loading SearchFullscreenNavigator, due to over 50% users visiting it only once during session.
// Do not lazy load Search navigator for performance reasons

@jmusial jmusial marked this pull request as ready for review May 15, 2026 07:49
@jmusial jmusial requested review from a team as code owners May 15, 2026 07:49
@melvin-bot melvin-bot Bot requested review from trjExpensify and youssef-lr and removed request for a team May 15, 2026 07:49
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented May 15, 2026

@youssef-lr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@jmusial
Copy link
Copy Markdown
Contributor Author

jmusial commented May 15, 2026

@codex review

@sumo-slonik
Copy link
Copy Markdown
Contributor

LGTM 🚀

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Delightful!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@mountiny mountiny requested a review from ZhenjaHorbach May 15, 2026 08:44
@ZhenjaHorbach
Copy link
Copy Markdown
Contributor

ZhenjaHorbach commented May 15, 2026

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
IMG_2305.MP4
Android: mWeb Chrome
IMG_2304.MP4
iOS: HybridApp
IMG_2305.MP4
iOS: mWeb Safari
IMG_2304.MP4
MacOS: Chrome / Safari
2026-05-15.11.56.06.mov

@melvin-bot melvin-bot Bot requested a review from luacmartins May 15, 2026 10:59
@ZhenjaHorbach
Copy link
Copy Markdown
Contributor

LGTM!

@trjExpensify trjExpensify removed their request for review May 15, 2026 15:46
@trjExpensify
Copy link
Copy Markdown
Contributor

PR doesn’t need product input as a perf PR. Unassigning and unsubscribing myself.

Copy link
Copy Markdown
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@mountiny mountiny merged commit 3c00384 into Expensify:main May 18, 2026
47 of 48 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify
Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.76-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 cancelled 🔪
🍎 iOS 🍎 cancelled 🔪

@MelvinBot
Copy link
Copy Markdown
Contributor

No help site changes are required. This PR is a purely internal performance optimization (removing lazy loading from SearchFullscreenNavigator) — it doesn't change any user-facing features, settings, or behavior.

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.77-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants