Show RBR on SSN row in wallet confirmation and clear errorCode optimistically by MelvinBot · Pull Request #90532 · Expensify/App

MelvinBot · 2026-05-13T15:52:12Z

Explanation of Change

When the backend returns ssnError requesting a full 9-digit SSN during wallet activation, the Confirmation step previously showed the error only as a global banner at the bottom of the page. The SSN row itself had no visual indicator that it needed attention, making it unclear what the user should fix.

This PR:

Extends SummaryItem in the shared ConfirmationStep component to support brickRoadIndicator and errorText props (already supported by the underlying MenuItemWithTopDescription).
Shows RBR + error text on the SSN row in the wallet PersonalInfo ConfirmationStep when shouldAskForFullSSN is true and the current SSN is shorter than 9 digits.
Clears errorCode optimistically in updatePersonalDetails so stale error state doesn't persist across resubmissions.

Fixed Issues

$ #87909
PROPOSAL: #87909 (comment)

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

Offline tests

// TODO: The human co-author must fill out offline test steps

QA Steps

Enable the wallet flow (you may need a fresh account or one that has not completed wallet activation).
Navigate to Settings > Wallet > Enable Payments and proceed to the Personal Info confirmation step.
Initial submission (triggers ssnError):
- First name: Alberta
- Last name: Charleson
- DOB: 2000-08-08
- SSN (last 4): 9999 (any non-3333 value)
- Submit the form.
- The backend calls LexisNexis, which fails and returns ssnError.
Verify the fix -- RBR indicator:
- After the error, confirm that the SSN row on the confirmation page shows a red brick road (RBR) indicator and error text prompting for a full 9-digit SSN.
- Verify there is no confusing generic banner -- the error is localized to the SSN row.
Retry submission (tests optimistic errorCode clearing):
- Tap the SSN row and re-enter a full 9-digit SSN (e.g. 112229999).
- Re-submit the form.
- Verify the RBR indicator and error text are cleared after resubmission.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

AI Tests

Test	Result
`npm run prettier`	✅ Pass (no changes)
`npm run lint` (changed files)	✅ Pass (no new errors)
`npm run typecheck-tsgo`	✅ Pass (pre-existing errors only, unrelated to this PR)
`npm test -- --testPathPattern=Wallet\|EnablePayments\|ConfirmationStep`	✅ Pass (6/6)
`react-compiler-compliance-check`	⚠️ Could not run (missing `origin/main` ref in CI environment)

…in wallet flow When the backend returns ssnError requesting a full 9-digit SSN, the Confirmation step now shows a brick road indicator and error text on the SSN row, guiding the user to correct it. Also clears errorCode optimistically on resubmission so stale error state doesn't persist. Co-authored-by: Shubham Agrawal <shubham1206agra@users.noreply.github.com>

codecov · 2026-05-13T16:02:28Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/SubStepForms/ConfirmationStep.tsx	`0.00% <0.00%> (ø)`
src/libs/actions/Wallet.ts	`0.00% <0.00%> (ø)`
...ayments/PersonalInfo/substeps/ConfirmationStep.tsx	`0.00% <0.00%> (ø)`
... and 24 files with indirect coverage changes

shubham1206agra · 2026-05-23T13:31:51Z

@MelvinBot Merge main here using git pull origin main --no-rebase

Co-authored-by: Shubham Agrawal <shubham1206agra@users.noreply.github.com>

MelvinBot · 2026-05-23T13:39:06Z

Done — merged main into this branch using git pull origin main --no-rebase and pushed.

MelvinBot · 2026-05-23T13:41:16Z

The failing checks are not related to this PR's code — both are transient CI infrastructure failures:

ESLint check: Failed at git checkout with an authentication error (fatal: could not read Username), never reached the actual lint step.
CLA / CLA: Failed to download the contributor-assistant/github-action from GitHub after 3 network retries.

Fix: Re-run the failed checks (click "Re-run failed jobs" on the Actions tab). No code changes are needed.

MelvinBot · 2026-05-23T13:43:59Z

The failing checks are not related to this PR's code changes — they are transient CI infrastructure failures:

ESLint check: Runner failed at git checkout with fatal: could not read Username (GitHub Actions auth issue)
CLA / CLA: Failed to download the contributor-assistant/github-action archive after 3 retries (network error on runner)

Re-running both failed checks now.

shubham1206agra · 2026-05-24T12:48:44Z

@MelvinBot I am seeing error text in 2 places. Can you please fix this?

When the SSN row already displays the error text inline, suppress the global DotIndicatorMessage at the bottom to avoid duplicate error text. Co-authored-by: Shubham Agrawal <shubham1206agra@users.noreply.github.com>

MelvinBot · 2026-05-24T12:50:31Z

Fixed — the error was displayed both on the SSN row (via errorText) and as a global banner (via the error prop on CommonConfirmationStep). Now when the SSN row already shows the error inline, the global banner is suppressed.

shubham1206agra · 2026-05-24T12:57:09Z

@MelvinBot Fill the checklist by marking every item as checked (No need to check I have verified everything manually). And mark this PR ready for review.

shubham1206agra · 2026-05-24T12:57:48Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
xIf a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2026-05-24.at.6.23.12.PM.mov

MelvinBot · 2026-05-24T12:58:51Z

Done — checked all checklist items and marked the PR as ready for review.

melvin-bot · 2026-05-24T12:58:52Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shubham1206agra · 2026-05-24T13:02:39Z

@MelvinBot Add tests for QA. Use the following info

Initial submission (triggers ssnError):

First name: Alberta
Last name: Charleson
DOB: 2000-08-08
SSN: last-4 9999(any non-3333 value)
→ Backend calls real LexisNexis → fails → ssnError returned

Retry submission (tests the fix in this PR):

Re-submit the form, now entering the full 9-digit SSN (e.g. 112229999 or any valid 9-digit value)

melvin-bot · 2026-05-24T13:03:01Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #87909 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

MelvinBot · 2026-05-24T13:08:27Z

Updated the QA Steps section in the PR description with the provided test data and verification steps.

melvin-bot · 2026-05-25T18:28:30Z

@aldo-expensify looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

github-actions · 2026-05-25T18:29:17Z

🚧 @aldo-expensify has triggered a test Expensify/App build. You can view the workflow run here.

aldo-expensify · 2026-05-25T18:32:00Z

Emergency: I didn't notice the authoChecklist check was failing:

Seems like for some reason it was not able to verify and of the checkboxes being checked, when they were checked, so this is most likely an issue with the format of the PR body created by Melvin.

github-actions · 2026-05-25T18:34:36Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #90532.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-67a2787c847-e686827-2893c9c2992c4bc58686612d56fe569e7c715609/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-67a2787-e686827-1f52fccc033507cd7ed455a208e5f2fb8f13046f/index.html

Web 🕸️
https://90532.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-25T18:37:24Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-05-25T23:05:16Z

🚀 Deployed to staging by https://github.com/aldo-expensify in version: 9.3.82-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-05-25T23:08:15Z

I reviewed the changes in this PR against the help site articles under App/docs/articles.

No help site changes are required.

This PR improves how SSN validation errors are displayed during wallet activation (adding a red brick road indicator on the SSN row and clearing stale error state on resubmission). These are internal UI behavior improvements that don't change any user-facing steps, features, or flows documented on the help site.

The relevant article — Set-up-your-wallet.md — documents the happy-path wallet setup steps, which remain unchanged by this PR.

@shubham1206agra, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

OSBotify · 2026-05-26T20:07:11Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.82-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot assigned shubham1206agra May 13, 2026

MelvinBot requested a review from a team May 13, 2026 15:52

MelvinBot mentioned this pull request May 13, 2026

[Due for payment 2026-06-02] [$250] Wallet - Stuck on the error SSN when adding bank account to Wallet #87909

Open

7 tasks

Merge remote-tracking branch 'origin/main' into claude-walletSsnErrorRbr

d7a1474

Co-authored-by: Shubham Agrawal <shubham1206agra@users.noreply.github.com>

Fix: Show SSN error only on SSN row, not as global banner

8651178

When the SSN row already displays the error text inline, suppress the global DotIndicatorMessage at the bottom to avoid duplicate error text. Co-authored-by: Shubham Agrawal <shubham1206agra@users.noreply.github.com>

MelvinBot marked this pull request as ready for review May 24, 2026 12:58

MelvinBot requested a review from a team as a code owner May 24, 2026 12:58

melvin-bot Bot requested a review from shubham1206agra May 24, 2026 12:58

melvin-bot Bot requested review from JmillsExpensify and removed request for a team and JmillsExpensify May 24, 2026 12:58

melvin-bot Bot removed the request for review from a team May 24, 2026 12:58

shubham1206agra approved these changes May 24, 2026

View reviewed changes

melvin-bot Bot requested a review from aldo-expensify May 24, 2026 13:03

aldo-expensify approved these changes May 25, 2026

View reviewed changes

aldo-expensify merged commit 67a2787 into main May 25, 2026
51 of 52 checks passed

aldo-expensify deleted the claude-walletSsnErrorRbr branch May 25, 2026 18:28

melvin-bot Bot added the Emergency label May 25, 2026

aldo-expensify removed the Emergency label May 25, 2026

OSBotify mentioned this pull request May 25, 2026

Deploy Checklist: New Expensify 2026-05-25 #91651

Closed

54 tasks

Conversation

MelvinBot commented May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

AI Tests

Uh oh!

codecov Bot commented May 13, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

shubham1206agra commented May 23, 2026

Uh oh!

MelvinBot commented May 23, 2026

Uh oh!

MelvinBot commented May 23, 2026

Uh oh!

MelvinBot commented May 23, 2026

Uh oh!

shubham1206agra commented May 24, 2026

Uh oh!

MelvinBot commented May 24, 2026

Uh oh!

shubham1206agra commented May 24, 2026

Uh oh!

shubham1206agra commented May 24, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

MelvinBot commented May 24, 2026

Uh oh!

melvin-bot Bot commented May 24, 2026

Uh oh!

shubham1206agra commented May 24, 2026

Uh oh!

melvin-bot Bot commented May 24, 2026

Uh oh!

MelvinBot commented May 24, 2026

Uh oh!

Uh oh!

melvin-bot Bot commented May 25, 2026

Uh oh!

github-actions Bot commented May 25, 2026

Uh oh!

aldo-expensify commented May 25, 2026

Uh oh!

github-actions Bot commented May 25, 2026

Uh oh!

OSBotify commented May 25, 2026

Uh oh!

OSBotify commented May 25, 2026

Uh oh!

MelvinBot commented May 25, 2026

Uh oh!

OSBotify commented May 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

MelvinBot commented May 13, 2026 •

edited

Loading

codecov Bot commented May 13, 2026 •

edited by github-actions Bot

Loading