Navigate to report thread in RHP when viewing a report in a right docked modal#90680
Conversation
|
@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
cd26406 to
16384d5
Compare
16384d5 to
92d984a
Compare
|
@mountiny @hungvu193 Could you take a look at it as you were reviewing the original PR? :) |
|
yes. I'll review in the morning |
92d984a to
b3f37f2
Compare
|
@hungvu193 I solved conflicts on this branch, it's ready for your review :) |
|
Thanks for the ping. I'll review in couple of hours |
|
on it 👀 |
|
Oops I'm still able to reproduce the previous deploy blockers, could you have a look? @WojtekBoman Screen.Recording.2026-05-22.at.16.32.00.mov |
Good catch! Thanks for noticing that :) It should be solved now, could you please re-check it? |
|
@hungvu193 should be ready for another look |
|
Checking 👀 |
|
@WojtekBoman Just to confirm, if we're in Inbox, reply in thread won't open RHP right? Screen.Recording.2026-05-25.at.09.24.20.mov |
Yes :) It was discussed during the development of the first PR #88527 (comment) |
Reviewer Checklist
Screenshots/VideosMacOS: Chrome / SafariScreen.Recording.2026-05-22.at.16.30.16.mov |
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.81-0 🚀
|
|
I reviewed the changes in this PR. They are purely internal navigation fixes (clearing stale route params on arrow navigation, keeping users in the Search tab when opening report threads from the RHP, and extracting a shared No changes are required to Expensify's help site files under |
|
Deploy Blocker #91603 was identified to be related to this PR. |
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.81-2 🚀
|
Explanation of Change
Continues #88527 (reverted by deploy blocker #90180): keeps the user in Search when opening report threads from the RHP. Clears stale
reportActionID/referrerparams on next/previous arrow navigation inMoneyRequestReportView— this is the deploy-blocker fix. Adds a sharedgetTopmostFullScreenRoutehelper and routes child reports / explanations throughSEARCH_REPORTwhen Search is the active tab.Fixed Issues
$ #90180
PROPOSAL:
The previous PR (#88527) was reverted because of deploy blocker #90180. That regression is fixed in this PR — see
MoneyRequestReportNavigation.tsx, where the arrow navigation now resetsreportActionIDandreferrerso the next/previous expense no longer loads the "Not Here" page.Tests
/search/...) and the app does not switch to the Inbox tab.Offline tests
Same as Tests — perform the steps with the network connection turned off after the report data has loaded. Verify the same navigation behaviour and that no "Not Here" page is shown for already-loaded reports.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-05-14.at.16.22.17.mov