Stop auto-selecting first account and vendor when changing QBD export type

[blimpich]

Explanation of Change

When an admin changes the company-card export type in the QuickBooks Desktop accounting settings (Credit card / Debit card / Vendor bill), the app silently saved the first account in the imported list as the non-reimbursable account, and the first vendor as the default vendor — without the admin ever opening either picker. The admin saw fields appear filled in on the next screen even though they never chose those values. The same problem caused the summary row on the company-card expense account page to display the first imported account's name when nothing was actually saved.

This is a follow-up to #90276, which removed the same "auto-select first item" pattern for NetSuite, Xero, and four other QBD picker pages, but missed these two spots. The gap was surfaced by an automated review comment on the docs PR #90569 (comment).

This PR:

• Clears the non-reimbursable account and default vendor when the export type changes, so the admin must explicitly select them on the next screens (the available accounts differ per export type, so the previous selection is invalid anyway).
• Removes the display fallback that showed the first account's name when nothing was saved.

Fixed Issues

$ #90721
PROPOSAL:

Tests

Set up a workspace connected to QuickBooks Desktop with at least one imported account of each export type (Credit card, Debit card, Vendor bill / Payable) and at least two vendors.

Scenario 1 — Changing the export type does not silently pick an account or vendor

1. Open the workspace → Accounting → Export → Company card expenses.
2. Use the "Export as" row to switch the export type (for example, from Credit card to Vendor bill).
3. Go back to the Company card expenses page.
4. Verify the account row below "Export as" is empty (no account name is shown).
5. If you picked Vendor bill, verify the Default vendor row is also empty.

Scenario 2 — The account picker does not pre-highlight the first imported account

1. From the Company card expenses page, open the account picker (tap the empty account row).
2. Verify no account is shown as selected when the value is unset.
3. Pick an account, go back, and verify the chosen account name now appears in the summary row.

Scenario 3 — Switching export type clears a previously chosen account/vendor

1. With an account already saved (from Scenario 2), use "Export as" to switch to a different export type.
2. Go back to the Company card expenses page.
3. Verify both the account and the Default vendor rows are empty again.

• Verify that no errors appear in the JS console

Offline tests

Same as Tests, with the device offline before performing each scenario. Verify the UI reflects the offline pending state on the changed fields and that the values still settle to the expected cleared state once back online.

QA Steps

Run the three scenarios in the Tests section above on the staging environment using a workspace connected to QuickBooks Desktop.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

– written by Claude on Ben's behalf

[codecov]

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...DesktopCompanyCardExpenseAccountSelectCardPage.tsx	0.00% <ø> (ø)
...QuickbooksDesktopCompanyCardExpenseAccountPage.tsx	0.00% <0.00%> (ø)
... and 19 files with indirect coverage changes

[melvin-bot]

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[blimpich]

@brunovjk added you as C+ since you've been working on QBD recently and know how to test.

@joekaufmanexpensify @trjExpensify not sure why puller bear assigned three product people, going to unassign you and just leave Flavia

[trjExpensify]

Sounds good. Unsubscribing!

[brunovjk]

I'm a little busy with another PR today, but I'll review by the end of the day.

[brunovjk]

@codex review

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. More of your lovely PRs please.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[brunovjk]

I'm back here, but I'd forgotten that we weren't actually able to test the QBD connection due to "RightNetworks Remote Environment", right @blimpich? Can the QA team test it? Thank you.

[blimpich]

@brunovjk yeah we're still blocked, will update you when it's unblocked 👍

[blimpich]

Looks like we're close to being able to test here again? @brunovjk can you check? https://expensify.slack.com/archives/C9YU7BX5M/p1779307496491309?thread_ts=1778607693.575199&cid=C9YU7BX5M

[brunovjk]

I can't connect to QBD

I got the same error when trying to connect to QBD with "Microsoft Remote Desktop":

@blimpich I followed the steps on 1password, do you know if I need to do something different? Thank you.

[blimpich]

Haven't heard a definitive update yet from @francoisl but should be soon!