Fix: SmartScan shortcut re-navigates when already on SmartScan screen#90782
Fix: SmartScan shortcut re-navigates when already on SmartScan screen#90782gijoe0295 wants to merge 6 commits into
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3ebe3515dc
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@gijoe0295 The change looks good. Could you please apply the fix for other quick actions: Create expense, Track Distance,... Please add a video for Android, too |
|
On it. The Android video was my mistake, uploaded the wrong file. Thanks for pointing out. |
|
The track distance shortcut is a bit different. Still working on it though |
|
@DylanDylann Ready for review |
Explanation of Change
Fixes the issue that SmartScan shortcut re-navigates when already on SmartScan screen.
Fixed Issues
$ #88009
PROPOSAL:
Tests
Offline tests
None
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-05-17.at.11.23.29.mov
Android: mWeb Chrome
iOS: Native
Screen.Recording.2026-05-17.at.11.09.51.mov
Screen.Recording.2026-05-17.at.11.19.38.mov
iOS: mWeb Safari
MacOS: Chrome / Safari