Skip to content

[No QA] Docs updates for E/A#82139 Add receipt upload failure FAQ#90800

Merged
zanyrenney merged 2 commits into
mainfrom
melvin-docs-receipt-upload-error-82139
May 20, 2026
Merged

[No QA] Docs updates for E/A#82139 Add receipt upload failure FAQ#90800
zanyrenney merged 2 commits into
mainfrom
melvin-docs-receipt-upload-error-82139

Conversation

@MelvinBot
Copy link
Copy Markdown
Contributor

Summary

  • Adds a new FAQ entry to the "Attach and edit receipts on expenses" help article documenting the redesigned receipt upload error screen from feat: update error uploading receipt screen #82139
  • Documents the two user-facing options: Save receipt (download before losing it) and Delete expense (remove the failed expense)
  • Adds relevant keywords for discoverability (receipt upload failed, receipt upload error, save receipt, delete expense)

Test plan

  • Verify the new FAQ renders correctly on the help site
  • Verify cross-links and formatting are correct

Documents the new receipt upload error screen introduced in E/A#82139,
including the "Save receipt" and "Delete expense" options.

Co-authored-by: Olimpia <OlimpiaZurek@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label May 15, 2026
@stephanieelliott stephanieelliott marked this pull request as ready for review May 20, 2026 00:19
@stephanieelliott stephanieelliott self-requested a review as a code owner May 20, 2026 00:19
@github-actions
Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR adds a single FAQ entry documenting the receipt upload failure screen (from E/A#82139) and expands the keyword list for discoverability. The change is small, focused, and well-written. It fits naturally within the existing article structure.

Scores Summary

  • Readability: 9/10 - The new FAQ answer is clear, scannable, and uses a concise bulleted format to explain the two options. The em-dash descriptions after the bold button names work well for quick comprehension.
  • AI Readiness: 9/10 - The FAQ heading is task-based and starts with a question word ("What should I do if..."), satisfying the heading rules. The added keywords ("receipt upload failed", "receipt upload error", "save receipt", "delete expense") directly match realistic search queries, improving retrieval. YAML metadata (title, description, internalScope) remains intact.
  • Style Compliance: 9/10 - Button names (Save receipt, Delete expense) are bolded correctly. The exact UI message text is quoted naturally within the explanation. The heading follows the question-word format required by the authoring guidelines.

Key Findings

  • The new FAQ heading ("What should I do if my receipt upload fails?") correctly uses a question word, complying with HELP_AUTHORING_GUIDELINES.md Section 2.
  • Button names Save receipt and Delete expense are properly bolded per HELPSITE_NAMING_CONVENTIONS.md button formatting rules.
  • The keyword fix (adding a space after "New Expensify,") corrects a minor pre-existing formatting issue -- good housekeeping.
  • One minor note: the diff also fixes a pre-existing comma-spacing issue in the keywords array ("New Expensify,attach" becomes "New Expensify, attach"), which is a welcome cleanup.
  • The inline quoting of the error message ("Receipt upload failed. Save the receipt, or delete the expense and lose it.") is helpful for users searching for that exact text.

Recommendations

  • No blocking issues. This is a clean, well-structured addition.
  • Optional: Verify that the button labels Save receipt and Delete expense match the UI exactly (including casing). If the UI shows "Save Receipt" or "DELETE EXPENSE", the article should match precisely.
  • Optional: The internalScope metadata could be updated to mention receipt upload failure handling, since the article now covers that scenario. Currently it reads "Covers attaching, replacing, and cropping receipts on expenses" -- a minor addition like "and handling upload failures" would improve scoping accuracy.

Files Reviewed

  • docs/articles/new-expensify/reports-and-expenses/Attach-and-edit-receipts-on-expenses.md — New FAQ entry added; keywords expanded. Clean and compliant.

This review assessed only the proposed changes in the diff, not pre-existing content.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR adds a new FAQ entry explaining what to do when a receipt upload fails, including the two user-facing options ("Save receipt" and "Delete expense"). The addition is well-scoped, clearly written, and follows governance conventions with only minor observations.

Scores Summary

  • Readability: 9/10 - The new FAQ answer is clear, concise, and scannable. The bullet list with bold option labels and em-dash explanations makes the two choices immediately understandable. The quoted error message text is helpful context.
  • AI Readiness: 9/10 - The heading is a proper question ("What should I do if..."), new keywords (receipt upload failed, receipt upload error, save receipt, delete expense) align with real search queries, and YAML metadata is complete including internalScope. The duplicate "New Expensify" keyword in the old list was also cleaned up.
  • Style Compliance: 9/10 - UI option labels Save receipt and Delete expense are bolded correctly. The error message text is presented as a quoted phrase rather than a bold UI element, which is appropriate since it is a system message, not a clickable button. One minor note: verify that the exact casing of the option labels matches the UI precisely (governance requires exact match).

Key Findings

  • The FAQ question follows the required question-word format ("What should I do if..."), satisfying heading compliance rules.
  • Keywords were meaningfully expanded with terms users would actually search for when encountering this error.
  • The duplicate "New Expensify" entry in the keywords array was removed as part of this change -- a good cleanup.
  • The blank line between the ## heading and the body paragraph is acceptable Markdown but is worth noting as a minor stylistic choice; other FAQ entries in this file do not use that extra blank line. Consistency within the file is worth considering.
  • No cross-links are included, which is appropriate here since the FAQ is self-contained.
  • No structural violations: the content stays under ## headings, no ### or deeper headings are introduced.

Recommendations

  1. Confirm that Save receipt and Delete expense match the exact UI button text and casing shown in the product. If the UI says "Save Receipt" or "DELETE EXPENSE", the article must match exactly.
  2. Consider removing the blank line between ## What should I do if my receipt upload fails? and the first paragraph to match the formatting pattern used by other FAQ entries in this file (e.g., "Can I crop or rotate an eReceipt?" flows directly into its answer).

Files Reviewed

  • docs/articles/new-expensify/reports-and-expenses/Attach-and-edit-receipts-on-expenses.md -- New FAQ entry added for receipt upload failure; keywords updated. Changes are clean and compliant.

@github-actions github-actions Bot changed the title Docs updates for E/A#82139 Add receipt upload failure FAQ [No QA] Docs updates for E/A#82139 Add receipt upload failure FAQ May 20, 2026
@OSBotify
Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://2fe0f325.helpdot.pages.dev ⚡️

Updated articles:

@stephanieelliott stephanieelliott self-assigned this May 20, 2026
@stephanieelliott stephanieelliott requested a review from a team May 20, 2026 01:12
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented May 20, 2026

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @zanyrenney

@melvin-bot melvin-bot Bot requested a review from zanyrenney May 20, 2026 01:13
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented May 20, 2026

@zanyrenney Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot removed the request for review from a team May 20, 2026 01:13
@zanyrenney

This comment was marked as off-topic.

@zanyrenney
Copy link
Copy Markdown
Contributor

@stephanieelliott why is it showing this? #90800 (comment)

i don't think thats required right? it should just be the conci reviewer one. which i have done! 🎉

@zanyrenney zanyrenney merged commit c6de9be into main May 20, 2026
20 checks passed
@zanyrenney zanyrenney deleted the melvin-docs-receipt-upload-error-82139 branch May 20, 2026 09:32
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented May 20, 2026

@zanyrenney looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@melvin-bot melvin-bot Bot added the Emergency label May 20, 2026
@github-actions
Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR makes a focused, well-crafted update to the receipts article: it fixes a keyword formatting issue, removes a duplicate keyword entry, adds relevant new search keywords, and introduces a new FAQ entry covering the receipt upload failure scenario. The changes are minor in scope but consistently follow governance standards.

Scores Summary

  • Readability: 9/10 - The new FAQ entry is clear and scannable. The bold option names with dash-separated descriptions make it easy to distinguish the two actions. The quoted error message gives users an exact string to match against what they see in the UI.
  • AI Readiness: 9/10 - The FAQ heading ("What should I do if my receipt upload fails?") uses a question word and is task-based, matching real user search intent. Four new keywords (receipt upload failed, receipt upload error, save receipt, delete expense) strengthen retrieval. The duplicate "New Expensify" keyword removal is a good cleanup.
  • Style Compliance: 9/10 - Button/option names ("Save receipt", "Delete expense") are correctly bolded per button naming standards. The FAQ structure matches the existing pattern in the article and aligns with TEMPLATE.md guidance.

Key Findings

  • The keyword line fix (adding a missing space after comma and removing the duplicate "New Expensify" entry) corrects a pre-existing formatting issue -- good housekeeping.
  • The new FAQ question follows the required question-word heading pattern ("What should I do if...").
  • The two options are presented with bold labels and concise explanations, consistent with naming conventions.
  • One minor observation: The phrase "Save receipt" and "Delete expense" appear to be UI-presented options rather than traditional buttons. Confirm these match the exact labels shown in the product UI, as required by the naming conventions ("Use the exact text shown in the product UI").

Recommendations

  • Verify that Save receipt and Delete expense match the exact casing and wording displayed in the app UI. If the UI says "Save Receipt" or "Delete Expense" (title case), update accordingly.
  • No structural or compliance issues require changes.

Files Reviewed

  • docs/articles/new-expensify/reports-and-expenses/Attach-and-edit-receipts-on-expenses.md -- keyword cleanup and new FAQ entry for receipt upload failure. Compliant with governance standards.

This review assessed only the proposed changes in the PR diff, not unchanged portions of the file.

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/zanyrenney in version: 9.3.79-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.79-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants