Docs updates for E/A#87928 Unified private personal details form with magic code#90803
Docs updates for E/A#87928 Unified private personal details form with magic code#90803MelvinBot wants to merge 1 commit into
Conversation
Update Account-Settings and Update-Your-Expensify-Card-Mailing-Address articles to reflect the new unified personal details form with magic code verification, replacing references to individual edit pages. Co-authored-by: Jasper Huang <jasperhuangg@users.noreply.github.com>
HelpDot Documentation ReviewOverall AssessmentThis PR updates two help articles to reflect a new unified personal details form with magic code verification. The changes are small and focused: adding a verification step, updating field references, and adjusting navigation language. The modifications are well-scoped and maintain consistency with the existing article structure. Scores Summary
Key FindingsIssues to address:
Positive aspects:
Recommendations
Files Reviewed
|
| 2. Select **Profile**. | ||
| 3. Under **Private**, select **Phone number**. | ||
| 4. Enter your updated phone number and click **Save**. | ||
| 4. Update your phone number on the personal details form and click **Save**. |
There was a problem hiding this comment.
Naming and style: Same as above -- "on the personal details form" is not a verified UI label. Per HELPSITE_NAMING_CONVENTIONS.md, reference exact UI text. If the UI does not display this phrase, remove it or replace it with the actual label shown in the product.
| 2. Scroll to the **Private Details** section. | ||
| 3. Update the **Legal Name**, **Date of Birth**, or **Address** fields. | ||
| 2. Under **Private**, select any field (**Legal name**, **Date of birth**, **Phone number**, or **Address**). | ||
| 3. Update the fields you want to change on the unified personal details form. |
There was a problem hiding this comment.
Naming and style: "unified personal details form" is not an exact UI label. Per HELPSITE_NAMING_CONVENTIONS.md, do not invent or generalize UI element names. Use the exact text shown in the product. Consider simplifying to something like: "Update the relevant fields." or reference the actual UI label if one exists.
| 1. Go to **Account > Profile**. | ||
| 2. For display name: Click **Display Name**, enter your preferred name, and click **Save**. | ||
| 3. For legal name: Scroll to **Private Details**, click **Legal Name**, update it, and click **Save**. | ||
| 3. For legal name: Under **Private**, select **Legal name**, update it on the personal details form, click **Save**, and enter the magic code to confirm. |
There was a problem hiding this comment.
Readability / structure: This step chains too many actions into a single numbered step (select, update, save, enter magic code). Per HELP_AUTHORING_GUIDELINES.md Section 5, steps must be sequential, clear, and action-oriented. Break this into separate numbered steps, similar to how the "Personal Information" section above handles it.
Also, "on the personal details form" is not a verified UI label (same naming concern flagged above).
| 2. Under **Private**, select any field (**Legal name**, **Date of birth**, **Phone number**, or **Address**). | ||
| 3. Update the fields you want to change on the unified personal details form. | ||
| 4. Click **Save**. | ||
| 5. If any field was changed, enter the magic code sent to your primary contact method to confirm the update. |
There was a problem hiding this comment.
Readability / structure: "If any field was changed" introduces unnecessary conditionality. The user just performed the update in the preceding steps, so this step will always apply. Per HELPSITE_NAMING_CONVENTIONS.md (Deterministic Writing Rule), be literal and avoid hedging. Consider rephrasing to: "Enter the magic code sent to your primary contact method to confirm the update."
Summary
Account-Settings.mdandUpdate-Your-Expensify-Card-Mailing-Address.mdto describe the new flowChanged articles
docs/articles/new-expensify/settings/Account-Settings.md— Updated "Personal Information" and "Display or Legal Name" sectionsdocs/articles/new-expensify/expensify-card/Update-Your-Expensify-Card-Mailing-Address.md— Updated legal name and phone number update steps to include magic code confirmation