Skip to content

Docs updates for E/A#90557 Add deposit-only restriction to Share Bank Account article#90809

Merged
stephanieelliott merged 1 commit into
mainfrom
melvin/docs-share-bank-account-deposit-only
May 22, 2026
Merged

Docs updates for E/A#90557 Add deposit-only restriction to Share Bank Account article#90809
stephanieelliott merged 1 commit into
mainfrom
melvin/docs-share-bank-account-deposit-only

Conversation

@MelvinBot
Copy link
Copy Markdown
Contributor

Summary

Related PR

#90557

…ccount article

Update help article to reflect that deposit-only bank accounts (allowDebit=false)
cannot be shared, matching the behavior change in E/A#90557.

Co-authored-by: Fedi Rajhi <fedirjh@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label May 15, 2026
@stephanieelliott stephanieelliott marked this pull request as ready for review May 20, 2026 00:11
@stephanieelliott stephanieelliott self-requested a review as a code owner May 20, 2026 00:11
@github-actions
Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This is a small, focused PR that adds two lines documenting the deposit-only bank account restriction for sharing. The changes are clear, well-placed, and consistent with the existing article structure. The additions accurately reflect the behavioral change from #90557.

Scores Summary

  • Readability: 9/10 - The new text is concise and immediately understandable. Both additions integrate naturally into their respective bullet lists without disrupting flow. Minor note: the first addition packs two sentences into a single bullet, which slightly reduces scannability compared to the existing single-statement bullets around it.
  • AI Readiness: 9/10 - The additions use specific, descriptive language ("deposit-only accounts," "supports withdrawals") that aligns well with realistic search queries. The terms reinforce retrieval for users searching about why they cannot share a bank account.
  • Style Compliance: 10/10 - The changes follow all naming conventions. No UI elements are referenced incorrectly, no prohibited language is used, and the phrasing is deterministic and precise.

Key Findings

  • The two additions are placed in the correct locations: the eligibility section ("Who can share") and the troubleshooting FAQ ("Why don't I see the Share option?"), which are the two places a user would look for this information.
  • The wording is consistent between both additions ("deposit-only accounts cannot be shared"), which supports deterministic writing per the governance rules.
  • No structural, heading, or metadata changes were needed for this update, and none were introduced unnecessarily.

Recommendations

  • Consider whether the first changed line (line 17 in the new file) would read better as two separate bullets rather than appending a second sentence to the existing bullet. For example, splitting into "You can only share verified business bank accounts that support withdrawals." and "Deposit-only accounts cannot be shared." as separate bullets would match the one-statement-per-bullet pattern used elsewhere in that list. This is a minor suggestion and not a blocker.

Files Reviewed

  • docs/articles/new-expensify/wallet-and-payments/Share-a-Business-Bank-Account.md - Two additions documenting the deposit-only restriction. Clean and well-integrated.

This review assessed only the proposed changes in the diff, not unchanged portions of the file.

@github-actions
Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR makes a small, focused addition to the Share a Business Bank Account article. It clarifies that only business bank accounts supporting withdrawals can be shared, and that deposit-only accounts are excluded. The change touches two locations: one bullet in the eligibility section and one bullet in the FAQ troubleshooting answer. Both additions are consistent with each other and add useful specificity for readers.

Scores Summary

  • Readability: 9/10 - The added text is clear, concise, and easy to scan. The first change packs two pieces of information into a single bullet (verified + supports withdrawals + deposit-only exclusion), which is slightly dense but still readable. The FAQ addition is clean and well-placed.
  • AI Readiness: 9/10 - The article already has strong YAML metadata, task-based headings, and proper heading hierarchy. The new content uses plain, descriptive language that will retrieve well for queries about deposit-only accounts or sharing restrictions. No metadata updates were needed for this incremental clarification.
  • Style Compliance: 10/10 - The changes follow naming conventions correctly. Workspace Admins, Share, and other UI elements remain properly bolded. No prohibited language is introduced. Terminology is consistent with the rest of the article and governance standards.

Key Findings

  • The two additions are internally consistent: both the eligibility section and the FAQ "Why don't I see the Share option?" answer now mention the withdrawal requirement, so users encounter this information regardless of where they look.
  • The phrasing "deposit-only accounts cannot be shared" is repeated verbatim in both locations. This is acceptable for scannability, though a minor stylistic consideration.
  • No governance violations were introduced by these changes.

Recommendations

  • No blocking issues. This PR is ready to merge from a documentation quality standpoint.
  • Optional: In line 17, consider splitting the dense bullet into two separate bullets for improved scannability (one for "verified" requirement, one for "supports withdrawals" requirement). This is a minor suggestion, not a required change.

Files Reviewed

  • docs/articles/new-expensify/wallet-and-payments/Share-a-Business-Bank-Account.md - Two bullet additions clarifying withdrawal support requirement. Clean, compliant changes.

Review based on docs/HELPSITE_NAMING_CONVENTIONS.md, docs/HELP_AUTHORING_GUIDELINES.md, and docs/TEMPLATE.md governance standards.

@stephanieelliott stephanieelliott self-assigned this May 20, 2026
@stephanieelliott stephanieelliott requested a review from a team May 20, 2026 01:15
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented May 20, 2026

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @jliexpensify

@melvin-bot melvin-bot Bot requested review from jliexpensify and removed request for a team May 20, 2026 01:15
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented May 20, 2026

@jliexpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Copy link
Copy Markdown
Contributor

@jliexpensify jliexpensify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


The **Share** option only appears if:
- The account is verified
- The account supports withdrawals (deposit-only accounts cannot be shared)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readability / structure: This bullet duplicates the information already added on line 17 ("You can only share verified business bank accounts that support withdrawals. Deposit-only accounts cannot be shared."). Consider removing this bullet or rewording the FAQ answer to reference the prerequisite section instead of repeating the same detail, to keep the article concise per the "Be concise and actionable" core principle in HELP_AUTHORING_GUIDELINES.md Section 1.

@github-actions
Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR makes a small, focused addition to the "Share a Business Bank Account" article, clarifying that only bank accounts supporting withdrawals can be shared -- deposit-only accounts are excluded. The change adds this information in two appropriate locations: the eligibility section and the FAQ troubleshooting answer. The additions are consistent with the existing article's tone and structure.

Scores Summary

  • Readability: 9/10 - The added text is clear, concise, and fits naturally into existing bullet lists. The phrasing "that support withdrawals. Deposit-only accounts cannot be shared." is direct and scannable.
  • AI Readiness: 9/10 - The new content uses specific, searchable terminology ("deposit-only accounts," "supports withdrawals") that aligns well with realistic user queries. The existing YAML metadata and heading structure remain intact and compliant. Minor note: the internalScope field could be updated to mention the withdrawal/deposit-only distinction, but this is a minor enhancement rather than a deficiency.
  • Style Compliance: 10/10 - The additions follow naming conventions correctly. Bold formatting is used appropriately for the Share label. No prohibited language, no vague phrasing. Bullet formatting is consistent with surrounding content.

Key Findings

  • The change is surgically placed in the two most relevant locations -- the eligibility requirements list and the FAQ answer for "Why don't I see the Share option?" -- which is good information architecture.
  • The phrasing is consistent between both locations, reinforcing the message without unnecessary variation.
  • No governance violations detected in the proposed changes.

Recommendations

  • Consider updating the internalScope metadata to mention the deposit-only exclusion (e.g., "Does not cover initial bank account setup, validation, unsharing, unlocking, or deposit-only accounts."). This would improve AI retrieval precision for queries about deposit-only account limitations.
  • No other changes are needed. This is a clean, well-placed addition.

Files Reviewed

  • docs/articles/new-expensify/wallet-and-payments/Share-a-Business-Bank-Account.md - Two bullet points added clarifying withdrawal-only sharing requirement. Both additions are compliant and well-integrated.

@stephanieelliott stephanieelliott merged commit 3aef834 into main May 22, 2026
30 checks passed
@stephanieelliott stephanieelliott deleted the melvin/docs-share-bank-account-deposit-only branch May 22, 2026 01:46
@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.3.80-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@kavimuru
Copy link
Copy Markdown

@stephanieelliott please share the QA steps.

@jliexpensify
Copy link
Copy Markdown
Contributor

@kavimuru this is a HelpDoc update, so I don't think QA steps are necessary!

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.81-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants