[NoQA] Use Classic approval mode values for Gusto by ShridharGoel · Pull Request #90868 · Expensify/App

ShridharGoel · 2026-05-16T08:21:57Z

Explanation of Change

This PR updates the NewDot Gusto approval mode constants to use the Classic-compatible enum values.

This keeps existing Classic-created Gusto workspaces from showing Approval mode as Not set, and makes NewDot writes send the same APPROVAL_* values Classic expects.

Fixed Issues

$ #90423
PROPOSAL: N/A

Tests

Open a Control workspace with Gusto connected and an approval mode stored as a Classic APPROVAL_* value.
Go to Workspace settings > HR.
Verify the Approval mode row shows the correct label instead of Not set.
Open the Approval mode page.
Verify the matching approval mode option is selected.
Change the approval mode and save.
Verify UpdateGustoApprovalMode sends an APPROVAL_* value.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2026-05-16T08:23:57Z

@dmkt9 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ShridharGoel · 2026-05-16T08:26:55Z

@shubham1206agra will be reviewing as part of a project

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 577b2e3181

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

shubham1206agra · 2026-05-16T12:49:54Z

@@ -2869,9 +2869,9 @@ const CONST = {

    GUSTO: {


shubham1206agra · 2026-05-16T13:01:45Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
xIf a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2026-05-16.at.6.30.42.PM.mov

melvin-bot · 2026-05-18T18:23:25Z

@yuwenmemon looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

github-actions · 2026-05-18T18:23:58Z

🚧 @yuwenmemon has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-05-18T18:28:07Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #90868.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-b489d47-a7adfc8-b01bdd1eafdf37594f35814428e2ca2693137451/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-b489d47-a7adfc8-5473f7ca5a7347e2f24cce82523a6359745904d9/index.html

Web 🕸️
https://90868.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-18T18:33:32Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-05-19T08:09:51Z

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.3.76-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

MelvinBot · 2026-05-19T08:11:19Z

No help site changes are required for this PR.

The change updates internal Gusto approval mode constant values (basic → APPROVAL_SUBMIT_AND_APPROVE, manager → APPROVAL_ADVANCED, custom → APPROVAL_MANUAL) to match Classic-compatible enum values. This is purely a backend API value change — no user-facing labels, workflows, or documentation-relevant behavior changed.

The existing Gusto help article references user-facing terms ("Basic Approval", "Manager Approval", "Manual Configuration") which remain accurate.

OSBotify · 2026-05-19T22:02:21Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.77-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Use Classic Gusto approval mode values

577b2e3

melvin-bot Bot assigned ShridharGoel May 16, 2026

ShridharGoel changed the title ~~[Gusto] Use Classic approval mode values~~ [NoQA] Use Classic approval mode values for Gusto May 16, 2026

ShridharGoel marked this pull request as ready for review May 16, 2026 08:23

ShridharGoel requested review from a team as code owners May 16, 2026 08:23

melvin-bot Bot requested review from dmkt9 and trjExpensify and removed request for a team May 16, 2026 08:23

melvin-bot Bot removed the request for review from a team May 16, 2026 08:23

chatgpt-codex-connector Bot reviewed May 16, 2026

View reviewed changes

Comment thread src/CONST/index.ts

shubham1206agra reviewed May 16, 2026

View reviewed changes

Comment thread src/CONST/index.ts

@@ -2869,9 +2869,9 @@ const CONST = {

GUSTO: {

Copy link
Copy Markdown

Contributor

shubham1206agra May 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my K2

shubham1206agra approved these changes May 16, 2026

View reviewed changes

melvin-bot Bot requested a review from yuwenmemon May 16, 2026 13:02

mhawryluk mentioned this pull request May 18, 2026

[NoQA] [HR Import] Add MERGE_HR consts, types, and provider map #90949

Merged

50 tasks

yuwenmemon approved these changes May 18, 2026

View reviewed changes

yuwenmemon merged commit b489d47 into Expensify:main May 18, 2026
54 of 56 checks passed

melvin-bot Bot added the Emergency label May 18, 2026

OSBotify mentioned this pull request May 19, 2026

Deploy Checklist: New Expensify 2026-05-19 #91039

Closed

75 tasks

melvin-bot Bot mentioned this pull request May 19, 2026

[Due for payment 2026-05-26] [Bug] [Gusto] Gusto approval mode shows "Not Set" — align NewDot constants with the Classic enum values #90423

Open

Conversation

ShridharGoel commented May 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented May 16, 2026

Uh oh!

ShridharGoel commented May 16, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

shubham1206agra May 16, 2026

Choose a reason for hiding this comment

Uh oh!

shubham1206agra commented May 16, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

melvin-bot Bot commented May 18, 2026

Uh oh!

github-actions Bot commented May 18, 2026

Uh oh!

github-actions Bot commented May 18, 2026

Uh oh!

OSBotify commented May 18, 2026

Uh oh!

OSBotify commented May 19, 2026

Uh oh!

MelvinBot commented May 19, 2026

Uh oh!

OSBotify commented May 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ShridharGoel commented May 16, 2026 •

edited

Loading