Fix settings tags/categories URL redirecting to Inbox by MelvinBot · Pull Request #90911 · Expensify/App

MelvinBot · 2026-05-17T14:07:42Z

Explanation of Change

When navigating to /settings/{policyID}/tags (e.g. by manually editing the URL), the Tags RHP opens correctly but the background page redirects to Inbox. This happens because SETTINGS_TAGS screens are not registered in any RELATIONS map, so getMatchingFullScreenRoute returns undefined and the fallback prepends REPORTS_SPLIT_NAVIGATOR (Inbox) as the background.

This PR adds all SETTINGS_TAGS.* screens to the SCREENS.WORKSPACE.TAGS relation and all SETTINGS_CATEGORIES.* screens to the SCREENS.WORKSPACE.CATEGORIES relation in WORKSPACE_TO_RHP.ts. This allows getMatchingFullScreenRoute to resolve the correct workspace split navigator as the background instead of falling back to Inbox. The same fix is applied to the analogous /settings/{policyID}/categories route which has the identical defect.

Fixed Issues

$ #90080
PROPOSAL: #90080 (comment)

Tests

Open the app on web (e.g. dev.new.expensify.com or local dev server)
Ensure you have a workspace with Tags enabled
Navigate to Workspaces > [Your Workspace] > Tags — note the URL looks like /workspaces/{policyID}/tags
Manually change the URL from /workspaces/{policyID}/tags to /settings/{policyID}/tags and press Enter
Verify the Tags RHP opens and the background stays on the workspace page (not Inbox)
Repeat the same test with Categories: navigate to /workspaces/{policyID}/categories, change the URL to /settings/{policyID}/categories, and verify the background stays on the workspace page
Verify that no errors appear in the JS console

Offline tests

N/A - this change only affects URL-to-navigation-state mapping and does not involve network requests.

QA Steps

Open staging.new.expensify.com on web
Ensure you have a workspace with Tags enabled
Navigate to Workspaces > [Your Workspace] > Tags
Manually edit the URL from /workspaces/{policyID}/tags to /settings/{policyID}/tags and press Enter
Verify the Tags RHP opens and the background remains on the workspace page (does not redirect to Inbox)
Repeat the same test with Categories: navigate to /workspaces/{policyID}/categories, change URL to /settings/{policyID}/categories, and verify the background stays on the workspace page
Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

… relations When navigating to /settings/{policyID}/tags, the navigation adapter could not resolve the correct background screen because SETTINGS_TAGS screens were not registered in any RELATIONS map. This caused the fallback to prepend REPORTS_SPLIT_NAVIGATOR (Inbox) as the background. Register all SETTINGS_TAGS screens under SCREENS.WORKSPACE.TAGS and all SETTINGS_CATEGORIES screens under SCREENS.WORKSPACE.CATEGORIES in WORKSPACE_TO_RHP.ts so getMatchingFullScreenRoute resolves the workspace split navigator as the background. Co-authored-by: Shridhar Goel <ShridharGoel@users.noreply.github.com>

ShridharGoel · 2026-05-17T15:06:22Z

@MelvinBot Fill the checklist and add manual testing steps

MelvinBot · 2026-05-17T15:08:51Z

Updated the PR description:

Tests section: Added manual steps to verify that navigating to /settings/{policyID}/tags and /settings/{policyID}/categories keeps the workspace page as the background instead of redirecting to Inbox.
QA Steps section: Added equivalent steps for staging.
Checklist: Checked off applicable items. Left unchecked items that require manual platform testing and screenshots (those need to be filled by the human co-author).

Note: Screenshots/videos and multi-platform testing still need to be added before marking as ready for review.

ShridharGoel · 2026-05-17T15:11:02Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

Screen.Recording.2026-05-17.at.8.53.06.PM.mov

iOS: HybridApp

iOS: mWeb Safari

Screen.Recording.2026-05-18.at.6.18.25.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2026-05-17.at.8.39.53.PM.mov

ShridharGoel · 2026-05-17T15:11:18Z

@MelvinBot Mark it as ready for review

MelvinBot · 2026-05-17T15:12:49Z

Marked as ready for review.

melvin-bot · 2026-05-17T15:12:51Z

@ShridharGoel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ShridharGoel · 2026-05-17T15:13:31Z

@MelvinBot Mark all checkboxes as checked in the description

melvin-bot · 2026-05-17T15:13:48Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #90080 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

MelvinBot · 2026-05-17T15:14:37Z

Done — all checkboxes in the PR description have been marked as checked.

cead22 · 2026-05-18T11:50:05Z

@MelvinBot Mark all checkboxes as checked in the description

@ShridharGoel I don't think we should be doing this. The point of the checklist if for authors and reviewers to go over all the items to make sure they're done.

Can you add the videos to the reviewer checklist that are missing?

ShridharGoel · 2026-05-18T12:20:05Z

@cead22 This is a web-only issue, hence native videos were skipped since we can only check the issue on wide layouts. But I'll add some sanity videos of the remaining platforms as well.

And the comment to MelvinBot was for the author checklist, since I can't edit it.

github-actions · 2026-05-18T12:43:55Z

🚧 @cead22 has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-05-18T12:48:30Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #90911.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-386fe36-123ad41-ff47f9760640c80b9f590c6fae5b5dcc7e17bb77/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-386fe36-123ad41-52ab6946969630b4d741f8e412f0880a1421b07d/index.html

Web 🕸️
https://90911.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-18T12:52:56Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-05-19T08:10:22Z

🚀 Deployed to staging by https://github.com/cead22 in version: 9.3.76-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

MelvinBot · 2026-05-19T08:11:46Z

No help site changes are required.

This PR is an internal navigation/routing fix — it adds screen entries to WORKSPACE_TO_RHP.ts so that manually editing certain URLs no longer causes an incorrect background redirect to Inbox. No user-facing features, terminology, settings, or workflows are affected.

OSBotify · 2026-05-19T22:02:45Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.77-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot assigned ShridharGoel May 17, 2026

MelvinBot requested a review from a team May 17, 2026 14:07

MelvinBot mentioned this pull request May 17, 2026

[Due for payment 2026-05-26] [$250] Web - Tags - User is navigated to "Inbox" on background after updating URL to "Settings" #90080

Open

7 tasks

MelvinBot marked this pull request as ready for review May 17, 2026 15:12

MelvinBot requested a review from a team as a code owner May 17, 2026 15:12

melvin-bot Bot requested review from ShridharGoel and trjExpensify and removed request for a team May 17, 2026 15:12

ShridharGoel approved these changes May 17, 2026

View reviewed changes

melvin-bot Bot requested a review from cead22 May 17, 2026 15:13

cead22 approved these changes May 18, 2026

View reviewed changes

cead22 merged commit 386fe36 into main May 18, 2026
56 of 59 checks passed

cead22 deleted the claude-fixSettingsTagsInboxRedirect branch May 18, 2026 12:42

OSBotify mentioned this pull request May 19, 2026

Deploy Checklist: New Expensify 2026-05-19 #91039

Closed

75 tasks

mitarachim mentioned this pull request May 19, 2026

[Due for payment 2026-05-26] Workspace - Blank workspace details page opens in the background when link is invalid #91087

Closed

7 tasks

Conversation

MelvinBot commented May 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

ShridharGoel commented May 17, 2026

Uh oh!

MelvinBot commented May 17, 2026

Uh oh!

ShridharGoel commented May 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ShridharGoel commented May 17, 2026

Uh oh!

MelvinBot commented May 17, 2026

Uh oh!

melvin-bot Bot commented May 17, 2026

Uh oh!

ShridharGoel commented May 17, 2026

Uh oh!

melvin-bot Bot commented May 17, 2026

Uh oh!

MelvinBot commented May 17, 2026

Uh oh!

cead22 commented May 18, 2026

Uh oh!

ShridharGoel commented May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented May 18, 2026

Uh oh!

github-actions Bot commented May 18, 2026

Uh oh!

OSBotify commented May 18, 2026

Uh oh!

OSBotify commented May 19, 2026

Uh oh!

MelvinBot commented May 19, 2026

Uh oh!

OSBotify commented May 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

MelvinBot commented May 17, 2026 •

edited

Loading

ShridharGoel commented May 17, 2026 •

edited

Loading

ShridharGoel commented May 18, 2026 •

edited

Loading