Skip retries in retryOperation for non-retriable storage errors

[elirangoshen]

Explanation of Change

Pins react-native-onyx to the head SHA of the companion library draft PR Expensify/react-native-onyx#786, which adds a NON_RETRIABLE_ERRORS classification and short-circuits retryOperation for storage errors where retrying is provably futile — specifically UnknownError: Internal error opening backing store for indexedDB.open (the LevelDB backing-store class analyzed in #87862).

Today, every non-capacity storage error retries 5× with no delay then silently resolves. For this error class — 884,955 occurrences, ~26% of all storage failures — that produces ~6× the log/Sentry volume of the underlying event rate. The healing path (#90636) is responsible for recovery; retryOperation should defer to it, not compete with it.

This PR also drops the patches/react-native-onyx/ directory, mirroring the approach used on the parallel 90632 draft branch — the 3.0.71 patch does not apply to 3.0.74, and patch restoration is tracked under the upstream replacement Expensify/react-native-onyx#785.

Fixed Issues

$ #90633
PROPOSAL: N/A (Task-labelled issue with explicit solution from #87862 analysis)

Tests

1. Open the App in Chrome with DevTools.
2. In the console, override Storage.setItem to reject with the target error:

   const target = require('react-native-onyx/dist/storage').default;
   const origSet = target.setItem;
   target.setItem = () => Promise.reject(Object.assign(new Error('Internal error opening backing store for indexedDB.open.'), {name: 'UnknownError'}));

3. Trigger any Onyx write (e.g., open a chat, change a setting).
4. Verify in the console:
   • Exactly one Failed to save to storage. Error: ... retryAttempt: 0/5 log (not six).
   • Exactly one Storage operation skipped retry for non-retriable error. Error: ... onyxMethod: setWithRetry. alert.
   • No Storage operation failed after 5 retries... alert.
5. Restore via target.setItem = origSet; and confirm normal operation resumes (no further errors).

• Verify that no errors appear in the JS console

Offline tests

The change is purely a logging short-circuit on an error path that already silently swallows the failure. Offline behavior is unchanged — Onyx.set callers still see the same observable outcome (cache absorbs the write; promise resolves), exactly as today. No offline-specific verification needed beyond confirming the App still functions normally with the network disabled.

QA Steps

This is a logging-only change with no UI impact, so there are no user-visible behaviors to QA on staging. The production signal will come from VictoriaLogs:

• After deploy, query: Failed to save to storage. Error: ...Internal error opening backing store... — volume should drop by ~5–6×.

• Query: Storage operation skipped retry for non-retriable error — should appear at roughly 1× the underlying event rate (was previously hidden behind 6 retries).

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[github-actions]

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️