Certinia/r1 pr2 certinia pages by ChavdaSachin · Pull Request #91004 · Expensify/App

ChavdaSachin · 2026-05-18T18:40:04Z

Explanation of Change

Fixed Issues

$ #89433
PROPOSAL: NA

Tests

Same as QA.

Verify that no errors appear in the JS console

Offline tests

Same as QA.

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Prerequisite: an account with "financialForceNewDot" beta enabled.

Test 1 - Collect workspace

Go to a collect workspace -> accounting page.
Click the connect button for Certinia.
Verify, upgrade workspace modal pops up.
Click upgrade then got it, thanks.
Verify prerequisites/use existing connection flow opens.

Test 2 - control workspace, and there's no existing Certinia connection on other workspaces

Go to a collect workspace -> accounting page.
Click the connect button for Certinia.
Verify that the prerequisite flow opens.
Complete the prerequisite flow and connect to the Certinia account.
Verify the account is connected successfully.

Test 3 - have a workspace with an existing Certinia connection.

Create a new control workspace.
Go to workspace -> accounting page.
Click the connect button for Certinia.
Verify that the popover menu with options connect to Certinia and reuse existing connection pops up.
Click the Reuse existing connection option.
Click one of the existing connections from the list.
Verify Certinia is connected successfully.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-05-19.at.1.03.14.AM.mov

Screen.Recording.2026-05-19.at.1.04.25.AM.mov

melvin-bot · 2026-05-18T18:40:09Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

ChavdaSachin · 2026-05-18T19:46:28Z

@yuwenmemon, please run the translation workflow here.
Thanks.

melvin-bot · 2026-05-18T19:46:38Z

@thelullabyy Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7a55ed512f

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-05-18T19:57:01Z

+    const shouldBeBlocked = !!config?.isConfigured && !isAuthenticationError(policy, CONST.POLICY.CONNECTIONS.NAME.CERTINIA);
+
+    const handleConnect = () => {
+        connectPolicyToFinancialForce(policyID, false, environmentURL);


Preserve sandbox mode when initiating Certinia OAuth

connectPolicyToFinancialForce is always called with false, so this flow ignores the :isSandbox route mode and always builds a production Salesforce auth URL. In sandbox-only Certinia setups, users are redirected to login.salesforce.com instead of a sandbox endpoint, which prevents completing authentication and blocks setup from this page.

Useful? React with 👍 / 👎.

Would be added in release 3

OSBotify · 2026-05-18T20:41:11Z

🦜 Polyglot Parrot! 🦜

Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues:

The diff is too large to include in this comment (95KB), so I've created a gist for you:

📋 View the translation diff here 📋

Note

You can apply these changes to your branch by copying the patch to your clipboard, then running pbpaste | git apply, or directly by running gh gist view --raw 3611ac931da39b21c659a4bf433107b6 | git apply 😉

View workflow run

trjExpensify

Core PR for a WN project.

codecov · 2026-05-19T10:03:52Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	`92.36% <ø> (ø)`
src/pages/workspace/upgrade/UpgradeIntro.tsx	`93.10% <100.00%> (ø)`
...gation/AppNavigator/ModalStackNavigators/index.tsx	`6.68% <0.00%> (-0.02%)`	⬇️
...s/workspace/accounting/AccountingContext/index.tsx	`0.00% <0.00%> (ø)`
...ages/workspace/accounting/PolicyAccountingPage.tsx	`0.00% <0.00%> (ø)`
src/pages/workspace/accounting/utils.tsx	`0.00% <0.00%> (ø)`
.../accounting/certinia/CertiniaPrerequisitesPage.tsx	`0.00% <0.00%> (ø)`
...nting/certinia/CertiniaExistingConnectionsPage.tsx	`0.00% <0.00%> (ø)`
...rtinia/prerequisites/CertiniaPrerequisitesStep.tsx	`0.00% <0.00%> (ø)`
src/components/ConnectToCertiniaFlow/index.tsx	`0.00% <0.00%> (ø)`
... and 14 files with indirect coverage changes

thelullabyy · 2026-05-19T14:56:41Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

thelullabyy · 2026-05-19T14:57:05Z

@ChavdaSachin checks are failed

ChavdaSachin · 2026-05-19T15:00:40Z

TS failure is irrelevant. Fixing the lint error.

thelullabyy · 2026-05-19T16:12:11Z

@trjExpensify Could you please help assign me as reviewer here? Thanks

trjExpensify · 2026-05-19T17:18:03Z

@trjExpensify Could you please help assign me as reviewer here? Thanks

Done

thelullabyy · 2026-05-20T14:08:30Z

@Expensify/design Could you please jump in to check if the UI looks good? Thanks

ChavdaSachin · 2026-05-20T14:11:54Z

@Expensify/design, Please run the following console command to enable the beta.

Onyx.merge("betas", ["financialForceNewDot"]);

shawnborton · 2026-05-20T14:43:27Z

The space below "Other" seems a bit big - can we check other connections to see how that looks?

Otherwise the videos look pretty good to me 👍

ChavdaSachin · 2026-05-20T17:26:18Z

@thelullabyy, could you approve the PR?
I have a draft for the next PR based on the current here - #91221

…tinia-pages

thelullabyy

LGTM. We have next PR based on this #91221

ChavdaSachin · 2026-05-21T13:00:39Z

Discussion about this #91004 (comment) - Here
That should not block the current PR merge.
cc. @yuwenmemon

github-actions · 2026-05-21T20:42:03Z

🚧 @yuwenmemon has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-05-21T20:48:18Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #91004.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-f51933b-841fa4b-81c6f55b066a81725af6c347966d5afbef5ed4d2/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-f51933b-841fa4b-137dd7e4cf86c9a583a42c2ef3f983db46adc354/index.html

Web 🕸️
https://91004.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-21T20:49:28Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-05-21T21:52:13Z

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.3.79-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

mitarachim · 2026-05-22T01:18:25Z

Deploy Blocker #91376 was identified to be related to this PR.

ChavdaSachin added 5 commits May 18, 2026 18:08

Add Certinia upgrade mapping and English prerequisites copy

1896097

Add Certinia prerequisites wizard and existing connections pages

f909ea0

Add ConnectToCertiniaFlow entry component

c144d3a

Register Certinia connection modals in navigator

4568e32

Wire Certinia into workspace accounting and upgrade UI

49d8765

melvin-bot Bot assigned ChavdaSachin May 18, 2026

ChavdaSachin added 4 commits May 19, 2026 00:37

Adjust code to pass react compiler test

02c5012

Fix spellings

7aedad7

lint

0274d09

Lint

7a55ed5

ChavdaSachin marked this pull request as ready for review May 18, 2026 19:46

ChavdaSachin requested review from a team as code owners May 18, 2026 19:46

melvin-bot Bot requested review from thelullabyy and trjExpensify and removed request for a team and thelullabyy May 18, 2026 19:46

chatgpt-codex-connector Bot reviewed May 18, 2026

View reviewed changes

trjExpensify previously approved these changes May 19, 2026

View reviewed changes

Add translations

41b8d19

ChavdaSachin dismissed trjExpensify’s stale review via 41b8d19 May 19, 2026 09:50

Lint

f35afbf

lint

b97418b

thelullabyy reviewed May 19, 2026

View reviewed changes

Comment thread src/components/ConnectToCertiniaFlow/index.tsx Outdated

thelullabyy reviewed May 19, 2026

View reviewed changes

Comment thread src/components/ConnectToCertiniaFlow/index.tsx Outdated

thelullabyy reviewed May 19, 2026

View reviewed changes

Comment thread src/languages/en.ts Outdated

trjExpensify requested a review from thelullabyy May 19, 2026 17:17

ChavdaSachin added 2 commits May 20, 2026 19:10

Make use of useAccountingState hook

15f2edb

Extract CERTINIA_FFA_BUNDLE_VERSION as a constant

eb7f3da

Lint

8805eed

Merge remote-tracking branch 'upstream/main' into certinia/r1-pr2-cer…

bb74c03

…tinia-pages

thelullabyy approved these changes May 21, 2026

View reviewed changes

melvin-bot Bot requested a review from yuwenmemon May 21, 2026 03:22

yuwenmemon approved these changes May 21, 2026

View reviewed changes

yuwenmemon merged commit f51933b into Expensify:main May 21, 2026
40 of 41 checks passed

OSBotify mentioned this pull request May 21, 2026

Deploy Checklist: New Expensify 2026-05-21 #91350

Open

applause-bot Bot mentioned this pull request May 22, 2026

Accounting - Inbox opens after refreshing Certinia setup RHP #91376

Open

7 tasks

mitarachim mentioned this pull request May 22, 2026

[Certinia] R1 FFA: Connection flow (ConnectToCertiniaFlow, prerequisites wizard, existing connections) #89433

Open

Conversation

ChavdaSachin commented May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented May 18, 2026

Uh oh!

ChavdaSachin commented May 18, 2026

Uh oh!

melvin-bot Bot commented May 18, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 18, 2026

Choose a reason for hiding this comment

Uh oh!

ChavdaSachin May 18, 2026

Choose a reason for hiding this comment

Uh oh!

OSBotify commented May 18, 2026

🦜 Polyglot Parrot! 🦜

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented May 19, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

thelullabyy commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

thelullabyy commented May 19, 2026

Uh oh!

ChavdaSachin commented May 19, 2026

Uh oh!

thelullabyy commented May 19, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

trjExpensify commented May 19, 2026

Uh oh!

thelullabyy commented May 20, 2026

Uh oh!

ChavdaSachin commented May 20, 2026

Uh oh!

shawnborton commented May 20, 2026

Uh oh!

ChavdaSachin commented May 20, 2026

Uh oh!

thelullabyy left a comment

Choose a reason for hiding this comment

Uh oh!

ChavdaSachin commented May 21, 2026

Uh oh!

Uh oh!

github-actions Bot commented May 21, 2026

Uh oh!

github-actions Bot commented May 21, 2026

Uh oh!

OSBotify commented May 21, 2026

Uh oh!

OSBotify commented May 21, 2026

Uh oh!

mitarachim commented May 22, 2026

Uh oh!

Reviewers

Assignees

Labels

ChavdaSachin commented May 18, 2026 •

edited

Loading

codecov Bot commented May 19, 2026 •

edited by github-actions Bot

Loading

thelullabyy commented May 19, 2026 •

edited

Loading