Skip to content

fix: Card details page title and toggle button spacing#91115

Open
samranahm wants to merge 2 commits into
Expensify:mainfrom
samranahm:88234/personal-card-details-page-style
Open

fix: Card details page title and toggle button spacing#91115
samranahm wants to merge 2 commits into
Expensify:mainfrom
samranahm:88234/personal-card-details-page-style

Conversation

@samranahm
Copy link
Copy Markdown
Contributor

@samranahm samranahm commented May 19, 2026

Explanation of Change

Fixed Issues

$ #88234
PROPOSAL: #88234 (comment)

Tests

  1. Open Account tab and navigate to Wallet
  2. Press "Add personnel card" and press next
  3. Select United States on "Where’s your bank located?"
  4. Select "Mock bank" and press Next
  5. Under "Assigned cards" select the mock card to open "Card details"
  6. Verify "Mark transactions as reimbursable" title and toggle button has proper spacing
  7. Select another local i.e "Français" and verify text wrap to next line if it exceed the limit on first row
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as test
// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android.native.mp4
Android: mWeb Chrome
Android.mWeb.Chrome.mp4
iOS: Native
IOS.Native.mp4
iOS: mWeb Safari IOS mWeb Safari
MacOS: Chrome / Safari
macOS.Chrome.mp4

View in Codesmith
Need help on this PR? Tag @codesmith with what you need.

  • Let Codesmith autofix CI failures and bot reviews

Copilot AI review requested due to automatic review settings May 19, 2026 19:49
@samranahm samranahm requested review from a team as code owners May 19, 2026 19:49
@melvin-bot melvin-bot Bot requested review from JmillsExpensify and truph01 May 19, 2026 19:49
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented May 19, 2026

@truph01 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the layout of ToggleSettingOptionRow (used across multiple settings screens, including the personal card details header menu) to improve spacing between the title/subtitle content and the trailing switch—especially in longer translations where wrapping occurs.

Changes:

  • Increased top spacing for subtitles rendered below the switch (mt1mt3).
  • Added right margin to the default title container to create a consistent gap from the switch (mr3).
  • Removed a conditional fixed-height constraint on the main row container when subtitles are placed below the switch.
Comments suppressed due to low confidence (2)

src/pages/workspace/workflows/ToggleSettingsOptionRow.tsx:199

  • The new right margin (styles.mr3) is only applied in the default title rendering path. When customTitle is provided, there’s no equivalent spacing, so custom titles can still end up too close to the switch. Consider moving the margin/spacing to a shared container so it applies to both title and customTitle.
            {customTitle ?? (
                <View style={[styles.flexColumn, styles.flex1, styles.mr3]}>
                    <Text

src/pages/workspace/workflows/ToggleSettingsOptionRow.tsx:239

  • Removing the conditional styles.h10 means the row can shrink to the intrinsic height of its contents (e.g. ~28px for the switch), reducing the tappable area for the row when shouldPlaceSubtitleBelowSwitch is true. If the fixed height was causing wrapping/clipping issues, consider using a minHeight (e.g. styles.mnh40) instead of removing the height constraint entirely.
                <View style={[styles.flexRow, styles.alignItemsCenter, styles.justifyContentBetween]}>

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/pages/workspace/workflows/ToggleSettingsOptionRow.tsx
@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
...es/workspace/workflows/ToggleSettingsOptionRow.tsx 90.38% <66.66%> (ø)
... and 140 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants