Skip to content

[No QA] Remove transactionItem as explicit prop from TransactionListItemNarrow and Wide #91164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mountiny merged 1 commit into from
May 20, 2026
+6 −5
Merged

[No QA] Remove transactionItem as explicit prop from TransactionListItemNarrow and Wide #91164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/components/Search/SearchList/ListItem/TransactionListItem/TransactionListItemNarrow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import type {View} from 'react-native';
import {getButtonRole} from '@components/Button/utils';
import OfflineWithFeedback from '@components/OfflineWithFeedback';
import PressableWithFeedback from '@components/Pressable/PressableWithFeedback';
import type {TransactionListItemType} from '@components/Search/SearchList/ListItem/types';
import UserInfoAndActionButtonRow from '@components/Search/SearchList/ListItem/UserInfoAndActionButtonRow';
import type {ListItem} from '@components/SelectionList/types';
import TransactionItemRow from '@components/TransactionItemRow';
Expand All @@ -16,7 +17,6 @@ import type {TransactionListItemNarrowProps} from './types';

function TransactionListItemNarrow<TItem extends ListItem>({
item,
transactionItem,
isDeletedTransaction,
isFocused,
showTooltip,
Expand Down Expand Up @@ -61,6 +61,8 @@ function TransactionListItemNarrow<TItem extends ListItem>({
const pressableRef = useRef<View>(null);
useSyncFocus(pressableRef, !!isFocused, shouldSyncFocus);

const transactionItem = item as unknown as TransactionListItemType;

const pressableStyle = [
Comment thread
TMisiukiewicz marked this conversation as resolved.
styles.transactionListItemStyle,
styles.p4,
Expand Down
4 changes: 3 additions & 1 deletion src/components/Search/SearchList/ListItem/TransactionListItem/TransactionListItemWide.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import type {View} from 'react-native';
import {getButtonRole} from '@components/Button/utils';
import OfflineWithFeedback from '@components/OfflineWithFeedback';
import PressableWithFeedback from '@components/Pressable/PressableWithFeedback';
import type {TransactionListItemType} from '@components/Search/SearchList/ListItem/types';
import type {ListItem} from '@components/SelectionList/types';
import TransactionItemRow from '@components/TransactionItemRow';
import useAnimatedHighlightStyle from '@hooks/useAnimatedHighlightStyle';
Expand All @@ -15,7 +16,6 @@ import type {TransactionListItemWideProps} from './types';

function TransactionListItemWide<TItem extends ListItem>({
item,
transactionItem,
isDeletedTransaction,
isFocused,
showTooltip,
Expand Down Expand Up @@ -59,6 +59,8 @@ function TransactionListItemWide<TItem extends ListItem>({
const pressableRef = useRef<View>(null);
useSyncFocus(pressableRef, !!isFocused, shouldSyncFocus);

const transactionItem = item as unknown as TransactionListItemType;

const amountColumnSize = transactionItem.isAmountColumnWide ? CONST.SEARCH.TABLE_COLUMN_SIZES.WIDE : CONST.SEARCH.TABLE_COLUMN_SIZES.NORMAL;
const taxAmountColumnSize = transactionItem.isTaxAmountColumnWide ? CONST.SEARCH.TABLE_COLUMN_SIZES.WIDE : CONST.SEARCH.TABLE_COLUMN_SIZES.NORMAL;
Comment thread
TMisiukiewicz marked this conversation as resolved.
const dateColumnSize = transactionItem.shouldShowYear ? CONST.SEARCH.TABLE_COLUMN_SIZES.WIDE : CONST.SEARCH.TABLE_COLUMN_SIZES.NORMAL;
Expand Down
1 change: 0 additions & 1 deletion src/components/Search/SearchList/ListItem/TransactionListItem/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,6 @@ function TransactionListItem<TItem extends ListItem>({

const sharedProps = {
item,
Comment thread
TMisiukiewicz marked this conversation as resolved.
transactionItem,
isDeletedTransaction,
isFocused,
showTooltip,
Expand Down
2 changes: 0 additions & 2 deletions src/components/Search/SearchList/ListItem/TransactionListItem/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import type {MouseEvent} from 'react';
import type {TransactionListItemType} from '@components/Search/SearchList/ListItem/types';
import type {SearchColumnType} from '@components/Search/types';
import type {ListItemFocusEventHandler} from '@components/SelectionList/ListItem/types';
import type {ListItem} from '@components/SelectionList/types';
Expand Down Expand Up @@ -27,7 +26,6 @@ type TransactionListItemInlineEditProps = {

type TransactionListItemWideProps<TItem extends ListItem> = {
item: TItem;
transactionItem: TransactionListItemType;
isDeletedTransaction: boolean;
isFocused?: boolean;
showTooltip: boolean;
Comment thread
TMisiukiewicz marked this conversation as resolved.
Expand Down
Loading