perf: decouple toggleTransaction from filteredData by TMisiukiewicz · Pull Request #91188 · Expensify/App

TMisiukiewicz · 2026-05-20T13:35:58Z

Explanation of Change

toggleTransaction in Search/index.tsx previously had filteredData in its dependency array because it called setSelectedTransactions(transactionIDs, filteredData) — the second arg was used to derive selectedReports
for bulk-action consumers (CSV export, bulk pay, bulk duplicate, etc.).

filteredData is a large, reference-unstable array that changes on every search refresh, snapshot bump, filter tweak, or pagination. Any time it changed, toggleTransaction was re-created, which churned every memoized child component that depended on it (row items, footer button, etc.).

Fixed Issues

$ #91288
PROPOSAL:

Tests

Open search
Go to "needs approval"
Manually select a couple of reports
Verify the button "X selected" appeared
Press the button
Select "Approve"
Verify the selected reports got approved

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-05-21.at.09.40.16.mov

…cSelectedReports

TMisiukiewicz · 2026-05-20T13:40:06Z

@codex review

mountiny · 2026-05-20T13:44:45Z

@MelvinBot review this PR

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ea436ac22d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

codecov · 2026-05-20T13:47:32Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/components/Search/index.tsx	`0.62% <0.00%> (-0.01%)`	⬇️
src/components/Search/SearchContext.tsx	`55.71% <48.71%> (+6.53%)`	⬆️
... and 9 files with indirect coverage changes

MelvinBot · 2026-05-20T13:47:38Z

PR Review

The goal — removing filteredData from toggleTransaction's dependency array to reduce re-renders — is sound. However, the implementation has a correctness issue that needs fixing before merge.

1. Unstable `setSelectedReports` reference causes the sync effect to fire every render

setSelectedReports is defined as an inline closure inside SearchContextProvider without useCallback, so it's a new reference on every provider render. It's then used as a dependency of the useEffect in useSyncSelectedReports:

useEffect(() => {
    setSelectedReports(deriveSelectedReports(selectedTransactions, data));
}, [selectedTransactions, data, setSelectedReports]);

Because setSelectedReports is unstable, this effect runs on every render. Worse, deriveSelectedReports always returns a new array (via .map()), so setSearchContextData sees a new reference → triggers a re-render → creates a new setSelectedReports → effect fires again. This is an infinite render loop.

Fix: Wrap setSelectedReports in useCallback:

const setSelectedReports = useCallback<SearchActionsContextValue['setSelectedReports']>((reports) => {
    setSearchContextData((prevState) => ({
        ...prevState,
        selectedReports: reports,
    }));
}, []);

(Note: the same instability exists for other action functions like setSelectedTransactions, but those are only called imperatively from event handlers — not inside useEffect deps — so they don't cause loops today.)

2. `selectedReports` now lags `selectedTransactions` by one render cycle

Previously, selectedReports was set synchronously alongside selectedTransactions in a single setSearchContextData call. Now it's derived in a useEffect, which runs after the render that updated selectedTransactions. This means there's a frame where a consumer could read updated selectedTransactions but stale selectedReports (e.g., a bulk action like CSV export triggered right after selection).

This may be acceptable if no consumer relies on both being in sync within the same render, but it's worth validating — especially for the export-to-CSV path that the old comment mentioned:

"When selecting transactions, we also need to manage the reports to which these transactions belong. This is done to ensure proper exporting to CSV."

3. Minor: trailing whitespace

Line 400 has trailing spaces on the blank line. Will likely fail prettier/lint.

Summary: The approach is good, but issue #1 (infinite loop from unstable callback ref) is a blocker. Wrapping setSelectedReports in useCallback should fix it. Issue #2 (async lag) is worth a quick audit of the CSV export path to confirm it's safe.

Copilot

Pull request overview

This PR refactors Search selection handling so toggleTransaction no longer depends on filteredData, moving report-derivation logic into a dedicated sync hook in SearchContext.

Changes:

Updated SearchActionsContextValue.setSelectedTransactions to remove the filteredData parameter and added a new setSelectedReports action.
Added deriveSelectedReports() + useSyncSelectedReports() to keep selectedReports synchronized based on current selection and visible rows.
Updated Search UI header tests’ mocked Search actions context to include setSelectedReports.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
tests/ui/CategoryListItemHeaderTest.tsx	Adds `setSelectedReports` to mocked Search actions context.
tests/ui/MerchantListItemHeaderTest.tsx	Adds `setSelectedReports` to mocked Search actions context.
tests/ui/MonthListItemHeaderTest.tsx	Adds `setSelectedReports` to mocked Search actions context.
tests/ui/WeekListItemHeaderTest.tsx	Adds `setSelectedReports` to mocked Search actions context.
tests/ui/YearListItemHeaderTest.tsx	Adds `setSelectedReports` to mocked Search actions context.
src/components/Search/types.ts	Adjusts `setSelectedTransactions` overloads and adds `setSelectedReports` to the actions contract.
src/components/Search/SearchContext.tsx	Introduces `deriveSelectedReports` + `useSyncSelectedReports`, and wires `setSelectedReports` into context.
src/components/Search/index.tsx	Uses `useSyncSelectedReports(filteredData)` and removes `filteredData` from `toggleTransaction` calls/deps.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…ransaction-from-filteredData

melvin-bot · 2026-05-21T07:46:08Z

@dmkt9 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: af9200ef44

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

dmkt9 · 2026-05-21T11:31:19Z

Separating selectedReports from the selectedTransactions update creates an inconsistent intermediate render when report data changes. The refresh selection Effect in Search intentionally expands the selection of the expense report to include transactions, but useSyncSelectedReports() in the same commit still derives from the old selectedTransactions, so it temporarily considers it as “not all transactions selected” and removes it from selectedReports.

For example, the Change Approver modal is closed when adding 1 transaction to that report on another tab or device:

2026-05-21.18-26-53.mp4

dmkt9 · 2026-05-21T11:35:57Z

@TMisiukiewicz we have conflicts

…dData

…s on refresh

TMisiukiewicz · 2026-05-21T12:39:27Z

@dmkt9 could you please check again

Screen.Recording.2026-05-21.at.14.37.05.mov

dmkt9 · 2026-05-21T14:44:03Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

chrome.test.mp4

dmkt9

LGTM

joekaufmanexpensify · 2026-05-21T21:53:41Z

No product review needed

…ransaction-from-filteredData # Conflicts: # config/eslint/eslint.seatbelt.tsv # src/components/Search/index.tsx # src/libs/actions/connections/MergeHR.ts

…ransaction-from-filteredData # Conflicts: # config/eslint/eslint.seatbelt.tsv # src/components/Search/index.tsx

mountiny

Thank you!

github-actions · 2026-05-22T09:17:37Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-05-22T09:21:59Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #91188.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-95c82e2-d1139c3-f2062af7eed3f05362d1e13c74b25042887e33d9/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-95c82e2-d1139c3-6c49afbd1e8a9ed1fb01f1863829e2e328f4c726/index.html

Web 🕸️
https://91188.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-22T09:25:00Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-05-22T22:45:13Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.80-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-05-22T22:46:25Z

I reviewed the changes in this PR and no help site documentation updates are required.

This PR is a purely internal performance optimization that decouples toggleTransaction from filteredData in the Search context to avoid unnecessary re-renders. There are no user-facing changes — no new features, UI changes, renamed elements, or workflow modifications. Search behavior is identical from the user's perspective.

OSBotify · 2026-05-25T22:37:37Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.81-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

perf(Search): decouple toggleTransaction from filteredData via useSyn…

ea436ac

…cSelectedReports

melvin-bot Bot assigned TMisiukiewicz May 20, 2026

mountiny requested a review from Copilot May 20, 2026 13:45

chatgpt-codex-connector Bot reviewed May 20, 2026

View reviewed changes

Comment thread src/components/Search/SearchContext.tsx Outdated

Copilot started reviewing on behalf of mountiny May 20, 2026 13:45 View session

Copilot AI reviewed May 20, 2026

View reviewed changes

Comment thread src/components/Search/SearchContext.tsx Outdated

Comment thread src/components/Search/SearchContext.tsx Outdated

TMisiukiewicz added 3 commits May 21, 2026 08:19

Merge remote-tracking branch 'origin/main' into perf/decouple-toggleT…

25561e4

…ransaction-from-filteredData

perf(Search): skip setSelectedReports write when selection stays empty

c54fa4e

fix: remove unused type imports from SearchContext types

af9200e

TMisiukiewicz changed the title ~~decouple toggleTransaction from filteredData~~ perf: decouple toggleTransaction from filteredData May 21, 2026

TMisiukiewicz marked this pull request as ready for review May 21, 2026 07:46

TMisiukiewicz requested review from a team as code owners May 21, 2026 07:46

melvin-bot Bot requested review from dmkt9 and joekaufmanexpensify and removed request for a team May 21, 2026 07:46

melvin-bot Bot removed the request for review from a team May 21, 2026 07:46

chatgpt-codex-connector Bot reviewed May 21, 2026

View reviewed changes

Comment thread src/components/Search/SearchContext.tsx

mountiny mentioned this pull request May 21, 2026

[Due for payment 2026-06-01] perf: decouple toggleTransaction from filteredData #91288

Open

Merge branch 'main' into perf/decouple-toggleTransaction-from-filtere…

83a7f3a

…dData

TMisiukiewicz force-pushed the perf/decouple-toggleTransaction-from-filteredData branch from a4d650c to 83a7f3a Compare May 21, 2026 11:49

fix(Search): atomically sync selectedReports with selectedTransaction…

dd270d1

…s on refresh

dmkt9 approved these changes May 21, 2026

View reviewed changes

melvin-bot Bot requested a review from mountiny May 21, 2026 14:44

mountiny requested changes May 21, 2026

View reviewed changes

Comment thread src/components/Search/SearchContext.tsx

joekaufmanexpensify removed their request for review May 21, 2026 21:53

TMisiukiewicz added 3 commits May 22, 2026 08:37

Merge remote-tracking branch 'origin/main' into perf/decouple-toggleT…

1d95975

…ransaction-from-filteredData # Conflicts: # config/eslint/eslint.seatbelt.tsv # src/components/Search/index.tsx # src/libs/actions/connections/MergeHR.ts

test: add unit tests for useSyncSelectedReports

c1990c1

test: make harness React Compiler compliant

9dd48aa

TMisiukiewicz requested a review from mountiny May 22, 2026 06:58

TMisiukiewicz added a commit to callstack-internal/Expensify-App that referenced this pull request May 22, 2026

propagate PR Expensify#91188 changes to split search context

4c14dd4

TMisiukiewicz added 2 commits May 22, 2026 09:28

remove unused useCallback dependency

2f66c86

Merge remote-tracking branch 'origin/main' into perf/decouple-toggleT…

185516e

…ransaction-from-filteredData # Conflicts: # config/eslint/eslint.seatbelt.tsv # src/components/Search/index.tsx

mountiny approved these changes May 22, 2026

View reviewed changes

mountiny merged commit 95c82e2 into Expensify:main May 22, 2026
36 checks passed

OSBotify mentioned this pull request May 22, 2026

Deploy Checklist: New Expensify 2026-05-22 #91472

Closed

71 tasks

Conversation

TMisiukiewicz commented May 20, 2026 • edited by mountiny Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

TMisiukiewicz commented May 20, 2026

Uh oh!

mountiny commented May 20, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

codecov Bot commented May 20, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

MelvinBot commented May 20, 2026

PR Review

1. Unstable setSelectedReports reference causes the sync effect to fire every render

2. selectedReports now lags selectedTransactions by one render cycle

3. Minor: trailing whitespace

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

melvin-bot Bot commented May 21, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

dmkt9 commented May 21, 2026

Uh oh!

dmkt9 commented May 21, 2026

Uh oh!

TMisiukiewicz commented May 21, 2026

Uh oh!

dmkt9 commented May 21, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

dmkt9 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

joekaufmanexpensify commented May 21, 2026

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented May 22, 2026

Uh oh!

github-actions Bot commented May 22, 2026

Uh oh!

OSBotify commented May 22, 2026

Uh oh!

OSBotify commented May 22, 2026

Uh oh!

MelvinBot commented May 22, 2026

Uh oh!

OSBotify commented May 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

TMisiukiewicz commented May 20, 2026 •

edited by mountiny

Loading

codecov Bot commented May 20, 2026 •

edited by github-actions Bot

Loading

1. Unstable `setSelectedReports` reference causes the sync effect to fire every render

2. `selectedReports` now lags `selectedTransactions` by one render cycle