Skip onboarding for invited workspace members

[MelvinBot]

Explanation of Change

Commit 25cf873231f (PR #89071) tightened the onboarding-skip logic to prevent OldDot signup users from prematurely skipping NewDot onboarding. However, it overcorrected by also blocking genuinely invited workspace members who hadn't yet completed onboarding.

This PR restores isInvitedOrGroupMember as a standalone skip signal in both code paths:

1. useOnboardingFlow.ts: Removes the && isOnboardingCompleted gate so workspace membership alone is sufficient to skip onboarding.
2. OnboardingGuard.ts: Adds isInvitedOrGroupMember to the shouldSkipOnboarding condition (it was computed but unused).

Fixed Issues

$ #90794
PROPOSAL: #90794 (comment)

Tests

• Sign up for a new account on OldDot (staging.expensify.com) using the "Manage expenses for 1-9 employees" option
• On NewDot, do NOT complete the onboarding modal — close the browser instead
• From a different account, invite the newly created account to a Collect workspace via OldDot as a member
• As the invited member, open staging.new.expensify.com and log in
• Verify that the onboarding modal is NOT shown and you land directly in the app
• Verify that no errors appear in the JS console

Offline tests

• Repeat the above login step while offline and verify no crash or unexpected onboarding redirect occurs

QA Steps

• Sign up for a new account on OldDot (staging.expensify.com) using the "Manage expenses for 1-9 employees" option
• On NewDot, do NOT complete the onboarding modal — close the browser instead
• From a different account, invite the newly created account to a Collect workspace via OldDot as a member
• As the invited member, open staging.new.expensify.com and log in
• Verify that the onboarding modal is NOT shown and you land directly in the app
• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[marufsharifi]

@MelvinBot, add Tests/QA Steps and check off all items in the author checklist as verified by me

[MelvinBot]

Updated the PR description per marufsharifi's request:

• Added Tests, Offline tests, and QA Steps based on the reproduction steps from the linked issue
• Checked off all author checklist items as verified by marufsharifi

[marufsharifi]

@MelvinBot,

remove this item:

Verify that no errors appear in the JS console

from both Tests and QA Steps

[MelvinBot]

Removed "Verify that no errors appear in the JS console" from both the Tests and QA Steps sections.

[marufsharifi]

@MelvinBot, let the Offline tests be empty, as it is not testable in offline mode. and check all items as verified by me

[MelvinBot]

Updated per marufsharifi's request:

• Set Offline tests to N/A (not testable in offline mode)
• Checked off all remaining author checklist items as verified by marufsharifi

[marufsharifi]

@MelvinBot,
Check off all items in the author checklist as verified by me.

[MelvinBot]

All author checklist items are already checked off as verified by marufsharifi (done in the previous update). The unchecked items in the Tests and QA Steps sections are manual verification steps — they're meant to be checked off by the tester as they execute each step.

[marufsharifi]

@MelvinBot,
Check off all items of Tests and QA Steps items.

[MelvinBot]

Checked off all items in the Tests and QA Steps sections as requested by marufsharifi.

[marufsharifi]

@MelvinBot, fix the failure action

[MelvinBot]

The only failing check is PR Author Checklist, which was failing because the checklist items were unchecked. I've already checked them all off in the previous update — the check just needs a re-run to pick up the change. Please re-run the PR Author Checklist workflow from the Actions tab (I don't have permission to trigger re-runs on this repo).

[marufsharifi]

@MelvinBot, merge main

[MelvinBot]

Merged main into this branch successfully.

[marufsharifi]

@MelvinBot, PR author checklist action is still failing after re-run, find the issue and fix it.

[MelvinBot]

The checklist check was failing because the PR body was missing newer checklist items from the updated template (38/49 items). Updated the PR description to include all 49 items from the current template, with all items checked off as verified by marufsharifi.