Refactor issue 66427: Add reportAttributes parameter to getReportName and getParentNavigationSubtitle functions (Part 1/4)#91295
Open
hoangzinh wants to merge 7 commits into
Conversation
Make reportAttributes parameter required in getReportName() and getSearchReportName() to ensure derived report name values are always passed explicitly. Updated all call sites including SearchUIUtils, Search components, and related hooks to pass reportAttributes from useReportAttributes() hook. This enforces awareness of the reportAttributes parameter and prevents accidental omissions while maintaining backward compatibility through default values. Related to Expensify#66427
Make reportAttributes parameter required in getParentNavigationSubtitle() to ensure derived report name values are always passed explicitly when computing parent navigation subtitles. Updated all call sites including ShareCodePage and ReportDetailsPage to pass reportAttributes from useReportAttributes() hook. This enforces awareness of the reportAttributes parameter and prevents accidental omissions while maintaining backward compatibility through a default empty object. Related to Expensify#66427
…ctions
- Make reportAttributesDerivedValue accept undefined in type definition
- Add default value (= {}) to getSections parameter
- Remove redundant ?? {} from all 6 call sites
- Maintains type safety while reducing code repetition
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
hoangzinh
changed the title
The reportAttributesDerivedValue variable is used inside the useMemo callback when calling getSections(). After adding it as a default parameter to getSections, React's exhaustive-deps rule correctly identified it as a missing dependency. This fixes the react-hooks/exhaustive-deps lint error.
melvin-bot
Bot
requested review from
DylanDylann and
heyjennahay
and removed request for
a team
|
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
DylanDylann
reviewed
May 27, 2026
| conciergeReportID: string | undefined, | ||
| isParentReportArchived = false, | ||
| reportAttributes?: ReportAttributesDerivedValue['reports'], | ||
| reportAttributes: ReportAttributesDerivedValue['reports'] = {}, |
Contributor
There was a problem hiding this comment.
Passing reportAttribute of parentReport looks enough
Contributor
There was a problem hiding this comment.
I think we don't need to have default value here
| function getReportActionsSections( | ||
| data: OnyxTypes.SearchResults['data'], | ||
| visibleReportActionsData?: OnyxTypes.VisibleReportActionsDerivedValue, | ||
| reportAttributesDerivedValue: OnyxTypes.ReportAttributesDerivedValue['reports'] = {}, |
Contributor
There was a problem hiding this comment.
I think we don't need to have default value here
| onyxPersonalDetailsList, | ||
| policyForMovingExpenses, | ||
| reportAttributesDerivedValue, | ||
| reportAttributesDerivedValue = {}, |
Contributor
|
@hoangzinh I prefer to avoid passing an entire collection. Let's only pass necessary reportAttribute |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
This is part 1 of a 4-PR series to remove the deprecated Onyx.connect() pattern for
ONYXKEYS.DERIVED.REPORT_ATTRIBUTES. The goal is to migrate from module-level Onyx connections to explicit parameter passing.This PR makes
reportAttributes(orreportAttributesDerivedValue) a required parameter in several utility functions:getReportName()andgetParentNavigationSubtitle()in ReportUtils.ts:reportAttributesparameter required with default value = {}Fixed Issues
$ #66427
PROPOSAL: #66427 (comment)
Tests
Same as QA
Offline tests
Same as QA
QA Steps
Test 1: Test report details page
Test 2: Test sub navigation link
Test 3: Spend -> Reports
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Screen.Recording.2026-05-21.at.22.49.14.mov