Bump expensify-common to 2.0.181 for VictoryChart support#91329
Conversation
Co-authored-by: Situ Chandra Shil <situchan@users.noreply.github.com>
📲 Install BuildsAndroid
|
|
@MelvinBot add Test steps based on #90548 (comment) |
|
Added test steps to the PR based on the linked comment. Since this is a dependency version bump ( |
|
@MelvinBot check off all items in author checklist as verified by me and mark as ready for review |
|
All items in the PR Author Checklist have been checked off as verified by |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid.movAndroid: mWeb ChromeiOS: HybridAppios.moviOS: mWeb SafariMacOS: Chrome / Safariweb.mov |
|
🚧 @luacmartins has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.3.79-1 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Bumps
expensify-commonfrom 2.0.175 to 2.0.181 to pull in the ExpensiMark preserved-tag support for<VictoryChart>tags (expensify-common PR #915). This is required for the Virtual CFO Report charts feature.Fixed Issues
$ #90548
Tests
expensify-commonor ExpensiMarkOffline tests
N/A — dependency version bump only.
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari