Skip to content

[No QA] Docs updates for E/A#91176 Add file import cross-references for company cards#91365

Open
MelvinBot wants to merge 2 commits into
mainfrom
claude-docsUpdateCSVCardImportGA
Open

[No QA] Docs updates for E/A#91176 Add file import cross-references for company cards#91365
MelvinBot wants to merge 2 commits into
mainfrom
claude-docsUpdateCSVCardImportGA

Conversation

@MelvinBot
Copy link
Copy Markdown
Contributor

Summary

  • Adds cross-references to the Import Company Card Transactions From a Spreadsheet article from the Direct Feed, Commercial Feed, and Assign Company Cards articles, now that the CSV card import feature is generally available (beta removed in Remove CSV Card Import beta #91176).
  • Fixes "XLX" → "XLS" typos in the existing file import article.

Changed articles

  • Import-Company-Card-Transactions-From-a-Spreadsheet.md — fixed file extension typos (XLX → XLS)
  • Assign-Company-Cards.md — added link to file import article in prerequisites
  • Set-up-a-Commercial-Card-Feed-Connection.md — added file import as alternative in intro and FAQ
  • Set-up-a-Direct-Company-Card-Feed-Connection.md — added file import as alternative in intro

Now that CSV card import is no longer behind a beta flag,
update company card help articles to cross-reference the
file import option and fix XLX -> XLS typos.

Co-authored-by: Alberto Gonzalez-Cela <Gonals@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label May 21, 2026
@MelvinBot MelvinBot mentioned this pull request May 21, 2026
53 tasks
@github-actions github-actions Bot changed the title Docs updates for E/A#91176 Add file import cross-references for company cards [No QA] Docs updates for E/A#91176 Add file import cross-references for company cards May 21, 2026
@OSBotify

This comment has been minimized.

@stephanieelliott stephanieelliott self-assigned this May 22, 2026
@stephanieelliott stephanieelliott marked this pull request as ready for review May 27, 2026 04:59
@stephanieelliott stephanieelliott self-requested a review as a code owner May 27, 2026 04:59
@github-actions
Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR makes two categories of changes across four company-card articles: (1) fixing a repeated "XLX" typo to the correct "XLS" file extension, and (2) adding cross-links to the spreadsheet import article from three related articles. Both categories are well-scoped improvements that correct factual inaccuracy and improve discoverability.

Scores Summary

  • Readability: 9/10 - The typo fixes improve correctness, and the added Oxford comma improves clarity. The double-space fix in the Commercial Card Feed FAQ is a nice cleanup. All changes are clean and well-integrated into existing prose.
  • AI Readiness: 9/10 - Cross-links use descriptive anchor text that reflects real search phrasing (e.g., "import company card transactions from a spreadsheet"). The YAML metadata in the spreadsheet article already contains "XLS" in its keywords, so the body text now matches. No heading or metadata changes were needed for this diff.
  • Style Compliance: 9/10 - Anchor text follows the "Learn how to [task]" or descriptive-task pattern required by the cross-linking standards. All links use relative paths. Link placement is appropriate -- links appear in explanatory paragraphs and conditional dependency statements, not inside numbered step instructions.

Key Findings

  • Typo fix is important: "XLX" is not a real file format. Correcting it to "XLS" in all three occurrences prevents user confusion and ensures the article matches real-world terminology. The addition of the Oxford comma ("CSV, TXT, XLS, or XLSX") is a minor but welcome consistency improvement.
  • Cross-links are well-placed: The new links to the spreadsheet import article are added in prerequisite/alternative-workflow contexts (e.g., "If you're not eligible..." or "If you haven't set up a feed yet..."), which aligns with the governance rule that cross-links should only appear for prerequisite workflows, deep-dives, or excluded workflows.
  • Link volume is reasonable: Each article gains one or two links at most, staying within the governance guidance to limit cross-links and preserve topical clarity.
  • Minor observation: In Set-up-a-Commercial-Card-Feed-Connection.md, the original intro link text said "set up a direct company card feed connection instead" and the PR changes it to remove "instead" while appending the new spreadsheet link. The removal of "instead" is appropriate since there are now two alternatives listed.

Recommendations

  • No blocking issues. This PR is ready to merge.
  • For a future pass: the spreadsheet import article (line 10 in the current file) still has a trailing space after the H1 heading. This is pre-existing and outside this diff, so it is not scored here.

Files Reviewed

  • Assign-Company-Cards.md - Added one cross-link bullet to spreadsheet import; removed trailing whitespace. Clean.
  • Import-Company-Card-Transactions-From-a-Spreadsheet.md - Fixed "XLX" to "XLS" in three locations; added Oxford comma. Correct and necessary.
  • Set-up-a-Commercial-Card-Feed-Connection.md - Added cross-links to spreadsheet import in intro and FAQ; fixed double space. Well-placed.
  • Set-up-a-Direct-Company-Card-Feed-Connection.md - Added cross-link to spreadsheet import as a fallback option. Appropriate context.

Note: No inline comments were necessary -- all changes in this PR are well-formed and compliant with governance standards.

@MelvinBot
Copy link
Copy Markdown
Contributor Author

The failing review check is not related to this PR's changes — it's a transient GitHub API error (other side closed) that occurred when the workflow tried to fetch the list of changed files. This is a flaky infrastructure issue.

Fix: Re-run the failed review job. I don't have permission to trigger re-runs, so a maintainer will need to click "Re-run failed jobs" on the failed workflow run.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@stephanieelliott stephanieelliott requested a review from a team May 28, 2026 03:11
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented May 28, 2026

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @brianlee-expensify

@melvin-bot melvin-bot Bot requested review from brianlee-expensify and removed request for a team May 28, 2026 03:11
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented May 28, 2026

@brianlee-expensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants