fix: show contact names instead of phone numbers in imported contact lists#91395
Open
aswin-s wants to merge 6 commits into
Open
fix: show contact names instead of phone numbers in imported contact lists#91395aswin-s wants to merge 6 commits into
aswin-s wants to merge 6 commits into
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
Phone contacts from device address book were showing only their phone numbers in the IOU participants list. getParticipantsOption discarded participant.text (device contact name) for unknown accountIDs, and IOURequestStepConfirmation routed phone contacts through getReportOption which doesn't preserve the contact name. Prefer participant.text when the personal detail has no login, and route participants without a reportID through getParticipantsOption.
Replace nested ternary with an if/else chain. Removes two unjustified eslint-disable comments and adds inline justification on the remaining one (empty string from device contacts must fall through to the formatted phone number).
|
@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
In
src/libs/PersonalDetailOptionsListUtils/index.ts,createOptioncallsgetDisplayNameForParticipantwhich resolves the display name by looking upaccountIDin the global OnyxallPersonalDetailsstore. For device-imported contacts, theaccountIDis optimistically generated and does not exist in Onyx, so the lookup fails and falls back to displaying the raw phone number — even thoughdisplayName/firstName/lastNameare already present on thepersonalDetailobject passed in.Fix: pass
{[personalDetail.accountID]: personalDetail}aspersonalDetailsDatatogetDisplayNameForParticipant. This lets the existing resolver find the contact's name from the local object rather than failing the Onyx lookup. For real Onyx-backed personal details, the injected object is identical to the Onyx entry — no behavior change for existing callers.Fixed Issues
$ #91150
PROPOSAL: #91150 (comment)
Tests
Offline tests
Not applicable — contact import is a device-local operation that does not require network access.
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.mp4
Android: mWeb Chrome
Contact import is available only on native platforms
iOS: Native
Simulator.Screen.Recording.-.iPhone.17.Pro.Max.-.2026-05-26.at.23.17.10.mp4
iOS: mWeb Safari
Contact import is available only on native platforms
MacOS: Chrome / Safari
Contact import is available only on native platforms