Skip to content

[No QA] Docs updates for E/A#87750 Add FAQ for pending card transaction submit error#91476

Open
MelvinBot wants to merge 2 commits into
mainfrom
docs-pending-card-submit-error-87750
Open

[No QA] Docs updates for E/A#87750 Add FAQ for pending card transaction submit error#91476
MelvinBot wants to merge 2 commits into
mainfrom
docs-pending-card-submit-error-87750

Conversation

@MelvinBot
Copy link
Copy Markdown
Contributor

Summary

  • Adds a new FAQ entry to Create-and-Submit-Reports.md explaining the new behavior introduced in Show submit button with error modal for pending card transactions #87750
  • When all transactions on a report are pending Expensify Card transactions, the Submit button is now visible but clicking it shows an "Unable to submit report" error modal
  • Updated keywords to improve search discoverability for this scenario

Related PR

#87750 — Show submit button with error modal for pending card transactions

Add a new FAQ entry to Create-and-Submit-Reports explaining the new
behavior where clicking Submit on a report with only pending Expensify
Card transactions shows an error modal instead of hiding the button.

Co-authored-by: Sobit Neupane <sobitneupane@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label May 22, 2026
@github-actions github-actions Bot changed the title Docs updates for E/A#87750 Add FAQ for pending card transaction submit error [No QA] Docs updates for E/A#87750 Add FAQ for pending card transaction submit error May 22, 2026
@OSBotify
Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://bf83bb2d.helpdot.pages.dev ⚡️

Updated articles:

@stephanieelliott stephanieelliott self-assigned this May 27, 2026
@stephanieelliott stephanieelliott marked this pull request as ready for review May 27, 2026 05:00
@stephanieelliott stephanieelliott self-requested a review as a code owner May 27, 2026 05:00
Comment thread docs/articles/new-expensify/reports-and-expenses/Create-and-Submit-Reports.md Outdated
@github-actions
Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR makes a small, focused addition to the Create-and-Submit-Reports article: two new keywords in the YAML frontmatter and a new FAQ entry explaining why users cannot submit reports with pending Expensify Card transactions. The change is well-scoped and addresses a real user pain point.

Scores Summary

  • Readability: 9/10 - The new FAQ entry is clear, concise, and scannable. It explains the problem, the cause, and the resolution in three well-structured sentences. No unnecessary jargon or ambiguity.
  • AI Readiness: 10/10 - The two new keywords ("pending card transactions", "unable to submit report") reflect realistic search queries users would enter when encountering this issue. The heading is task-based, starting with "Why", and includes the feature name ("Expensify Card"). All required YAML metadata fields (title, description, keywords, internalScope) remain present and correct.
  • Style Compliance: 8/10 - The Submit button is correctly bolded. The heading follows the question-word pattern required by governance. One area of concern: the phrase "Unable to submit report" appears in quotation marks. While this references an error message rather than a button (so the button-naming prohibition on quotation marks does not strictly apply), the governance files emphasize using exact UI text and bolding clickable/visible UI elements. If this is the exact error string shown in the product, consider bolding it for consistency with how other UI-visible text is treated, or at minimum confirm the exact casing and wording matches the product.

Key Findings

  • The new FAQ heading ("Why can't I submit a report with pending Expensify Card transactions?") is well-formed: it starts with a question word, includes the feature name, and describes a specific user problem.
  • The new keywords are additive and do not disrupt existing keyword coverage. They align with search intent for this specific scenario.
  • The placement of the new FAQ entry (between the existing "Submit button" FAQ and the "Can I remove an expense" FAQ) is logical and maintains good reading flow.
  • Minor: The phrase "More > Retract" in the adjacent (unchanged) FAQ uses a breadcrumb-style reference that does not follow the three dots menu convention, but this is pre-existing content and outside the scope of this PR.

Recommendations

  1. Verify that "Unable to submit report" matches the exact error message text shown in the product UI. If it does, consider formatting it consistently with other UI references (e.g., bolding or using a distinct format to signal it is product-displayed text).
  2. No other changes are needed. This is a clean, well-targeted addition.

Files Reviewed

  • docs/articles/new-expensify/reports-and-expenses/Create-and-Submit-Reports.md - Two new keywords added to frontmatter; one new FAQ section added for pending Expensify Card transaction submission errors. Clean and compliant.

Note: This is a summary review. The diff is small enough that all feedback is captured above.

Comment thread docs/articles/new-expensify/reports-and-expenses/Create-and-Submit-Reports.md Outdated
@github-actions
Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR adds a small, focused FAQ entry to the Create-and-Submit-Reports article explaining why users cannot submit a report when all transactions are pending Expensify Card transactions. It also adds two relevant keywords to the YAML frontmatter. The change is well-scoped and addresses a real user pain point.

Scores Summary

  • Readability: 9/10 - The new FAQ answer is clear, concise, and actionable. It explains the cause (pending transactions), the symptom (error message), and the resolution (wait for at least one transaction to post). Sentence flow is smooth and scannable.
  • AI Readiness: 9/10 - The heading is a well-formed question starting with "Why," includes the full feature name "Expensify Card," and the new keywords ("pending card transactions", "unable to submit report") align with realistic search queries. The heading hierarchy is correct (## within the FAQ section).
  • Style Compliance: 8/10 - The Submit button is correctly bolded. However, the error message text "Unable to submit report" is wrapped in quotation marks rather than bolded. Per the naming conventions, UI-visible text should be bolded, not quoted. If this is a system-generated error message (not a button), quotation marks may be acceptable, but bold formatting would be more consistent with the established pattern in the rest of the article.

Key Findings

  • The new FAQ entry is logically placed between the existing "Why don't I see the Submit button?" and "Can I remove an expense after submitting?" entries, creating a natural troubleshooting flow.
  • Keywords added to the YAML frontmatter are well-chosen and match real user search intent.
  • The answer is self-contained and does not require cross-links, which is appropriate here.
  • Minor style consideration: "Unable to submit report" in quotes -- if this is exact UI error text, consider bolding it to match the article's pattern for UI elements, or verify that quotation marks are the intended convention for error messages specifically.

Recommendations

  • Consider whether "Unable to submit report" should be bolded instead of quoted, to stay consistent with how other UI text is referenced in the article.
  • No structural or metadata changes needed -- the addition fits cleanly within the existing article scope.

Files Reviewed

  • docs/articles/new-expensify/reports-and-expenses/Create-and-Submit-Reports.md - Small, well-targeted addition of one FAQ entry and two keywords. No structural issues.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@stephanieelliott stephanieelliott requested a review from a team May 28, 2026 03:12
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented May 28, 2026

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @Kel-Expensify

@melvin-bot melvin-bot Bot requested a review from Kel-Expensify May 28, 2026 03:12
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented May 28, 2026

@Kel-Expensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot removed the request for review from a team May 28, 2026 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants