Surface duplicate Plaid bank account error on USD VBBA flow

[Abdulloh0109]

Explanation of Change

On Workspace → Workflows → Payments, when an admin adds a Plaid bank account, disconnects it, then re-runs Add bank account → Log into your bank and re-selects the same Plaid account, tapping Next previously did nothing visible — no error, no toast, no advance.

The page-level useEffect in ReimbursementAccountPage.tsx listed reimbursementAccount?.isLoading in its deps and unconditionally called hideBankAccountErrors() whenever the user was on the Plaid sub-step. When the backend duplicate-account error landed, isLoading flipped true → false, the effect re-ran on the same step, and the fresh error was wiped from Onyx before AddPlaidBankAccount could render it via the existing FormAlertWithSubmitButton. Result: Next looked unresponsive on re-selecting an existing Plaid account.

This change gates the clear to actual step transitions via usePrevious on currentStep and achData?.subStep. Because this codebase's usePrevious initializes its ref with the current value (rather than undefined), the first render is also tracked with isFirstRenderRef so the initial mount on the Plaid sub-step (e.g. page reload, deeplink) still clears truly stale errors from a prior session — while fresh in-flight errors from a just-completed API call survive subsequent isLoading toggles.

Per the issue's Implementation Note, only ReimbursementAccountPage.tsx is modified — the existing error display path in AddPlaidBankAccount → FormAlertWithSubmitButton is sufficient to render the error once the page-level wipe is gated.

Fixed Issues

$ #89064
PROPOSAL: #89064 (comment)

Tests

1. Sign in as an admin and open (or create) a workspace.
2. Navigate to Workspace Settings → Workflows → Payments.
3. Tap Add bank account → Log into your bank and connect a Plaid sandbox account (e.g. user_good / pass_good).
4. Complete the bank account setup so the account is connected.
5. Disconnect the bank account from the workspace.
6. Tap Add bank account → Log into your bank again and re-select the same Plaid account.
7. On the Choose an account page, choose an account and tap Next.
8. Verify the error "Bank account can't be created, it looks like a bank account with the same information already exists in your account." appears above the Next button.
9. Change the selection (or start over) and verify the error clears on the next attempt.

• Verify that no errors appear in the JS console

Offline tests

1. Repeat steps 1–6 from Tests while online so a Plaid account is connected then disconnected.
2. Disable network and tap Add bank account → Log into your bank → Next after selecting an account.
3. Verify the request queues (no spurious error displayed while offline).
4. Re-enable network and verify the queued request fires and the duplicate-account error then appears above the Next button.

QA Steps

Same as Tests above.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

iOS: App

20260520_201235.mp4

Windows: Chrome

20260520_174644.mp4

MacOS: Chrome / Safari

REC-20260525203836.mp4

Android: App

REC-202605252022836.mp4

Android: mWeb Chrome

1.mp4

iOS: mWeb Chrome

2.mp4

[melvin-bot]

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[ikevin127]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2026-05-23.at.18.01.32.mov

[ikevin127]

@Abdulloh0109 Couple of issues that need addressed on your side before I can complete the PR review:

• all PR Author Checklist checkboxes must be checked ☑️
• the Screenshots/Videos section must include proof for all platforms as we confirmed on assignment in the issue

Please tag me once these are completed so I can finalize PR review 🙌

[codecov]

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
.../ReimbursementAccount/ReimbursementAccountPage.tsx	0.00% <0.00%> (ø)
... and 415 files with indirect coverage changes

[Abdulloh0109]

@ikevin127

[ikevin127]

@Abdulloh0109 Everything looks good except you're failing the ❌ Verify signed commits workflow because your commit si not verified - you'll have to soft reset and force push with verified commit. Guide to get your commits verified is in the contributor guidelines in the Begin coding your solution in a pull request section.

Tag me once you force pushed your commit again to this PR with verified signature, then I'll review once again. Note that force push is usually not recommended due to messing with branching history - but in this case given it's only 1 commit and it's due to not having it verified, we can let it slide.

There's also 1 [x] Verify that no errors appear in the JS console checkbox you missed on your PR Author Checklist.

[Abdulloh0109]

@ikevin127

[ikevin127]

@Abdulloh0109 Thanks for verifying your commit. There are two more things that need resolve before I can approve:

1. I noticed you accidentally commited your claude code proposal command, and we're not allowed to commit such files to the Expensify repo. Please remove the addition, you should only commit the issue fix changes and merge with main commits.
2. Looks like the PR branch has some conflicts, so after fixing issue ☝️ #1 mentioned above, please merge latest main and push the merge with main commit so that the branch conflicts are resolved.

[Abdulloh0109]

@ikevin127 Sorry for that — removed the accidental file and merged with latest main. Ready for re-review 🙌

[ikevin127]

@Abdulloh0109 Thanks for removing the file. For some reason it's still showing merge conflicts as you simply removed the unwanted file and force-pushed again.

If you can, please pull the latest main branch, then merge it into your PR branch (solve conflicts if any), then push a new commit (no more force-push please).

The new commit should simply be a 'merge branch main' and conflicts solved type of change, no additional files should be added.

Here's an example of a final merge branch main commit from another PR for reference: