refactor getShareDestination and clean-up some util functions by dukenv0307 · Pull Request #91554 · Expensify/App

dukenv0307 · 2026-05-25T02:26:03Z

Explanation of Change

Fixed Issues

$ #66415
PROPOSAL:

Tests

Go to workspace chat
Assign task
Enter the name and description
Verify there's no issue

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-05-25.at.09.24.26.mov

melvin-bot · 2026-05-25T02:26:21Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dukenv0307 · 2026-05-25T02:27:11Z

@DylanDylann getShareDestination function is much cleaner 👍

codecov · 2026-05-25T02:37:52Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/AvatarWithDisplayName.tsx	`80.00% <100.00%> (ø)`
src/libs/OptionsListUtils/index.ts	`84.46% <100.00%> (ø)`
src/libs/ReportNameUtils.ts	`82.85% <ø> (+0.48%)`	⬆️
src/libs/ReportUtils.ts	`83.03% <100.00%> (+0.04%)`	⬆️
src/libs/SidebarUtils.ts	`81.19% <100.00%> (ø)`
src/pages/DynamicReportDetailsPage.tsx	`56.00% <100.00%> (ø)`
src/pages/inbox/HeaderView.tsx	`95.27% <100.00%> (ø)`
src/libs/actions/Task.ts	`59.64% <0.00%> (+0.17%)`	⬆️
src/pages/ShareCodePage.tsx	`0.00% <0.00%> (ø)`
src/pages/tasks/NewTaskPage.tsx	`0.00% <0.00%> (ø)`
... and 6 files with indirect coverage changes

DylanDylann · 2026-05-28T05:11:05Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3775ffa5a7

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-05-28T05:14:55Z

    const title = getReportName(report, reportAttributes);
    const isParentReportArchived = useReportIsArchived(report?.parentReportID);
-    const subtitle = getChatRoomSubtitle(report, true, isReportArchived);
+    const subtitle = getChatRoomSubtitle(report, policy, true, isReportArchived);


Preserve submit-to subtitles when policy is absent

This component still accepts policy as optional and at least ReportSearchHeader/AnonymousReportFooter render AvatarWithDisplayName without passing one, but this changed call now prevents getChatRoomSubtitle from looking up the report policy internally. For an own policy expense chat with isPolicyNamePreferred=true, getSubmitToAccountID(undefined, report) returns no manager, so the header/search subtitle falls back to just the workspace name instead of the expected “Submits to …” text even though the policy is present in Onyx. Either keep the fallback inside getChatRoomSubtitle or ensure these callers pass the report policy.

Useful? React with 👍 / 👎.

DylanDylann · 2026-05-28T05:12:59Z

    // Use sorted display names for the title for group chats on native small screen widths
    const title = getReportName(reportHeaderData, reportAttributes);
-    const subtitle = getChatRoomSubtitle(reportHeaderData, false, isReportHeaderDataArchived);
+    const subtitle = getChatRoomSubtitle(reportHeaderData, policy, false, isReportHeaderDataArchived);


@dukenv0307 The policy parameter here looks incorrect

DylanDylann · 2026-05-28T05:16:34Z

    const title = getReportName(report, reportAttributes);
    const isParentReportArchived = useReportIsArchived(report?.parentReportID);
-    const subtitle = getChatRoomSubtitle(report, true, isReportArchived);
+    const subtitle = getChatRoomSubtitle(report, policy, true, isReportArchived);


Please ensure policy prop is required.

@dukenv0307 Please also review this problem in other places

refactor getShareDestination and clean-up some util functions

be78be6

melvin-bot Bot assigned dukenv0307 May 25, 2026

dukenv0307 marked this pull request as ready for review May 25, 2026 02:26

dukenv0307 requested review from a team as code owners May 25, 2026 02:26

melvin-bot Bot requested review from DylanDylann and heyjennahay and removed request for a team and heyjennahay May 25, 2026 02:26

melvin-bot Bot removed the request for review from a team May 25, 2026 02:26

dukenv0307 added 2 commits May 25, 2026 09:28

prettier

e7819b9

Merge branch 'main' into fix/66415-part-7

9267d3a

dukenv0307 added 4 commits May 25, 2026 09:39

lint fix

2ccfd01

lint fix

a1005ff

fix test

aa9e2a3

Merge branch 'main' into fix/66415-part-7

3775ffa

chatgpt-codex-connector Bot reviewed May 28, 2026

View reviewed changes

DylanDylann reviewed May 28, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor getShareDestination and clean-up some util functions#91554

refactor getShareDestination and clean-up some util functions#91554
dukenv0307 wants to merge 7 commits into
Expensify:mainfrom
dukenv0307:fix/66415-part-7

dukenv0307 commented May 25, 2026

Uh oh!

melvin-bot Bot commented May 25, 2026

Uh oh!

dukenv0307 commented May 25, 2026

Uh oh!

codecov Bot commented May 25, 2026 •

edited by github-actions Bot

Loading

Uh oh!

DylanDylann commented May 28, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot May 28, 2026

Uh oh!

DylanDylann May 28, 2026

Uh oh!

DylanDylann May 28, 2026

Uh oh!

DylanDylann May 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

dukenv0307 commented May 25, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented May 25, 2026

Uh oh!

dukenv0307 commented May 25, 2026

Uh oh!

codecov Bot commented May 25, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

DylanDylann commented May 28, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 28, 2026

Choose a reason for hiding this comment

Uh oh!

DylanDylann May 28, 2026

Choose a reason for hiding this comment

Uh oh!

DylanDylann May 28, 2026

Choose a reason for hiding this comment

Uh oh!

DylanDylann May 28, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov Bot commented May 25, 2026 •

edited by github-actions Bot

Loading