[No QA] Update Configure-QuickBooks-Desktop.md#91556
Conversation
This comment has been minimized.
This comment has been minimized.
HelpDot Documentation ReviewOverall AssessmentThis PR adds a single FAQ entry to the QuickBooks Desktop configuration article, explaining how employee records are handled during export (versus vendor records). The addition is small, focused, and well-written. It addresses a specific user question with clear, actionable information. Scores Summary
Key Findings
Recommendations
Files Reviewed
|
|
A preview of your ExpensifyHelp changes have been deployed to https://ba42205d.helpdot.pages.dev ⚡️ Updated articles: |
|
@stephanieelliott looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
HelpDot Documentation ReviewOverall AssessmentThis PR adds a single FAQ entry to the QuickBooks Desktop configuration article, explaining how employee records are handled when exporting from Expensify to QuickBooks Desktop. The change is small, well-written, and fits naturally into the existing FAQ section. Scores Summary
Key Findings
Recommendations
Files Reviewed
|
|
|
||
| You can export to an employee record when exporting reports as **Journal Entries** or **Checks**. | ||
|
|
||
| By default, we'll look for a vendor record with an email address matching the report submitter. If we don't find one, we'll look for an employee record. Employees must have a **Main Email** in QuickBooks Desktop that matches the email associated with their Expensify account. |
There was a problem hiding this comment.
Style consistency: This paragraph uses first-person "we'll" three times (lines 168 and 170), but the rest of the article's FAQ answers use "Expensify" as the subject (e.g., line 137: "Expensify will display an alert...") or passive constructions. For consistency, rephrase to use "Expensify" or passive voice.
Suggested rewrite:
By default, Expensify looks for a vendor record with an email address matching the report submitter. If no match is found, Expensify looks for an employee record. Employees must have a Main Email in QuickBooks Desktop that matches the email associated with their Expensify account.
|
|
||
| By default, we'll look for a vendor record with an email address matching the report submitter. If we don't find one, we'll look for an employee record. Employees must have a **Main Email** in QuickBooks Desktop that matches the email associated with their Expensify account. | ||
|
|
||
| If there is no vendor or employee record and **Auto-create entities** is enabled, we'll create a new vendor record for the submitter. |
There was a problem hiding this comment.
Style consistency: Same first-person "we'll" issue. Consider: "If there is no vendor or employee record and Auto-create entities is enabled, Expensify creates a new vendor record for the submitter."
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.3.84-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.3.86-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.3.88-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.88-2 🚀
|
Explanation of Change
Added an explanation of how employee records are handled in QBD
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/570088