Skip to content

fix: remove ViewStyle contamination from MenuItem subtitle Text#91582

Draft
MelvinBot wants to merge 1 commit into
mainfrom
claude-fixMemberRowLayoutShift
Draft

fix: remove ViewStyle contamination from MenuItem subtitle Text#91582
MelvinBot wants to merge 1 commit into
mainfrom
claude-fixMemberRowLayoutShift

Conversation

@MelvinBot
Copy link
Copy Markdown
Contributor

Explanation of Change

The subtitle Text element in MenuItem was receiving combinedStyle which includes styles.popoverMenuItem — a style containing ViewStyle properties (flexDirection: 'row', paddingHorizontal: 20, paddingVertical: 12, justifyContent: 'space-between', width: '100%'). These properties should never be applied to a Text element. On Android, they cause layout shifts when the subtitle content changes width (e.g., the Members row member count going from single digit to double digit at 10+ members).

This PR removes combinedStyle from the subtitle Text style. combinedStyle is already correctly applied to the outer Pressable container, and textLabelSupporting provides the appropriate text styling (font family, size, color).

PR #88920 previously moved subtitleStyle from the Text to a parent View, but left the combinedStyle contamination on the Text element, which is why the bug persisted.

Fixed Issues

$ #89098

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

Offline tests

N/A — this is a style-only change with no network dependency.

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)

AI Tests

Test Result
npm run typecheck Pass
npm run lint-changed Pass (no lintable files changed)
npm test -- MenuItem Pass (3 suites, 23 tests)
npm run react-compiler-compliance-check check-changed Skipped (pre-existing env issue: missing origin/main ref)

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

The subtitle Text in MenuItem was receiving combinedStyle which includes
styles.popoverMenuItem (flexDirection, paddingHorizontal: 20, paddingVertical: 12,
justifyContent, width: 100%). These ViewStyle properties on a Text element cause
Android-specific layout shifts when the subtitle content changes width (e.g.,
member count going from single to double digits).

Co-authored-by: Issa Nimaga <inimaga@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants