[CP Staging] Revert "Re-apply secure private personal details + fix address autocomplete and country auto-fill"#91606
Merged
mountiny merged 1 commit intoMay 25, 2026
Conversation
…mplete and country auto-fill"
melvin-bot
Bot
requested review from
ShridharGoel and
heyjennahay
and removed request for
a team
|
@ShridharGoel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
npm has a |
Contributor
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index ce8c5a714cb..762559fe648 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -3524,7 +3524,7 @@ ${amount} für ${merchant} – ${date}`,
noBankAccountSelected: 'Bitte wähle ein Konto aus',
taxID: 'Bitte geben Sie eine gültige Steueridentifikationsnummer ein',
website: 'Bitte eine gültige Website eingeben',
- zipCode: `Bitte gib eine gültige Postleitzahl im folgenden Format ein: ${CONST.COUNTRY_ZIP_REGEX_DATA.US.samples}`,
+ zipCode: `Bitte geben Sie eine gültige Postleitzahl im folgenden Format ein: ${CONST.COUNTRY_ZIP_REGEX_DATA.US.samples}`,
phoneNumber: 'Bitte gib eine gültige Telefonnummer ein',
email: 'Bitte gib eine gültige E-Mail-Adresse ein',
companyName: 'Bitte gib einen gültigen Unternehmensnamen ein',
diff --git a/src/languages/es.ts b/src/languages/es.ts
index abd929878e6..e90df5f58af 100644
--- a/src/languages/es.ts
+++ b/src/languages/es.ts
@@ -3404,7 +3404,7 @@ ${amount} para ${merchant} - ${date}`,
noBankAccountSelected: 'Por favor, elige una cuenta bancaria',
taxID: 'Por favor, introduce un número de identificación fiscal válido',
website: 'Por favor, introduce un sitio web válido',
- zipCode: `Formato de código postal incorrecto. Formato aceptable: ${CONST.COUNTRY_ZIP_REGEX_DATA.US.samples}.`,
+ zipCode: `Por favor, introduce un código postal válido usando el formato: ${CONST.COUNTRY_ZIP_REGEX_DATA.US.samples}`,
phoneNumber: 'Por favor, introduce un teléfono válido',
email: 'Por favor, introduce una dirección de correo electrónico válida',
companyName: 'Por favor, introduce un nombre comercial legal válido',
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index 4605fb05181..bb01ef1974d 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -3535,7 +3535,7 @@ ${amount} pour ${merchant} - ${date}`,
noBankAccountSelected: 'Veuillez choisir un compte',
taxID: 'Veuillez saisir un numéro d’identification fiscale valide',
website: 'Veuillez saisir un site web valide',
- zipCode: `Veuillez saisir un code postal valide au format : ${CONST.COUNTRY_ZIP_REGEX_DATA.US.samples}`,
+ zipCode: `Veuillez saisir un code ZIP valide au format : ${CONST.COUNTRY_ZIP_REGEX_DATA.US.samples}`,
phoneNumber: 'Veuillez saisir un numéro de téléphone valide',
email: 'Veuillez saisir une adresse e-mail valide',
companyName: 'Veuillez saisir un nom d’entreprise valide',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index ea43439d02c..7a6bd37d1a9 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -3487,7 +3487,7 @@ ${integrationName === CONST.ONBOARDING_ACCOUNTING_MAPPING.other ? 'あなたの'
noBankAccountSelected: 'アカウントを選択してください',
taxID: '有効な納税者番号を入力してください',
website: '有効なウェブサイトを入力してください',
- zipCode: `有効なZIPコードを、次の形式で入力してください: ${CONST.COUNTRY_ZIP_REGEX_DATA.US.samples}`,
+ zipCode: `有効なZIPコードを次の形式で入力してください: ${CONST.COUNTRY_ZIP_REGEX_DATA.US.samples}`,
phoneNumber: '有効な電話番号を入力してください',
email: '有効なメールアドレスを入力してください',
companyName: '有効な会社名を入力してください',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index c206abbe545..72955d370bf 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -3511,7 +3511,7 @@ ${amount} voor ${merchant} - ${date}`,
noBankAccountSelected: 'Kies een account',
taxID: 'Voer een geldig btw-identificatienummer in',
website: 'Voer een geldige website in',
- zipCode: `Voer een geldige postcode in met het volgende formaat: ${CONST.COUNTRY_ZIP_REGEX_DATA.US.samples}`,
+ zipCode: `Voer een geldige postcode in met het formaat: ${CONST.COUNTRY_ZIP_REGEX_DATA.US.samples}`,
phoneNumber: 'Voer een geldig telefoonnummer in',
email: 'Voer een geldig e-mailadres in',
companyName: 'Voer een geldige bedrijfsnaam in',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 508e837cf9f..4242ffa58ee 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -3503,7 +3503,7 @@ ${amount} dla ${merchant} - ${date}`,
noBankAccountSelected: 'Wybierz konto',
taxID: 'Wprowadź prawidłowy numer identyfikacji podatkowej',
website: 'Wprowadź prawidłową stronę internetową',
- zipCode: `Wprowadź prawidłowy kod ZIP w formacie: ${CONST.COUNTRY_ZIP_REGEX_DATA.US.samples}`,
+ zipCode: `Wpisz prawidłowy kod ZIP w formacie: ${CONST.COUNTRY_ZIP_REGEX_DATA.US.samples}`,
phoneNumber: 'Wprowadź prawidłowy numer telefonu',
email: 'Wpisz prawidłowy adres e‑mail',
companyName: 'Wprowadź prawidłową nazwę firmy',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index c2b3d3c3382..844db45688a 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -3424,7 +3424,7 @@ ${amount}，商户：${merchant} - 日期：${date}`,
noBankAccountSelected: '请选择一个账户',
taxID: '请输入有效的税号',
website: '请输入有效的网站',
- zipCode: `请输入有效的邮政编码，格式为：${CONST.COUNTRY_ZIP_REGEX_DATA.US.samples}`,
+ zipCode: `请输入符合以下格式的有效邮政编码：${CONST.COUNTRY_ZIP_REGEX_DATA.US.samples}`,
phoneNumber: '请输入有效的电话号码',
email: '请输入有效的邮箱地址',
companyName: '请输入有效的公司名称',
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
mjasikowski
approved these changes
May 25, 2026
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
mountiny
deleted the
revert-91000-jasper-securePrivatePersonalDetails-redo
branch
|
@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
Contributor
Author
|
Not emergency, straight revert |
Contributor
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
OSBotify
pushed a commit
that referenced
this pull request
May 25, 2026
…ivatePersonalDetails-redo [CP Staging] Revert "Re-apply secure private personal details + fix address autocomplete and country auto-fill" (cherry picked from commit b2b05f1) (cherry-picked to staging by mountiny)
36 tasks
Contributor
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.3.81-2 🚀
Bundle Size Analysis (Sentry): |
Contributor
|
No help site changes are required for this PR. This PR reverts #91000 (secure private personal details with magic code verification), restoring the previous behavior where each private detail field (Legal Name, DOB, Phone, Address) navigates directly to its own edit screen from the Profile page. The existing help site documentation at
Since the revert restores the behavior the docs already describe, no updates are needed. |
61 tasks
Contributor
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.81-2 🚀
|
Contributor
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.3.82-0 🚀
Bundle Size Analysis (Sentry): |
Contributor
|
I reviewed the changes in this PR against the help site articles under No help site changes are required. This PR reverts #91000, which had introduced a combined "Private Personal Details" page with magic code verification. The revert restores the original behavior where each private detail field (Legal Name, Date of Birth, Phone Number, Address) navigates to its own dedicated page under the Private section in Account > Profile. The existing help site articles already describe this original per-field navigation:
Since the help site articles were never updated for the combined page introduced in #91000, they already match the reverted (current) behavior. No draft PR is needed. @mountiny, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
This was referenced May 26, 2026
Contributor
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.82-3 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #91000
Fixed issues
$ #91602
$ #91604
$ #91608
$ #91611
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari