[No QA] Victory chart renderer: Bun CLI scaffold by roryabraham · Pull Request #91667 · Expensify/App

roryabraham · 2026-05-26T01:41:19Z

Explanation of Change

PR 2 of the stacked Victory Chart Renderer rollout. Adds the server/victory-chart-renderer/ Bun CLI subproject with npm scripts, a pinned Bun version, ESLint wiring, and a hello-world CLI that writes a fixed string to an output path.

Fixed Issues

(partial) #91528

Tests

From the App repo root, run npm run server:vcr:dev /tmp/out.txt && cat /tmp/out.txt and confirm the file contains victory-chart-renderer scaffolded.
Run cd server/victory-chart-renderer && bun test and confirm the CLI integration test passes.
Run npm run server:vcr:build:macos && ./server/victory-chart-renderer/dist/victory-chart-renderer-darwin-arm64 /tmp/outMac.txt && cat /tmp/outMac.txt confirm the same scaffold string is printed.
Run npm run server:vcr:build:linux-arm && vssh "./server/victory-chart-renderer/dist/victory-chart-renderer-linux-arm64 /tmp/out.txt && cat /tmp/out.txt". Confirm the scaffold string is printed.
(requires ring3) Run npm run server:vcr:build:linux && scp -J bastion1.sjc ./server/victory-chart-renderer/dist/victory-chart-renderer-linux-x64 <your_username>@virt1.lax:~/victory-chart-renderer && ssh -J bastion1.sjc virt1.lax "./victory-chart-renderer /tmp/out.txt && cat /tmp/out.txt". Confirm the same scaffold string is written.

N/A — no JS console impact (server-only CLI scaffold)

Offline tests

None.

QA Steps

None.

N/A — no JS console impact

PR Author Checklist

Screenshots/Videos

None.

Introduce the server subproject with a hello-world CLI, Bun pin, npm scripts, and a bun:test integration test for issue #91528 PR 2. Co-authored-by: Cursor <cursoragent@cursor.com>

Point server sources at the subproject tsconfig and relax App-only lint rules so the Bun CLI can use node/bun imports cleanly. Co-authored-by: Cursor <cursoragent@cursor.com>

codecov · 2026-05-26T01:50:25Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 31 files with indirect coverage changes

sentry · 2026-05-26T01:56:05Z

📲 Install Builds

Android

🔗 App Name	App ID	Version	Configuration
Expensify	org.me.mobiexpensifyg	9.3.83-0 (509038300)	Release

⚙️ app Build Distribution Settings

Typecheck server tools with a dedicated tsconfig that enables @types/bun instead of pulling them into the root React Native tsconfig include. Co-authored-by: Cursor <cursoragent@cursor.com>

Share one server-side TypeScript project across victory-chart-renderer and future sibling CLI tools under server/. Co-authored-by: Cursor <cursoragent@cursor.com>

…nderer-scaffold

melvin-bot · 2026-05-26T21:45:13Z

@arosiclair Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

luacmartins

LGTM. Left a couple of minor comments.

luacmartins · 2026-05-26T22:24:01Z

@@ -0,0 +1,25 @@
+import {expect, test} from 'bun:test';


NAB but can we just use server/victory-chart-renderer/tests/cli.test.ts instead of server/victory-chart-renderer/__tests__/cli.test.ts in the path to this file?

luacmartins · 2026-05-26T22:34:34Z

Additionally, I think steps 3/4 are missing building the binary

Co-authored-by: Carlos Martins <cmartins@expensify.com>

roryabraham · 2026-05-26T23:08:22Z

Additionally, I think steps 3/4 are missing building the binary

steps 3/4 in the test steps? Building the binary is in there I think. or am I missing something?

Use tests/ instead of __tests__, add server:vcr:test npm script, and update README and server tsconfig to match. Co-authored-by: Cursor <cursoragent@cursor.com>

luacmartins

LGTM

luacmartins · 2026-05-26T23:44:13Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

github-actions · 2026-05-26T23:49:58Z

🚧 @roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-05-27T00:01:19Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-05-27T00:07:14Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #91667.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-6e4f9b772e9-0146af9-6d53119bee57fd4a6c5793a50f11db83b87cfa5c/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-6e4f9b7-0146af9-d48553a829698ebd96b06c94933e95879cc34b40/index.html

Web 🕸️
https://91667.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-27T17:57:49Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.3.84-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

OSBotify · 2026-05-28T10:50:54Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.3.86-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

Bundle Size Analysis (Sentry):

Android
iOS

OSBotify · 2026-05-28T13:48:06Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.3.88-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

OSBotify · 2026-05-28T20:40:33Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.88-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

roryabraham and others added 2 commits May 25, 2026 18:40

Add victory-chart-renderer Bun CLI scaffold

daea02e

Introduce the server subproject with a hello-world CLI, Bun pin, npm scripts, and a bun:test integration test for issue #91528 PR 2. Co-authored-by: Cursor <cursoragent@cursor.com>

Configure ESLint and TypeScript for server CLI

745c7ab

Point server sources at the subproject tsconfig and relax App-only lint rules so the Bun CLI can use node/bun imports cleanly. Co-authored-by: Cursor <cursoragent@cursor.com>

melvin-bot Bot assigned roryabraham May 26, 2026

roryabraham mentioned this pull request May 26, 2026

[PR 3 of 6] Victory chart renderer: hardcoded chart + workspace stubs #91672

Draft

15 tasks

roryabraham and others added 3 commits May 26, 2026 08:56

Fix typecheck for victory-chart-renderer Bun CLI

10396ca

Typecheck server tools with a dedicated tsconfig that enables @types/bun instead of pulling them into the root React Native tsconfig include. Co-authored-by: Cursor <cursoragent@cursor.com>

Move server Bun tsconfig to server/tsconfig.json

bcf7c27

Share one server-side TypeScript project across victory-chart-renderer and future sibling CLI tools under server/. Co-authored-by: Cursor <cursoragent@cursor.com>

Merge branch 'main' into rory/victory-chart-renderer-scaffold

64b5bf0

roryabraham changed the title ~~Victory chart renderer: Bun CLI scaffold (PR 2/6)~~ Victory chart renderer: Bun CLI scaffold May 26, 2026

roryabraham changed the title ~~Victory chart renderer: Bun CLI scaffold~~ [No QA] Victory chart renderer: Bun CLI scaffold May 26, 2026

roryabraham added 3 commits May 26, 2026 13:49

Merge remote-tracking branch 'origin/main' into rory/victory-chart-re…

e271db5

…nderer-scaffold

Add target for linux-arm

f11c7d9

Remove unnecessary lint config changes

3f732ee

roryabraham requested a review from luacmartins May 26, 2026 21:44

roryabraham marked this pull request as ready for review May 26, 2026 21:44

roryabraham requested review from a team as code owners May 26, 2026 21:44

melvin-bot Bot requested review from JmillsExpensify and arosiclair and removed request for a team May 26, 2026 21:44

luacmartins reviewed May 26, 2026

View reviewed changes

Update server/victory-chart-renderer/README.md

7cf4998

Co-authored-by: Carlos Martins <cmartins@expensify.com>

Rename victory-chart-renderer tests directory to tests

51e9b39

Use tests/ instead of __tests__, add server:vcr:test npm script, and update README and server tsconfig to match. Co-authored-by: Cursor <cursoragent@cursor.com>

roryabraham requested a review from luacmartins May 26, 2026 23:14

luacmartins approved these changes May 26, 2026

View reviewed changes

roryabraham merged commit 6e4f9b7 into main May 26, 2026
52 of 55 checks passed

roryabraham deleted the rory/victory-chart-renderer-scaffold branch May 26, 2026 23:49

roryabraham mentioned this pull request May 27, 2026

Create bun CLI to render Victory Charts to png #91528

Open

OSBotify mentioned this pull request May 27, 2026

Deploy Checklist: New Expensify 2026-05-27 #91866

Closed

75 tasks

Conversation

roryabraham commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented May 26, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sentry Bot commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📲 Install Builds

Android

Uh oh!

melvin-bot Bot commented May 26, 2026

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

luacmartins May 26, 2026

Choose a reason for hiding this comment

Uh oh!

roryabraham May 26, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

luacmartins commented May 26, 2026

Uh oh!

roryabraham commented May 26, 2026

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

luacmartins commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

github-actions Bot commented May 26, 2026

Uh oh!

OSBotify commented May 27, 2026

Uh oh!

github-actions Bot commented May 27, 2026

Uh oh!

OSBotify commented May 27, 2026

Uh oh!

OSBotify commented May 28, 2026

Uh oh!

OSBotify commented May 28, 2026

Uh oh!

OSBotify commented May 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

roryabraham commented May 26, 2026 •

edited

Loading

codecov Bot commented May 26, 2026 •

edited by github-actions Bot

Loading

sentry Bot commented May 26, 2026 •

edited

Loading

luacmartins commented May 26, 2026 •

edited

Loading