LHN badge priority: use oldest report action between Task and IOU by MelvinBot · Pull Request #91676 · Expensify/App

MelvinBot · 2026-05-26T03:05:02Z

Explanation of Change

When a workspace chat has both an outstanding task and an IOU action (Submit/Approve/Pay), the LHN badge should display the one corresponding to the oldest report action, since that represents the first required action. Previously, the task badge check in getReasonAndReportActionThatRequiresAttention ran before the IOU badge check and returned early, so the Task badge always won regardless of which action was created first.

This PR restructures the logic to:

Compute the IOU candidate upfront (moved before the task check)
When a task badge candidate exists, compare its created timestamp against the IOU candidate
Return whichever badge corresponds to the older report action

The expense assignee path (processing expense reports) is unchanged.

Fixed Issues

$ #91664

Tests

Verify that no errors appear in the JS console
Open a workspace chat that has both an outstanding task assigned to you AND an outstanding expense (Submit/Approve/Pay)
If the expense was created before the task, verify the LHN badge shows the expense badge (e.g. Pay), not the Task badge
If the task was created before the expense, verify the LHN badge shows the Task badge
Open a workspace chat that has only an outstanding task (no expense) and verify the Task badge still appears correctly
Open a workspace chat that has only an outstanding expense (no task) and verify the expense badge still appears correctly

Offline tests

Verify the LHN badge displays correctly when offline (badge is computed from local data, no network dependency)

QA Steps

Verify that no errors appear in the JS console
In a workspace chat with both an outstanding task and an outstanding expense, verify the LHN badge corresponds to whichever action is oldest
Verify that completing the displayed action updates the badge to show the remaining action

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

AI Tests

Test	Result
`getReasonAndReportActionThatRequiresAttention` (13 tests)	✅ All passed
`LHNItemsPresence` (21 tests)	✅ All passed
`typecheck-tsgo`	✅ No new errors (pre-existing errors only)
`prettier`	✅ No changes needed

… and IOU When a chat has both an outstanding task and an IOU action (Submit/Approve/Pay), the badge shown in the LHN should correspond to the oldest report action rather than always showing the Task badge. Previously the task check ran first and returned early, preventing the IOU badge from being evaluated. Co-authored-by: Aimane Chnaif <aimane-chnaif@users.noreply.github.com>

MelvinBot · 2026-05-26T03:07:05Z

The only failing check is the PR Author Checklist, which is a manual checklist — not a code issue. All other checks are either passing or still pending (tests, typecheck, perf tests, Storybook).

There are no code-related check failures to fix. The pending checks should resolve on their own shortly. If any of the currently pending checks fail after they complete, feel free to tag me again and I'll take a look.

aimane-chnaif · 2026-05-26T04:17:05Z

@MelvinBot add test steps and check off all items. They're verified.

MelvinBot · 2026-05-26T04:19:29Z

Done — added test steps (Tests, Offline tests, QA Steps) and checked off all PR Author Checklist items.

chatgpt-codex-connector · 2026-05-26T04:22:39Z

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

aimane-chnaif · 2026-05-26T04:48:00Z

+            .at(0);
+
+        // If there's a valid IOU action that is older than the task, use the IOU badge instead
+        if (hasValidIOUAction && iouReportActionToApproveOrPay?.created && oldestTaskAction?.created && iouReportActionToApproveOrPay.created < oldestTaskAction.created) {


There's backend bug.
When I first login or clear cache, childManagerAccountID doesn't exist in task report action before opening report.
So oldestTaskAction is undefined as action.childManagerAccountID === deprecatedCurrentUserAccountID condition isn't met.

Before opening report:

After opening report:

bug.mov

@MelvinBot

Suggested change

if (hasValidIOUAction && iouReportActionToApproveOrPay?.created && oldestTaskAction?.created && iouReportActionToApproveOrPay.created < oldestTaskAction.created) {

if (hasValidIOUAction && iouReportActionToApproveOrPay?.created && (!oldestTaskAction || iouReportActionToApproveOrPay.created < oldestTaskAction.created)) {

Also add unit test for this case.

Done. Updated the condition to (!oldestTaskAction || iouReportActionToApproveOrPay.created < oldestTaskAction.created) and added a unit test covering the case where childManagerAccountID is missing (so oldestTaskAction is undefined).

…estTaskAction is undefined When childManagerAccountID is not populated (backend bug before opening report), oldestTaskAction is undefined. Update the comparison to fall back to the IOU badge in this case, and add a unit test covering the scenario. Co-authored-by: Aimane Chnaif <aimane-chnaif@users.noreply.github.com>

aimane-chnaif · 2026-05-26T04:59:58Z

@MelvinBot mark as ready for review

codecov · 2026-05-26T05:00:29Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/ReportUtils.ts	`82.88% <100.00%> (-0.06%)`	⬇️
... and 10 files with indirect coverage changes

MelvinBot · 2026-05-26T05:01:16Z

Done — PR has been marked as ready for review.

melvin-bot · 2026-05-26T05:01:19Z

@huult Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

aimane-chnaif · 2026-05-26T05:01:25Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android.mov

Android: mWeb Chrome

iOS: HybridApp

ios.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

danieldoglas

LGTM

huult · 2026-05-28T03:31:03Z

@MelvinBot Please unassign me because I am not a reviewer for this PR.

MelvinBot · 2026-05-28T03:32:12Z

Done! I've removed huult from the reviewer list for this PR.

melvin-bot · 2026-05-28T21:31:40Z

@danieldoglas looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

github-actions · 2026-05-28T21:32:54Z

🚧 @danieldoglas has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-05-28T21:38:04Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #91676.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-bc7d1be5da6-a82d62a-2370edf82225ab6911e96902043a1808897d9b69/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-bc7d1be-a82d62a-6628fe7a7d6d8e69eae4c01430b3e024c567bc4a/index.html

Web 🕸️
https://91676.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-28T21:41:32Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

MelvinBot assigned aimane-chnaif May 26, 2026

MelvinBot requested a review from a team May 26, 2026 03:05

MelvinBot mentioned this pull request May 26, 2026

[$250] LHN - Task badge appears in LHN when Approve action is the first required action #91664

Open

7 tasks

aimane-chnaif reviewed May 26, 2026

View reviewed changes

MelvinBot marked this pull request as ready for review May 26, 2026 05:01

MelvinBot requested a review from a team as a code owner May 26, 2026 05:01

melvin-bot Bot requested review from JmillsExpensify and huult and removed request for a team May 26, 2026 05:01

melvin-bot Bot removed the request for review from a team May 26, 2026 05:01

aimane-chnaif approved these changes May 26, 2026

View reviewed changes

melvin-bot Bot requested a review from danieldoglas May 26, 2026 05:01

danieldoglas approved these changes May 26, 2026

View reviewed changes

MelvinBot removed the request for review from huult May 28, 2026 03:32

danieldoglas merged commit bc7d1be into main May 28, 2026
51 of 53 checks passed

danieldoglas deleted the claude-taskBadgePriorityByAge branch May 28, 2026 21:31

melvin-bot Bot added the Emergency label May 28, 2026

	if (hasValidIOUAction && iouReportActionToApproveOrPay?.created && oldestTaskAction?.created && iouReportActionToApproveOrPay.created < oldestTaskAction.created) {
	if (hasValidIOUAction && iouReportActionToApproveOrPay?.created && (!oldestTaskAction \|\| iouReportActionToApproveOrPay.created < oldestTaskAction.created)) {

Conversation

MelvinBot commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

AI Tests

Uh oh!

MelvinBot commented May 26, 2026

Uh oh!

aimane-chnaif commented May 26, 2026

Uh oh!

MelvinBot commented May 26, 2026

Uh oh!

chatgpt-codex-connector Bot commented May 26, 2026

Uh oh!

aimane-chnaif May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MelvinBot May 26, 2026

Choose a reason for hiding this comment

Uh oh!

aimane-chnaif commented May 26, 2026

Uh oh!

codecov Bot commented May 26, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

MelvinBot commented May 26, 2026

Uh oh!

melvin-bot Bot commented May 26, 2026

Uh oh!

aimane-chnaif commented May 26, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

danieldoglas left a comment

Choose a reason for hiding this comment

Uh oh!

huult commented May 28, 2026

Uh oh!

MelvinBot commented May 28, 2026

Uh oh!

Uh oh!

melvin-bot Bot commented May 28, 2026

Uh oh!

github-actions Bot commented May 28, 2026

Uh oh!

github-actions Bot commented May 28, 2026

Uh oh!

OSBotify commented May 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

MelvinBot commented May 26, 2026 •

edited

Loading

aimane-chnaif May 26, 2026 •

edited

Loading

codecov Bot commented May 26, 2026 •

edited by github-actions Bot

Loading