telemetry: add followupSource and accountID to followup_clicked log event#91687
Draft
marcochavezf wants to merge 1 commit into
Draft
telemetry: add followupSource and accountID to followup_clicked log event#91687marcochavezf wants to merge 1 commit into
marcochavezf wants to merge 1 commit into
Conversation
…vent
Reads the source attribute from <followup-list> HTML so the App can report
whether a clicked followup came from the bespoke welcome message ("welcome")
or a Concierge response ("concierge"). Also logs accountID for clean DW cohort
joins without email-join workarounds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Adds two new fields to the
followup_clickedtelemetry log event:followupSource—"welcome"when the pill came from the bespoke welcome message,"concierge"when it came from a Concierge response mid-conversation,undefinedfor older messages that predate thesourceattribute. Reads from the newsourceattribute on the<followup-list>HTML element (added in companion PRs to Auth and Web-Expensify).accountID— the current user's accountID. Enables clean DW cohort joins (e.g. joiningfollowup_clickedagainsthasFund) without fragile email-join workarounds.Part of: https://github.com/Expensify/Expensify/issues/625673
Companion PRs:
source="welcome"to bespoke followup HTML + HTMLPurifier allowlistsource="concierge"tobuildFollowupListHtmlFixed Issues
For https://github.com/Expensify/Expensify/issues/625673
PROPOSAL:
Tests
Telemetry-only change. No user-visible behavior changes.
Offline tests
No offline behavior changes —
Log.infois a fire-and-forget call that does not affect offline functionality.QA Steps
No QA — telemetry-only change with no user-visible behavior. [No QA]
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
N/A — telemetry-only change, no UI changes
Android: mWeb Chrome
N/A — telemetry-only change, no UI changes
iOS: Native
N/A — telemetry-only change, no UI changes
iOS: mWeb Safari
N/A — telemetry-only change, no UI changes
MacOS: Chrome / Safari
N/A — telemetry-only change, no UI changes
Web
N/A — telemetry-only change, no UI changes