Skip to content

fix: update translation#91691

Open
mdneyazahmad wants to merge 3 commits into
Expensify:mainfrom
mdneyazahmad:fix/91050-update-translation
Open

fix: update translation#91691
mdneyazahmad wants to merge 3 commits into
Expensify:mainfrom
mdneyazahmad:fix/91050-update-translation

Conversation

@mdneyazahmad
Copy link
Copy Markdown
Contributor

@mdneyazahmad mdneyazahmad commented May 26, 2026

Explanation of Change

It changes translation text from Save search to Save view.

Fixed Issues

$ #91050
PROPOSAL: #91050 (comment)

Tests

  1. Go to spend
  2. Select a report
  3. Click save
  4. Verify that the page title is Save view
  5. Verify that form button at the bottom has Save view text
  6. Update anything related to sentry backend from Search-SaveSearchButton to Search-SaveViewButton
  • Verify that no errors appear in the JS console

Offline tests

NA

QA Steps

  1. Go to spend
  2. Select a report
  3. Click save
  4. Verify that the page title is Save view
  5. Verify that form button at the bottom has Save view text
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Pending

Android: mWeb Chrome

Pending

iOS: Native

Pending

iOS: mWeb Safari

Pending

MacOS: Chrome / Safari
macos_chrome.mov

@mdneyazahmad
Copy link
Copy Markdown
Contributor Author

@shubham1206agra can you help me with the translations of this Save view for all supported languages?

@codecov
Copy link
Copy Markdown

codecov Bot commented May 26, 2026

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/CONST/index.ts 93.84% <ø> (ø)
src/pages/Search/SearchSavePage.tsx 0.00% <0.00%> (ø)
... and 512 files with indirect coverage changes

@shubham1206agra
Copy link
Copy Markdown
Contributor

@mdneyazahmad Change for one and then we will run the bot for translations

@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented May 27, 2026

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

@OSBotify
Copy link
Copy Markdown
Contributor

🦜 Polyglot Parrot! 🦜

Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues:

View the translation diff
diff --git a/src/languages/de.ts b/src/languages/de.ts
index 669d0c2fcce..469ec0c7be4 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -8110,6 +8110,7 @@ Fügen Sie weitere Ausgabelimits hinzu, um den Cashflow Ihres Unternehmens zu sc
             topCategories: 'Topkategorien',
             topMerchants: 'Top-Händler',
         },
+        saveView: 'Ansicht speichern',
     },
     genericErrorPage: {
         title: 'Ups, da ist etwas schiefgelaufen!',
diff --git a/src/languages/es.ts b/src/languages/es.ts
index dcb9acaca32..80d39532b9f 100644
--- a/src/languages/es.ts
+++ b/src/languages/es.ts
@@ -7897,6 +7897,7 @@ ${amount} para ${merchant} - ${date}`,
         errors: {
             pleaseSelectDatesForBothFromAndTo: 'Por favor, selecciona fechas para Desde y Hasta',
         },
+        saveView: 'Guardar vista',
     },
     genericErrorPage: {
         title: '¡Oh-oh, algo salió mal!',
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index e149ae58a55..a6d1262746b 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -8141,6 +8141,7 @@ Ajoutez davantage de règles de dépenses pour protéger la trésorerie de l’e
             topCategories: 'Catégories principales',
             topMerchants: 'Meilleurs commerçants',
         },
+        saveView: 'Enregistrer la vue',
     },
     genericErrorPage: {
         title: 'Oups, quelque chose s’est mal passé !',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index e059a3b4e03..031dc1d6851 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -8102,6 +8102,7 @@ Aggiungi altre regole di spesa per proteggere il flusso di cassa aziendale.`,
             topCategories: 'Categorie principali',
             topMerchants: 'Principali esercenti',
         },
+        saveView: 'Salva vista',
     },
     genericErrorPage: {
         title: 'Oops, qualcosa è andato storto!',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 0baff8dc848..91de94fc454 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -8000,6 +8000,7 @@ ${reportName}
             topCategories: '上位カテゴリ',
             topMerchants: '上位加盟店',
         },
+        saveView: 'ビューを保存',
     },
     genericErrorPage: {
         title: 'おっと、問題が発生しました!',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 8196a472d4b..ed4630f1ecc 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -8072,6 +8072,7 @@ er bestedingsregels toe om de kasstroom van het bedrijf te beschermen.`,
             topCategories: 'Topcategorieën',
             topMerchants: 'Topverkopers',
         },
+        saveView: 'Weergave opslaan',
     },
     genericErrorPage: {
         title: 'Oeps, er is iets misgegaan!',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index cc826b8cf38..97a90710e5f 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -8064,6 +8064,7 @@ Dodaj więcej zasad wydatków, żeby chronić płynność finansową firmy.`,
             topCategories: 'Najpopularniejsze kategorie',
             topMerchants: 'Najważniejsi sprzedawcy',
         },
+        saveView: 'Zapisz widok',
     },
     genericErrorPage: {
         title: 'Ups, coś poszło nie tak!',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 3d0f44a7b62..e2b904d8285 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -8065,6 +8065,7 @@ Adicione mais regras de gasto para proteger o fluxo de caixa da empresa.`,
             topCategories: 'Principais categorias',
             topMerchants: 'Principais estabelecimentos',
         },
+        saveView: 'Salvar visualização',
     },
     genericErrorPage: {
         title: 'Opa, algo deu errado!',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 7c698d84584..186be0c11ea 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -7859,6 +7859,7 @@ ${reportName}
             topCategories: '热门类别',
             topMerchants: '热门商家',
         },
+        saveView: '保存视图',
     },
     genericErrorPage: {
         title: '哎呀,出错了!',

Note

You can apply these changes to your branch by copying the patch to your clipboard, then running pbpaste | git apply 😉

View workflow run

@mdneyazahmad mdneyazahmad marked this pull request as ready for review May 29, 2026 04:16
@mdneyazahmad mdneyazahmad requested review from a team as code owners May 29, 2026 04:16
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented May 29, 2026

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot removed request for a team May 29, 2026 04:16
@mdneyazahmad
Copy link
Copy Markdown
Contributor Author

I am having some error when running android and ios. It renders the first screen then it crashes. I will upload the video for native platform when it resolves. Meanwhile, I opened the PR for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants