Migrate InteractionManager - batch 6#91715
Draft
mrejdak wants to merge 16 commits into
Draft
Conversation
|
Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers! |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
91dda4f to
489c0b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Batch 6 of InteractionManager migration
ReportActionItemEventHandler/was removed, as it was unreachable. The handler was no-op on every platform other than Android, while it's only use was inReportActionItemMessageEdit.tsx- a component which is only used with wide screen (so it is never rendered on mobile).Fixed Issues
$ #71913
$ #83067
PROPOSAL:
Tests
FormWrapper.tsx(web)WorkspacesNew->New workspaceand verify that the modal scrolls down so thatConfirmbutton is fully visibleMoneyRequestReportActionsList.tsxSpend->ReportsReportActionsList.tsxInboxReportActionsList.tsx(safari only)ReportActionsList.tsx(chrome dev tools required)Inboxand open a 1:1 chat (e.g. personal chat) with enough messages to scrollChrome dev toolsset throttling toOfflineAccount->TroubleshootChrome dev toolsset throttling back toNo throttlingReportActionsList.tsxSpend->ExpensesOffline tests
N/A
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
ReportActionsList.tsxbatch6_RAL_scroll_on_mnt.mov
batch6_RAL_scroll_on_mnt_new.mov
iOS: mWeb Safari
MacOS: Chrome / Safari
FormWrapper.tsxbatch6_formWrapper.mov
MoneyRequestReportActionsList.tsxbatch6_MoneyReqAction_scroll.mov
batch6_MoneyReqAction_loadOld.mov
ReportActionsList.tsxbatch6_RAL_scroll_on_mount.mov
batch6_RAL_scroll_on_mount_new.mov
ReportActionsList.tsx(safari)batch6_RAL_safari.mov
ReportActionsList.tsx(Chrome dev tools required)Screen.Recording.2026-05-26.at.17.41.39.mov
ReportActionsList.tsxbatch6_RAL_newer_messages.mov