Skip to content

Migrate InteractionManager - batch 6#91715

Draft
mrejdak wants to merge 16 commits into
Expensify:mainfrom
software-mansion-labs:mrejdak/migrate-interactionmanager-b6
Draft

Migrate InteractionManager - batch 6#91715
mrejdak wants to merge 16 commits into
Expensify:mainfrom
software-mansion-labs:mrejdak/migrate-interactionmanager-b6

Conversation

@mrejdak
Copy link
Copy Markdown
Contributor

@mrejdak mrejdak commented May 26, 2026

Explanation of Change

Batch 6 of InteractionManager migration

ReportActionItemEventHandler/ was removed, as it was unreachable. The handler was no-op on every platform other than Android, while it's only use was in ReportActionItemMessageEdit.tsx‎ - a component which is only used with wide screen (so it is never rendered on mobile).

Fixed Issues

$ #71913
$ #83067
PROPOSAL:

Tests

FormWrapper.tsx (web)

  1. Set an account as an approved accountant (isApprovedAccountant: true)
  2. Navigate to Workspaces
  3. Make sure that the screen height is less than 625px
  4. Press New -> New workspace and verify that the modal scrolls down so that Confirm button is fully visible

MoneyRequestReportActionsList.tsx

  1. Navigate to Spend -> Reports
  2. Open a report with multiple expenses and messages
  3. Verify that the content loaded correctly
  4. Scroll to the top and write a new message
  5. Send the message and verify that the report correctly scrolls down to it

ReportActionsList.tsx

  1. Navigate to Inbox
  2. Open a chat without new (unread) messages
  3. Verify that the chat is scrolled all the way to the bottom and there is no Floating Message Counter (green line separating unread messages)
  4. Go back and open a chat with new (unread) messages
  5. Verify that the chat is scrolled to the first unread message

ReportActionsList.tsx (safari only)

  1. Open your personal chat
  2. Create a new expense
  3. Once the expense is created, a Concierge message appears in the chat
  4. Verify that the options in Concierge's message are correctly highlighted when hovering over them.

ReportActionsList.tsx (chrome dev tools required)

  1. Navigate to Inbox and open a 1:1 chat (e.g. personal chat) with enough messages to scroll
  2. In Chrome dev tools set throttling to Offline
  3. Create a new expense in the chat
  4. Go to Account -> Troubleshoot
  5. Toggle the "Simulate failing network requests" option
  6. Navigate back to the chat with the new expense
  7. Scroll up
  8. In Chrome dev tools set throttling back to No throttling
  9. Verify that the chat snaps down to the bottom, once the red error message appears

ReportActionsList.tsx

  1. Navigate to Spend -> Expenses
  2. Open an expense with multiple chat messages
  3. Verify that the chat loads correctly, without a flicker
  • Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as Tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native

ReportActionsList.tsx

batch6_RAL_scroll_on_mnt.mov
batch6_RAL_scroll_on_mnt_new.mov
iOS: mWeb Safari
MacOS: Chrome / Safari

FormWrapper.tsx

batch6_formWrapper.mov

MoneyRequestReportActionsList.tsx

batch6_MoneyReqAction_scroll.mov
batch6_MoneyReqAction_loadOld.mov

ReportActionsList.tsx

batch6_RAL_scroll_on_mount.mov
batch6_RAL_scroll_on_mount_new.mov

ReportActionsList.tsx (safari)

batch6_RAL_safari.mov

ReportActionsList.tsx (Chrome dev tools required)

Screen.Recording.2026-05-26.at.17.41.39.mov

ReportActionsList.tsx

batch6_RAL_newer_messages.mov

@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented May 26, 2026

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

@codecov
Copy link
Copy Markdown

codecov Bot commented May 26, 2026

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/components/Form/FormWrapper.tsx 82.35% <ø> (ø)
...pages/inbox/report/ReportActionItemMessageEdit.tsx 56.14% <ø> (+1.17%) ⬆️
...equestReportView/MoneyRequestReportActionsList.tsx 64.15% <0.00%> (-0.49%) ⬇️
... and 44 files with indirect coverage changes

@mrejdak mrejdak force-pushed the mrejdak/migrate-interactionmanager-b6 branch from 91dda4f to 489c0b0 Compare May 27, 2026 10:45
Comment thread src/components/Form/FormWrapper.tsx Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants