[No QA] perf: avoid full getTransactionDetails per transaction in getBillableAndTaxTotal by TMisiukiewicz · Pull Request #91716 · Expensify/App

TMisiukiewicz · 2026-05-26T11:49:15Z

Explanation of Change

getBillableAndTaxTotal only needs four fields from each transaction (amount, taxAmount, currency, billable) but was calling getTransactionDetails, which materializes the full TransactionDetails object. That object includes two timezone-aware date formats per transaction (getFormattedCreated + getFormattedPostedDate via formatWithUTCTimeZone), attendees, waypoints, MCC group, original/converted amount, etc. — all discarded immediately. On an expense report with N transactions this was ~2N date-fns timezone format calls thrown away.

Flame graph on iOS showed ~1.2s spent in this function on report-open, dominated by getFormattedCreated → formatWithUTCTimeZone → toDate / tzParseTimezone / format.

Fix:

Replace getTransactionDetails with the four direct accessors (getBillable, getTaxAmount, getCurrency, getTransactionAmount).
Hoist reportCurrency out of the loop (it's an invariant).
Pass isFromExpenseReport = true directly — the early return above the loop proves the report is an expense report, so the per-transaction getReportOrDraftReport + isExpenseReport lookups inside getTransactionDetails are gone.
Short-circuit when both billable and taxAmount are falsy — skip currency comparison and getTransactionAmount for those rows.

This way getBillableAndTaxTotal time on a report with 1.6k transactions was reduced from 1.2s to ~5ms

Fixed Issues

$ #91719
PROPOSAL:

Tests

No tests needed, required functions were extracted from getTransactionDetails

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…er-transaction date formatting

melvin-bot · 2026-05-26T11:52:58Z

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mountiny · 2026-05-26T12:19:39Z

@abdulrahuman5196 I will ask for reassignment in slack for faster review

Pujan92 · 2026-05-26T12:22:55Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-05-26.at.18.30.27.mov

Copilot

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Optimizes getBillableAndTaxTotal by avoiding full getTransactionDetails materialization per transaction, reducing unnecessary formatting/work for large expense reports.

Changes:

Replace getTransactionDetails() usage with direct accessors (getBillable, getTaxAmount, getCurrency, getTransactionAmount).
Hoist invariant reportCurrency outside the loop and skip deleted/empty-impact transactions earlier.
Reduce per-transaction overhead by passing isFromExpenseReport = true directly and short-circuiting when totals won’t change.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Pujan92 · 2026-05-26T12:58:30Z

+            continue;
+        }
+        const billable = getBillable(transaction);
+        // `isFromExpenseReport` is provably true: the early return above guarantees the report is an expense report.


I feel that this comment isn't needed

Ah, ok. it helps to explain why we are passing true directly for isFromExpenseReport

Pujan92

LGTM!

…lable-tax-total-skip-transaction-details

mountiny

Thank you!

github-actions · 2026-05-27T09:33:25Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-05-27T09:38:46Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #91716.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-fda8d34615b-0146af9-6d53119bee57fd4a6c5793a50f11db83b87cfa5c/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-fda8d34-0146af9-d48553a829698ebd96b06c94933e95879cc34b40/index.html

Web 🕸️
https://91716.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-27T17:57:58Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.84-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

OSBotify · 2026-05-28T10:51:03Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.86-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-05-28T10:53:22Z

No help site changes are needed for this PR.

This is a pure performance optimization — it replaces getTransactionDetails with four direct accessors (getBillable, getTaxAmount, getCurrency, getTransactionAmount) inside getBillableAndTaxTotal to avoid materializing full TransactionDetails objects per transaction. No user-facing behavior, UI, features, or terminology changed.

@TMisiukiewicz, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

OSBotify · 2026-05-28T13:48:15Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.88-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-05-28T13:49:38Z

No help site changes are needed for this PR.

This is an internal performance optimization to getBillableAndTaxTotal — it replaces getTransactionDetails with direct field accessors to avoid materializing unused data (formatted dates, attendees, waypoints, etc.). There are no user-facing behavior changes, no UI changes, and no new or modified terminology.

@TMisiukiewicz, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

OSBotify · 2026-05-28T20:40:42Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.88-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

TMisiukiewicz added 4 commits May 21, 2026 13:07

Merge branch 'main' of https://github.com/Expensify/App

d2ae07c

Merge branch 'main' of https://github.com/Expensify/App

568f391

Merge branch 'main' of https://github.com/Expensify/App

99be59c

perf: skip getTransactionDetails in getBillableAndTaxTotal to avoid p…

74b9c03

…er-transaction date formatting

melvin-bot Bot assigned TMisiukiewicz May 26, 2026

TMisiukiewicz changed the title ~~perf: avoid full getTransactionDetails per transaction in getBillableAndTaxTotal~~ [No QA] perf: avoid full getTransactionDetails per transaction in getBillableAndTaxTotal May 26, 2026

TMisiukiewicz marked this pull request as ready for review May 26, 2026 11:52

TMisiukiewicz requested review from a team as code owners May 26, 2026 11:52

melvin-bot Bot requested review from abdulrahuman5196 and joekaufmanexpensify and removed request for a team and joekaufmanexpensify May 26, 2026 11:52

melvin-bot Bot removed the request for review from a team May 26, 2026 11:52

mountiny mentioned this pull request May 26, 2026

[Due for payment 2026-06-04] [No QA] perf: avoid full getTransactionDetails per transaction in getBillableAndTaxTotal #91719

Open

mountiny requested review from Pujan92, Copilot and mountiny and removed request for abdulrahuman5196 May 26, 2026 12:19

Copilot AI reviewed May 26, 2026

View reviewed changes

Comment thread src/libs/ReportUtils.ts Outdated

Pujan92 reviewed May 26, 2026

View reviewed changes

Pujan92 approved these changes May 26, 2026

View reviewed changes

TMisiukiewicz added 2 commits May 27, 2026 08:50

address review: name positional bool args in getBillableAndTaxTotal

2ebfb3e

Merge branch 'main' of https://github.com/Expensify/App into perf/bil…

07962fc

…lable-tax-total-skip-transaction-details

mountiny approved these changes May 27, 2026

View reviewed changes

mountiny merged commit fda8d34 into Expensify:main May 27, 2026
34 checks passed

OSBotify mentioned this pull request May 27, 2026

Deploy Checklist: New Expensify 2026-05-27 #91866

Closed

75 tasks

Conversation

TMisiukiewicz commented May 26, 2026 • edited by mountiny Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented May 26, 2026

Uh oh!

mountiny commented May 26, 2026

Uh oh!

Pujan92 commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Pujan92 May 26, 2026

Choose a reason for hiding this comment

Uh oh!

Pujan92 May 26, 2026

Choose a reason for hiding this comment

Uh oh!

Pujan92 left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented May 27, 2026

Uh oh!

github-actions Bot commented May 27, 2026

Uh oh!

OSBotify commented May 27, 2026

Uh oh!

OSBotify commented May 28, 2026

Uh oh!

MelvinBot commented May 28, 2026

Uh oh!

OSBotify commented May 28, 2026

Uh oh!

MelvinBot commented May 28, 2026

Uh oh!

OSBotify commented May 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

TMisiukiewicz commented May 26, 2026 •

edited by mountiny

Loading

Pujan92 commented May 26, 2026 •

edited

Loading