[Home Page] Only show the skeleton loader for Home's For you page on initial load, no subsequent loads by adamgrzybowski · Pull Request #91720 · Expensify/App

adamgrzybowski · 2026-05-26T12:40:23Z

Explanation of Change

Reproduced on iOS (HybridApp build). Home > For you was rendering the skeleton loader on every foreground/reconnect because the section gated its loading UI on IS_LOADING_REPORT_DATA, which ReconnectApp flips to true optimistically each time the app returns from the background.
Added a subscription to ONYXKEYS.HAS_LOADED_APP in src/pages/home/ForYouSection/index.tsx and gated the skeleton on !hasLoadedApp && (isLoadingApp || isLoadingReportData || reportCounts === undefined) so it only renders on the initial OpenApp cold-start path.
After the first OpenApp completes, HAS_LOADED_APP stays true for the rest of the session (preserved across reconnects), so subsequent ReconnectApp refreshes update in place and the section keeps showing its previous content.
The TopBar loading bar (already wired to isLoadingApp || isLoadingReportData in HomePage.tsx) continues to indicate a refresh is in flight, matching the Inbox behavior referenced in the issue.
Added hasLoadedApp to the skeleton's reasonAttributes so Sentry skeleton spans can be filtered/triaged accurately.

Fixed Issues

$ #91575
PROPOSAL:

Tests

Offline tests

QA Steps

Run on iOS Native first (where the bug was reproduced). Repeat on other platforms as a regression check.

Sign in to a staging account with at least one actionable report in Home > For you.
Cold-start the app on Home. Expected: skeleton flashes once, then real todos render.
Background the app and foreground it again, 3–4 times. Expected: For you content stays in place every time; no skeleton flash. A thin loading bar may briefly appear in the top bar.

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Screen.Recording.2026-05-26.at.14.37.38.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

Gates the Home > For you skeleton on HAS_LOADED_APP so it only renders on the OpenApp cold-start path. ReconnectApp also flips IS_LOADING_REPORT_DATA optimistically, which was causing the section to flash the skeleton every time the app came back from the background. Other home sections (Your spend, etc.) already update in place; this brings For you in line. Fixes Expensify#91575

melvin-bot · 2026-05-26T12:40:31Z

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2026-05-27T08:02:39Z

@adamgrzybowski
Let's update the branch to the latest version of main to fix issues!

ZhenjaHorbach · 2026-05-27T08:53:15Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

2026-05-27.11.19.01.mov

Android: mWeb Chrome

2026-05-27.11.03.57.mov

iOS: HybridApp

2026-05-27.11.06.32.mov

iOS: mWeb Safari

2026-05-27.11.03.57.mov

MacOS: Chrome / Safari

2026-05-27.11.00.06.mov

ZhenjaHorbach · 2026-05-27T09:20:42Z

LGTM!
Only need to update the branch to the latest version of main to fix pipeline issues!

…nnect

adamgrzybowski · 2026-05-27T11:27:18Z

@ZhenjaHorbach done

ZhenjaHorbach · 2026-05-27T11:47:45Z

@grgia
We can merge this!

melvin-bot · 2026-05-27T11:54:26Z

@grgia looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

grgia · 2026-05-27T11:57:01Z

Merged from my phone before the final reviewer check finished.

OSBotify · 2026-05-27T12:09:29Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-05-27T12:20:10Z

🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-05-27T12:26:02Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #91720.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-cd9d85cba92-fc8f3a9-75a09300a3099d0506acb3c0bdd0c361b05854a8/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-cd9d85c-fc8f3a9-cedaf5aa5069b13f264a286b24ed095fcf4cf159/index.html

Web 🕸️
https://91720.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-27T17:58:01Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.3.84-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-05-27T18:02:54Z

I reviewed the changes in this PR. The diff modifies only src/pages/home/ForYouSection/index.tsx to gate the skeleton loader on HAS_LOADED_APP, preventing it from flashing on every foreground/reconnect cycle. This is a purely internal loading-state fix with no changes to user-facing features, settings, navigation, or product behavior.

No help site documentation changes are required.

@adamgrzybowski, no help site PR was created since the changes don't affect any documented user-facing behavior.

OSBotify · 2026-05-28T10:51:06Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.3.86-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-05-28T10:53:31Z

No help site changes are required for this PR.

This PR fixes an internal UI behavior — it gates the skeleton loader in the "For You" section to only appear on the initial cold-start load, preventing it from flashing on every foreground/reconnect. This is a code-level loading optimization that doesn't change any user-facing features, settings, workflows, or terminology documented on the help site.

@adamgrzybowski, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

OSBotify · 2026-05-28T13:48:18Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.3.88-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-05-28T13:50:04Z

I reviewed the changes in this PR against the help site articles under App/docs/articles.

No help site changes are required.

This PR is a bug fix that changes the internal loading/skeleton behavior of the For you section on Home. Specifically, it gates the skeleton loader on HAS_LOADED_APP so it only renders on initial cold start, not on every foreground/reconnect. This is a UX polish fix — no user-facing features, settings, labels, workflows, or terminology changed.

The two relevant help articles — Understanding the For you Section and Expensify Home Overview — describe what the For you section shows and how it works at a conceptual level. They do not document loading states or skeleton behavior, so they remain accurate as-is.

@adamgrzybowski, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

OSBotify · 2026-05-28T20:40:45Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.88-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

adamgrzybowski requested review from a team as code owners May 26, 2026 12:40

melvin-bot Bot assigned adamgrzybowski May 26, 2026

melvin-bot Bot requested review from JmillsExpensify and ZhenjaHorbach and removed request for a team May 26, 2026 12:40

ZhenjaHorbach approved these changes May 27, 2026

View reviewed changes

melvin-bot Bot requested a review from grgia May 27, 2026 09:20

Merge branch 'main' into @adamgrzybowski/fix-for-you-skeleton-on-reco…

2cd1229

…nnect

grgia approved these changes May 27, 2026

View reviewed changes

grgia merged commit cd9d85c into Expensify:main May 27, 2026
32 checks passed

melvin-bot Bot added the Emergency label May 27, 2026

grgia removed the Emergency label May 27, 2026

OSBotify mentioned this pull request May 27, 2026

Deploy Checklist: New Expensify 2026-05-27 #91866

Closed

75 tasks

melvin-bot Bot mentioned this pull request May 28, 2026

[Due for payment 2026-06-04] [$250] Only show the skeleton loader for Home's For you page on initial load, no subsequent loads #91575

Closed

Conversation

adamgrzybowski commented May 26, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented May 26, 2026

Uh oh!

ZhenjaHorbach commented May 27, 2026

Uh oh!

ZhenjaHorbach commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ZhenjaHorbach commented May 27, 2026

Uh oh!

adamgrzybowski commented May 27, 2026

Uh oh!

ZhenjaHorbach commented May 27, 2026

Uh oh!

Uh oh!

melvin-bot Bot commented May 27, 2026

Uh oh!

grgia commented May 27, 2026

Uh oh!

OSBotify commented May 27, 2026

Uh oh!

github-actions Bot commented May 27, 2026

Uh oh!

github-actions Bot commented May 27, 2026

Uh oh!

OSBotify commented May 27, 2026

Uh oh!

MelvinBot commented May 27, 2026

Uh oh!

OSBotify commented May 28, 2026

Uh oh!

MelvinBot commented May 28, 2026

Uh oh!

OSBotify commented May 28, 2026

Uh oh!

MelvinBot commented May 28, 2026

Uh oh!

OSBotify commented May 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ZhenjaHorbach commented May 27, 2026 •

edited

Loading