Skip to content

[Home Page] Extend Your spend to include third-party cards alongside Expensify Cards#91835

Open
adamgrzybowski wants to merge 2 commits into
Expensify:mainfrom
software-mansion-labs:@adamgrzybowski/your-spend-third-party-cards
Open

[Home Page] Extend Your spend to include third-party cards alongside Expensify Cards#91835
adamgrzybowski wants to merge 2 commits into
Expensify:mainfrom
software-mansion-labs:@adamgrzybowski/your-spend-third-party-cards

Conversation

@adamgrzybowski
Copy link
Copy Markdown
Contributor

@adamgrzybowski adamgrzybowski commented May 27, 2026

Explanation of Change

  • Adds third-party card rows (employer-feed + personal Plaid) to the Your spend section, ordered after Expensify Card rows.
  • Each row shows the bank/institution artwork and the bold total; no remaining-limit doughnut (no credit-limit data from the provider).
  • Broken-feed and broken-connection cards are filtered out via CARD_FEED_ERRORS; the whole slot still hides when no rows apply.

Fixed Issues

$ #91711
PROPOSAL:

Tests

Offline tests

QA Steps

  1. Sign in with an account that has a third-party card (employer feed or Plaid) with transactions in the last 30 days. Verify a Recent transactions • [lastFour] row appears in Your spend with the bank/institution artwork, bold total, and no doughnut. Tap it and verify it opens the matching Spend > Expenses search.
  2. Sign in with an account that has both an Expensify Card and third-party cards. Verify Expensify Card rows appear before third-party rows.
  3. Sign in with an account that has a third-party card in a broken-feed / disconnected state. Verify its row is hidden. Reconnect it and verify the row appears.
  4. Sign in with an account that has only third-party cards with no transactions in the last 30 days. Verify the entire Your spend slot is hidden.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-05-27.at.14.19.38.mov

@adamgrzybowski
Add third-party cards to YourSpend section
64e70b6 
Merges employer-feed and personal Plaid card rows into the YourSpend
hook alongside Expensify cards, tagged with a `YOUR_SPEND_CARD_KIND`
discriminator so `CardRow` can pick the right artwork branch (bank
icon via `feed|domainID` or bare Plaid feed). Adds a new
`getDisplayableThirdPartyCards` selector that filters out broken-feed
and broken-connection cards.
@adamgrzybowski adamgrzybowski requested review from a team as code owners May 27, 2026 12:30
@melvin-bot melvin-bot Bot requested review from ZhenjaHorbach and trjExpensify and removed request for a team and trjExpensify May 27, 2026 12:30
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented May 27, 2026

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@JmillsExpensify JmillsExpensify self-requested a review May 27, 2026 12:39
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 27, 2026

🚧 @JmillsExpensify has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 27, 2026

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #91835.

Android 🤖 iOS 🍎
⏩ SKIPPED ⏩ ⏩ SKIPPED ⏩
The build for Android was skipped The build for iOS was skipped
Web 🕸️
https://91835.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

JmillsExpensify
JmillsExpensify previously approved these changes May 27, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@JmillsExpensify JmillsExpensify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

Image

grgia
grgia reviewed May 27, 2026
View reviewed changes
Comment thread src/components/CardFeedIcon.tsx Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grgia grgia grgia left review comments

@JmillsExpensify JmillsExpensify JmillsExpensify left review comments

@ZhenjaHorbach ZhenjaHorbach Awaiting requested review from ZhenjaHorbach

At least 1 approving review is required to merge this pull request.

Assignees

@adamgrzybowski adamgrzybowski

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adamgrzybowski @JmillsExpensify @grgia