Docs updates for E/A#90978 Update Home Overview for deactivated and pending cards#91869
Docs updates for E/A#90978 Update Home Overview for deactivated and pending cards#91869MelvinBot wants to merge 1 commit into
Conversation
Update the Expensify Home Overview help article to reflect that: - Deactivated and closed Expensify Cards no longer trigger Time-sensitive alerts - Pending-issue and pending-activation cards are excluded from the Assigned cards section Co-authored-by: WojtekBoman <WojtekBoman@users.noreply.github.com>
HelpDot Documentation ReviewOverall AssessmentThis PR updates the Expensify Home Overview article to clarify card visibility rules in the Assigned cards section and refine time-sensitive alert behavior. The changes add specificity around deactivated, pending, and unissued cards. The modifications are small, focused, and well-aligned with the existing article structure. Scores Summary
Key Findings
Recommendations
Files Reviewed
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 35190304b5
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| - There is potential risk, such as suspected Expensify Card fraud on an active card | ||
| - An action must be taken within a short window, such as a limited-time offer or early adoption discount | ||
|
|
||
| Alerts are only shown for active Expensify Cards. Deactivated or closed cards do not trigger time-sensitive alerts. |
There was a problem hiding this comment.
Qualify the card-only time-sensitive alert rule
This sentence now applies the active-card restriction to all Time-sensitive alerts, but the Home implementation still renders non-card alerts such as locked bank accounts, failed billing, broken company/personal card connections, broken accounting connections, and account validation independently of Expensify Card state in src/pages/home/TimeSensitiveSection/index.tsx. In accounts with one of those non-card urgent issues and no active Expensify Card, the section can still appear, so the help article would incorrectly tell users that alerts are only shown for active cards; this should be limited to Expensify Card-related alerts.
Useful? React with 👍 / 👎.
| The **Assigned cards** section only appears if you have an active **Expensify Card** assigned to you. | ||
|
|
||
| If you don’t have an Expensify Card assigned, your assigned card isn’t active, or your card has a custom spending limit of $0, the **Assigned cards** section won’t be visible. | ||
| If you don’t have an Expensify Card assigned, your assigned card isn’t active, your card has a custom spending limit of $0, or your card has not yet been issued or activated, the **Assigned cards** section won’t be visible. |
There was a problem hiding this comment.
Readability / structure: This sentence now chains five conditions with commas, making it hard to scan. Earlier in this same PR (lines 125-128), you converted a similar multi-condition sentence into a bulleted list. Consider applying the same pattern here for consistency and readability:
| If you don’t have an Expensify Card assigned, your assigned card isn’t active, your card has a custom spending limit of $0, or your card has not yet been issued or activated, the **Assigned cards** section won’t be visible. | |
| If you don't have an Expensify Card assigned, the **Assigned cards** section won't be visible. This includes cases where: | |
| - Your assigned card isn't active | |
| - Your card has a custom spending limit of $0 | |
| - Your card has not yet been issued or activated |
Summary
Test plan
@WojtekBoman, please review the files changed and confirm they reflect the current behavior. Then mark this PR
Ready for review.