Skip to content

Docs updates for E/A#90978 Update Home Overview for deactivated and pending cards#91869

Open
MelvinBot wants to merge 1 commit into
mainfrom
docs/hide-deactivated-cards-home
Open

Docs updates for E/A#90978 Update Home Overview for deactivated and pending cards#91869
MelvinBot wants to merge 1 commit into
mainfrom
docs/hide-deactivated-cards-home

Conversation

@MelvinBot
Copy link
Copy Markdown
Contributor

Summary

  • Updates the Expensify Home Overview help article to reflect code changes from fix: hide deactivated cards from Time Sensitive section #90978
  • Documents that deactivated and closed Expensify Cards no longer trigger Time-sensitive alerts (fraud, shipping, activation to-dos)
  • Documents that pending-issue and pending-activation cards are excluded from the Assigned cards section on Home
  • Updates the FAQ answer for "Why don't I see the Assigned cards section?" to include pending card states

Test plan

@WojtekBoman, please review the files changed and confirm they reflect the current behavior. Then mark this PR Ready for review.

Update the Expensify Home Overview help article to reflect that:
- Deactivated and closed Expensify Cards no longer trigger Time-sensitive alerts
- Pending-issue and pending-activation cards are excluded from the Assigned cards section

Co-authored-by: WojtekBoman <WojtekBoman@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label May 27, 2026
@stephanieelliott stephanieelliott marked this pull request as ready for review May 29, 2026 01:25
@stephanieelliott stephanieelliott self-requested a review as a code owner May 29, 2026 01:25
@github-actions
Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR updates the Expensify Home Overview article to clarify card visibility rules in the Assigned cards section and refine time-sensitive alert behavior. The changes add specificity around deactivated, pending, and unissued cards. The modifications are small, focused, and well-aligned with the existing article structure.

Scores Summary

  • Readability: 9/10 - The changes are clear, scannable, and use consistent bullet-point formatting. The conversion of a single sentence into a bulleted list for excluded card types improves scannability. The final FAQ sentence is slightly long but remains understandable.
  • AI Readiness: 9/10 - New keywords (deactivated card, pending card, card activation) are added to the YAML metadata, improving search coverage. The internalScope remains accurate. No heading changes were needed since this is content-level refinement.
  • Style Compliance: 10/10 - UI terms like Expensify Card, Assigned cards, and Time-sensitive alerts are bolded correctly and match existing conventions. No prohibited language is introduced. Terminology is precise and consistent with the naming conventions guide.

Key Findings

  • The addition of three new keywords to the YAML frontmatter is a good practice for AI retrieval, covering the new card states discussed in the content.
  • The bullet-list refactor for excluded card types (replacing a single sentence) follows the scannability principle well and is easier to parse than the prior prose.
  • The phrase "on an active card" added to the fraud alert bullet is a helpful precision improvement that aligns with the new clarification about deactivated cards.
  • The new standalone sentence "Alerts are only shown for active Expensify Cards. Deactivated or closed cards do not trigger time-sensitive alerts." reinforces the behavior clearly without disrupting the existing flow.
  • The final FAQ answer grows slightly longer with the added conditions but remains a single coherent sentence.

Recommendations

  • No blocking issues. The changes are production-ready.
  • Minor consideration: The last sentence in the FAQ section could be broken into a bulleted list for consistency with the pattern used earlier in the article (the "Cards that are not shown" list), but this is a stylistic preference rather than a governance violation.

Files Reviewed

  • docs/articles/new-expensify/getting-started/Expensify-Home-Overview.md - Content updates to Time-sensitive alerts and Assigned cards sections, plus YAML keyword additions. All changes comply with governance standards.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 35190304b5

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

- There is potential risk, such as suspected Expensify Card fraud on an active card
- An action must be taken within a short window, such as a limited-time offer or early adoption discount

Alerts are only shown for active Expensify Cards. Deactivated or closed cards do not trigger time-sensitive alerts.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Qualify the card-only time-sensitive alert rule

This sentence now applies the active-card restriction to all Time-sensitive alerts, but the Home implementation still renders non-card alerts such as locked bank accounts, failed billing, broken company/personal card connections, broken accounting connections, and account validation independently of Expensify Card state in src/pages/home/TimeSensitiveSection/index.tsx. In accounts with one of those non-card urgent issues and no active Expensify Card, the section can still appear, so the help article would incorrectly tell users that alerts are only shown for active cards; this should be limited to Expensify Card-related alerts.

Useful? React with 👍 / 👎.

The **Assigned cards** section only appears if you have an active **Expensify Card** assigned to you.

If you don’t have an Expensify Card assigned, your assigned card isn’t active, or your card has a custom spending limit of $0, the **Assigned cards** section won’t be visible.
If you don’t have an Expensify Card assigned, your assigned card isn’t active, your card has a custom spending limit of $0, or your card has not yet been issued or activated, the **Assigned cards** section won’t be visible.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readability / structure: This sentence now chains five conditions with commas, making it hard to scan. Earlier in this same PR (lines 125-128), you converted a similar multi-condition sentence into a bulleted list. Consider applying the same pattern here for consistency and readability:

Suggested change
If you dont have an Expensify Card assigned, your assigned card isn’t active, your card has a custom spending limit of $0, or your card has not yet been issued or activated, the **Assigned cards** section wont be visible.
If you don't have an Expensify Card assigned, the **Assigned cards** section won't be visible. This includes cases where:
- Your assigned card isn't active
- Your card has a custom spending limit of $0
- Your card has not yet been issued or activated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants