[Payment due @ahmedGaber93] Redirect to Expensify Classic directly from the exit survey reason page by allgandalf · Pull Request #91924 · Expensify/App

allgandalf · 2026-05-28T05:59:51Z

Explanation of Change

Follow-up to #89163, based on trj's comment asking whether we still need the second page in the Switch to Expensify Classic flow.

After the picker shipped, a dismissed: false user who clicks "Switch to Expensify Classic" on the reason page lands on DynamicExitSurveyConfirmPage (the "Thanks for the feedback" screen) and has to click "Switch to Expensify Classic" again before the redirect happens. That second click is redundant now that the reason page is the decision point.

This PR makes the reason page redirect straight to OldDot. The redirect logic that used to live on the confirm page button (switchToOldDot + dismissModal + openOldDotLink) now runs directly from the reason page's "Switch to Expensify Classic" button, so the survey path no longer routes through the confirm page.

The confirm page is kept. It is still reached by the "Quick tip" path, which a dismissed: true user hits when they come back to NewDot 30+ days after switching and click "Switch to Expensify Classic" again (hasBeenInNewDot30Days only hides the button for dismissed: false users, so dismissed: true users still see it and land on the quick-tip screen). That path does not involve a survey selection, so it is out of scope of trj's question and is left untouched.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/626358
PROPOSAL: N/A (internal work, follow-up requested on the issue thread)

Tests

Setup snippet to run in the DevTools console to put the test account into dismissed: false:

Onyx.merge('nvp_tryNewDot', {nudgeMigration: {timestamp: '2026-04-01 12:00:00'}, classicRedirect: {dismissed: false, timestamp: '2026-04-01 12:00:00'}});

Helper to read the NVP back:

Onyx.get('nvp_tryNewDot').then(v => console.log('dismissed:', v?.classicRedirect?.dismissed));

Sign in to NewDot on web. Run the setup snippet.
Open Settings and click "Switch to Expensify Classic". You should land on the reason page with the two buttons.
Type a reason, then click "Switch to Expensify Classic".
You should be taken straight to OldDot at expensify.com/inbox. There should be no "Thanks for the feedback" page in between.
Run the read helper. It should log true.
Run the setup snippet again, open the reason page, and click "Go back just once".
You should be taken straight to OldDot, and the read helper should still log false (no NVP write).
Confirm the survey path no longer shows a "Thanks for the feedback" page.

Quick-tip path is unchanged and should still work:
9. Run Onyx.merge('nvp_tryNewDot', {nudgeMigration: {timestamp: '2026-01-01 12:00:00'}, classicRedirect: {dismissed: true, timestamp: '2026-01-01 12:00:00'}}); to simulate a user who switched over a month ago.
10. Open Settings and click "Switch to Expensify Classic". You should still see the "Quick tip" screen, then "Take me to Expensify Classic" takes you to OldDot.

Verify that no errors appear in the JS console

Offline tests

On web with dismissed: false, open the reason page and toggle DevTools Network to Offline. Both buttons should be disabled. Toggle back online and they re-enable.

QA Steps

Same as the Tests section, using the Onyx.merge setup snippet on staging.

Verify that no errors appear in the JS console

PR Author Checklist

Screen.Recording.2026-05-28.at.12.11.53.PM.mov

melvin-bot · 2026-05-28T05:59:57Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

This reverts commit 10e8b17.

This reverts commit 623de48.

This reverts commit 5de5a28.

This reverts commit 63fd7d7.

melvin-bot · 2026-05-28T06:39:45Z

@Ollyws Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allgandalf · 2026-05-28T06:40:40Z

@ahmedGaber93 this is a follow up to the PR, we don't want to show the thank you screen after entering the reason

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8534386fb8

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

codecov · 2026-05-28T06:54:48Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...ettings/ExitSurvey/DynamicExitSurveyReasonPage.tsx	`0.00% <0.00%> (ø)`
... and 7 files with indirect coverage changes

allgandalf · 2026-05-28T09:10:00Z

@codex review

chatgpt-codex-connector · 2026-05-28T09:13:06Z

Codex Review: Didn't find any major issues. Can't wait for the next one!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

trjExpensify

Thanks for the quick work! 👍

ahmedGaber93 · 2026-05-29T12:15:45Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-05-29.at.7.52.45.PM.mov

Android: mWeb Chrome

Screen.Recording.2026-05-29.at.4.49.26.PM.mov

iOS: HybridApp

Failed to install the iOS App, but it should function as expected since this new flow is exclusively web-based.

iOS: mWeb Safari

Screen.Recording.2026-05-29.at.4.26.32.PM.mov

Screen.Recording.2026-05-29.at.4.18.49.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2026-05-29.at.4.14.52.PM.mov

ahmedGaber93 · 2026-05-29T13:21:20Z

    const {top: safeAreaInsetsTop} = useSafeAreaInsets();

-    const submitForm = useCallback(() => {
-        saveResponse(draftResponse);


nit: saveResponse doesn’t look like it’s used anywhere else, so we can remove it.

ahmedGaber93

NAB: Small cleanup comment #91924 (comment)
@allgandalf

melvin-bot · 2026-05-29T16:57:38Z

🎯 @ahmedGaber93, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/626358.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.

allgandalf added 5 commits May 28, 2026 11:24

Redirect straight to OldDot from the exit survey reason page

3b97c15

Redirect straight to OldDot from Settings classic-redirect

63fd7d7

Redirect straight to OldDot from Troubleshoot classic-redirect

5de5a28

Remove the exit survey confirm page and its registration

623de48

Remove unused exit survey confirm translations

10e8b17

melvin-bot Bot assigned allgandalf May 28, 2026

allgandalf requested review from ahmedGaber93, puneetlath and trjExpensify May 28, 2026 06:07

allgandalf added 4 commits May 28, 2026 11:56

Revert "Remove unused exit survey confirm translations"

7fb18db

This reverts commit 10e8b17.

Revert "Remove the exit survey confirm page and its registration"

e316d77

This reverts commit 623de48.

Revert "Redirect straight to OldDot from Troubleshoot classic-redirect"

c6ee7e6

This reverts commit 5de5a28.

Revert "Redirect straight to OldDot from Settings classic-redirect"

8534386

This reverts commit 63fd7d7.

allgandalf changed the title ~~Remove the exit survey confirm page and redirect to Classic directly~~ Redirect to Expensify Classic directly from the exit survey reason page May 28, 2026

allgandalf marked this pull request as ready for review May 28, 2026 06:39

allgandalf requested review from a team as code owners May 28, 2026 06:39

melvin-bot Bot requested a review from Ollyws May 28, 2026 06:39

melvin-bot Bot removed request for a team May 28, 2026 06:39

allgandalf removed the request for review from Ollyws May 28, 2026 06:40

chatgpt-codex-connector Bot reviewed May 28, 2026

View reviewed changes

Comment thread src/pages/settings/ExitSurvey/DynamicExitSurveyReasonPage.tsx

Disable Ctrl+Enter switch shortcut while offline

5f20523

trjExpensify approved these changes May 28, 2026

View reviewed changes

ahmedGaber93 reviewed May 29, 2026

View reviewed changes

ahmedGaber93 approved these changes May 29, 2026

View reviewed changes

melvin-bot Bot changed the title ~~Redirect to Expensify Classic directly from the exit survey reason page~~ [Payment due @ahmedGaber93] Redirect to Expensify Classic directly from the exit survey reason page May 29, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Payment due @ahmedGaber93] Redirect to Expensify Classic directly from the exit survey reason page#91924

[Payment due @ahmedGaber93] Redirect to Expensify Classic directly from the exit survey reason page#91924
allgandalf wants to merge 10 commits into
Expensify:mainfrom
allgandalf:remove-exit-survey-confirm-page

allgandalf commented May 28, 2026 •

edited

Loading

Uh oh!

melvin-bot Bot commented May 28, 2026

Uh oh!

melvin-bot Bot commented May 28, 2026

Uh oh!

allgandalf commented May 28, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

codecov Bot commented May 28, 2026 •

edited by github-actions Bot

Loading

Uh oh!

allgandalf commented May 28, 2026

Uh oh!

chatgpt-codex-connector Bot commented May 28, 2026

Uh oh!

trjExpensify left a comment

Uh oh!

ahmedGaber93 commented May 29, 2026 •

edited

Loading

Uh oh!

ahmedGaber93 May 29, 2026

Uh oh!

ahmedGaber93 left a comment

Uh oh!

melvin-bot Bot commented May 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

allgandalf commented May 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Uh oh!

melvin-bot Bot commented May 28, 2026

Uh oh!

melvin-bot Bot commented May 28, 2026

Uh oh!

allgandalf commented May 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

codecov Bot commented May 28, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

allgandalf commented May 28, 2026

Uh oh!

chatgpt-codex-connector Bot commented May 28, 2026

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

ahmedGaber93 commented May 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ahmedGaber93 May 29, 2026

Choose a reason for hiding this comment

Uh oh!

ahmedGaber93 left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented May 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

allgandalf commented May 28, 2026 •

edited

Loading

allgandalf commented May 28, 2026 •

edited

Loading

codecov Bot commented May 28, 2026 •

edited by github-actions Bot

Loading

ahmedGaber93 commented May 29, 2026 •

edited

Loading