Public room not display in LHN after anon user login from a thread of public room#91931
Public room not display in LHN after anon user login from a thread of public room#91931nkdengineer wants to merge 5 commits into
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3049ade856
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| RAM_ONLY_IS_CHECKING_PUBLIC_ROOM: 'isCheckingPublicRoom', | ||
|
|
||
| /** The report ID of the public room that the user is currently viewing */ | ||
| RAM_ONLY_VIEWING_PUBLIC_ROOM_REPORT_ID: 'ramOnlyViewingPublicRoomReportID', |
There was a problem hiding this comment.
Register the viewing public room key as RAM-only
This new key is named and used as transient state, but it is not added to ramOnlyKeys in src/setup/index.ts (I checked the Onyx init list there). As a result, the last public room ID can be persisted across reloads/sessions, and joinPublicRoomIfNeeded() may later call openReport() for a stale room when an anonymous user signs in from an unrelated route. Please add this key to the Onyx RAM-only configuration or otherwise clear it after use.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
I renamed the key. And this is cleared when we sign out and only set for anonymous user so it's safe.

Explanation of Change
Public room not display in LHN after anon user login from a thread of public room
Fixed Issues
$ #90536
PROPOSAL: #90536 (comment)
Tests
Offline tests
QA Steps
Same as test
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-05-28.at.15.14.17.mov
Android: mWeb Chrome
Screen.Recording.2026-05-28.at.15.20.15.mov
iOS: Native
iOS: mWeb Safari
Screen.Recording.2026-05-28.at.15.18.46.mov
MacOS: Chrome / Safari
Screen.Recording.2026-05-28.at.15.12.10.mov