remove avatar border for delegate avatar by NicolasBonet · Pull Request #91987 · Expensify/App

NicolasBonet · 2026-05-28T15:45:51Z

Explanation of Change

Removes the avatar border when we are using copilot

Fixed Issues

$ #91904
PROPOSAL:#91904

Tests

Copilot into an account
Check that the avatar border (the ring) has the same color as the background
Go hover the account section and see if the color remains the same as the background (darker now)
Toggle the dark mode setting and repeat the same steps to verify in works with both.

Verify that no errors appear in the JS console

Offline tests

None

QA Steps

Same as tests
// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

MacOS: Chrome / Safari

melvin-bot · 2026-05-28T15:48:25Z

@ChavdaSachin Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 698576cd17

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

ChavdaSachin · 2026-05-28T16:08:54Z

@NicolasBonet, it seems you have linked the wrong issue in the PR description.
Could you please recheck?

NicolasBonet · 2026-05-28T16:52:58Z

@NicolasBonet, it seems you have linked the wrong issue in the PR description. Could you please recheck?

Done!

codecov · 2026-05-28T17:02:26Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/pages/inbox/sidebar/NavigationTabBarAvatar.tsx	`91.30% <100.00%> (ø)`
src/styles/index.ts	`59.06% <ø> (ø)`
...c/pages/inbox/sidebar/AvatarWithDelegateAvatar.tsx	`0.00% <0.00%> (ø)`
... and 5 files with indirect coverage changes

shawnborton · 2026-05-28T18:10:42Z

I think we want the border, but the border should just always match the background color - even when you hover.

- Introduced `isHovered` prop to AvatarWithDelegateAvatar for hover state management. - Updated NavigationTabBarAvatar to pass hover state to AvatarWithDelegateAvatar. - Adjusted sidebar status avatar dimensions and added hover styles in the stylesheet.

NicolasBonet · 2026-05-28T19:43:29Z

I think we want the border, but the border should just always match the background color - even when you hover.

@shawnborton Oh got it, the problem is the BG when hovered, this is how it looks now:

Screen.Recording.2026-05-28.at.2.42.29.PM.mov

shawnborton · 2026-05-28T19:46:14Z

Nice, I think that fixes it!

melvin-bot · 2026-05-28T20:11:12Z

@dubielzyk-expensify @eVoloshchak One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ChavdaSachin · 2026-05-28T21:47:04Z

@Expensify/design

.	before	after
Hovered
Regular (unchanged)

But the style for the avatar with emoji status is unchanged.
Do we need to apply the same style to the avatar with an emoji status as well?

Hovered	Regular

dubielzyk-expensify · 2026-05-29T00:56:57Z

Do we need to apply the same style to the avatar with an emoji status as well?

I don't mind what's there today with having a background color. Curious what @Expensify/design thinks. I think it might be better to contain with a background color so basically leaving it alone.

shawnborton · 2026-05-29T07:23:02Z

Totally agree with that.

dannymcclain · 2026-05-29T12:10:55Z

Same!

NicolasBonet · 2026-05-29T14:21:36Z

Cool, @eVoloshchak could you check this, please?

ChavdaSachin · 2026-05-29T15:16:44Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

ChavdaSachin

LGTM! ✅

melvin-bot · 2026-05-29T15:20:53Z

@dangrous Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-05-29T18:49:39Z

@dubielzyk-expensify @aimane-chnaif One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shawnborton · 2026-05-29T18:50:16Z

Hmm didn't mean to assign you @aimane-chnaif. We need an internal engineer to pick this up. Maybe @ChavdaSachin has to approve again?

ChavdaSachin

Approved

melvin-bot · 2026-05-29T18:52:14Z

@inimaga Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

parasharrajat · 2026-05-30T07:17:47Z

I was supposed to review this as it was a follow-up but I was not tagged.

parasharrajat · 2026-05-30T07:19:06Z

We have to check for other issues as well, which are mentioned in the issue description #91904 (comment)

melvin-bot Bot assigned NicolasBonet May 28, 2026

NicolasBonet mentioned this pull request May 28, 2026

Agent AI Prompt section: design polish follow-ups #91904

Open

NicolasBonet marked this pull request as ready for review May 28, 2026 15:48

NicolasBonet requested review from a team as code owners May 28, 2026 15:48

melvin-bot Bot requested review from ChavdaSachin and trjExpensify and removed request for a team and ChavdaSachin May 28, 2026 15:48

chatgpt-codex-connector Bot reviewed May 28, 2026

View reviewed changes

Comment thread src/styles/index.ts Outdated

NicolasBonet added 2 commits May 28, 2026 14:08

Adjust sidebar status avatar dimensions and positioning in styles

982a9f1

NicolasBonet force-pushed the fix/91904-change-delegate-avatar-border branch from 698576c to ce71ad1 Compare May 28, 2026 19:40

NicolasBonet requested a review from a team May 28, 2026 20:11

melvin-bot Bot requested review from dubielzyk-expensify and eVoloshchak and removed request for a team May 28, 2026 20:11

ChavdaSachin approved these changes May 29, 2026

View reviewed changes

melvin-bot Bot requested a review from dangrous May 29, 2026 15:20

shawnborton requested review from a team and removed request for dangrous May 29, 2026 18:49

melvin-bot Bot requested review from aimane-chnaif and removed request for a team May 29, 2026 18:49

shawnborton removed the request for review from aimane-chnaif May 29, 2026 18:50

ChavdaSachin approved these changes May 29, 2026

View reviewed changes

melvin-bot Bot requested a review from inimaga May 29, 2026 18:52

Conversation

NicolasBonet commented May 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented May 28, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

ChavdaSachin commented May 28, 2026

Uh oh!

NicolasBonet commented May 28, 2026

Uh oh!

codecov Bot commented May 28, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

shawnborton commented May 28, 2026

Uh oh!

NicolasBonet commented May 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shawnborton commented May 28, 2026

Uh oh!

melvin-bot Bot commented May 28, 2026

Uh oh!

ChavdaSachin commented May 28, 2026

Uh oh!

dubielzyk-expensify commented May 29, 2026

Uh oh!

shawnborton commented May 29, 2026

Uh oh!

dannymcclain commented May 29, 2026

Uh oh!

NicolasBonet commented May 29, 2026

Uh oh!

ChavdaSachin commented May 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ChavdaSachin left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented May 29, 2026

Uh oh!

melvin-bot Bot commented May 29, 2026

Uh oh!

shawnborton commented May 29, 2026

Uh oh!

ChavdaSachin left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented May 29, 2026

Uh oh!

parasharrajat commented May 30, 2026

Uh oh!

parasharrajat commented May 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

NicolasBonet commented May 28, 2026 •

edited

Loading

codecov Bot commented May 28, 2026 •

edited by github-actions Bot

Loading

NicolasBonet commented May 28, 2026 •

edited

Loading

ChavdaSachin commented May 29, 2026 •

edited

Loading