[Payment due @Eskalifer1] [NO QA] Remove non-functional QBD Continuous Reconciliation UX by blimpich · Pull Request #92004 · Expensify/App

blimpich · 2026-05-28T17:21:16Z

Explanation of Change

QuickBooks Desktop workspaces with a fully set up Expensify Card surfaced a "Card reconciliation" entry that let admins toggle Continuous Reconciliation on. Auth stored the resulting NVPs, but Integration-Server has no QBD sync service to consume them — the toggle was a no-op. Confirmed in this Slack thread that QBD is not a supported integration for Continuous Reconciliation.

This PR removes the entry point, route, page, and navigation registration for QBD card reconciliation so admins are no longer misled into thinking their Expensify Card transactions are reconciling against QBD. The four integrations that actually support Continuous Reconciliation (QBO, Xero, NetSuite, Sage Intacct) are untouched.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/642122
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console

Offline tests

N/A — change is purely navigation/UX and does not interact with the network.

QA Steps

[NO QA] — this PR removes a non-functional admin toggle; there is no positive user-facing flow being added or modified.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Extra context

Integration-Server only ships *ExpensifyCardSyncService.java implementations for QBO, Xero, NetSuite, and Sage Intacct; no QuickbooksDesktopExpensifyCardSyncService exists. The same backend gap is noted in Expensify#641405 for the Travel Invoicing CR work.

Out of scope for this PR (follow-ups if needed):

Auth's ToggleCardContinuousReconciliation still accepts the connection name as opaque free text — any QBD policies that already toggled this on have a dormant no-op NVP.
Deep-linking to workspaces/<policyID>/accounting/card-reconciliation?connection=quickbooksDesktop still renders the parent reconciliation page; the menu entry point is gone.

– written by Claude on Ben's behalf

…SYNC route

codecov · 2026-05-28T17:41:56Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/ROUTES.ts	`18.27% <ø> (+0.06%)`	⬆️
src/SCREENS.ts	`100.00% <ø> (ø)`
...gation/AppNavigator/ModalStackNavigators/index.tsx	`6.96% <ø> (+<0.01%)`	⬆️
...gation/linkingConfig/RELATIONS/WORKSPACE_TO_RHP.ts	`100.00% <ø> (ø)`
src/libs/Navigation/linkingConfig/config.ts	`76.92% <ø> (ø)`
...counting/reconciliation/CardReconciliationPage.tsx	`0.00% <ø> (ø)`
src/pages/workspace/accounting/utils.tsx	`0.00% <ø> (ø)`
...ages/workspace/accounting/PolicyAccountingPage.tsx	`0.00% <0.00%> (ø)`
... and 5 files with indirect coverage changes

melvin-bot · 2026-05-28T17:47:38Z

@Eskalifer1 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 05eca98c08

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Eskalifer1 · 2026-05-28T19:09:17Z

Reviewing now!

Eskalifer1 · 2026-05-28T20:04:13Z

Hi @blimpich I'm having trouble installing QBD on my Mac. Judging by the descriptions of similar issues posted by other contributors on Slack, installing it isn't exactly easy—it's a real nightmare)))

Would it be possible for you to just add my account to an existing Workspace that already has QBD?

in case that's possible my email is: artemkryt1800+test1@gmail.com

Eskalifer1 · 2026-05-28T20:06:26Z

                          shouldShowRightIcon: true,
                          title: translate('workspace.accounting.cardReconciliation'),
                          wrapperStyle: [styles.sectionMenuItemTopDescription],
                          onPress: integrationData?.onCardReconciliationPagePress,


I think The ?. is redundant - the spread condition on line 432 already guards that integrationData?.onCardReconciliationPagePress is truthy, so inside the ? [...] branch it's guaranteed to be defined.

Agreed, but does keeping it hurt us at all you think?

No, I don't think it's a problem if we leave it as is. It won't change anything—it's just a minor improvement. We can skip it if you think so.

Eskalifer1 · 2026-05-28T20:19:19Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

video_2026-05-29_13-23-28.mp4

Android: mWeb Chrome

92004-android-web.mov

iOS: HybridApp

2026-05-29.11.44.03.mov

iOS: mWeb Safari

92004-ios-web.mov

MacOS: Chrome / Safari

92004-web.mov

blimpich · 2026-05-28T20:35:49Z

Hi @blimpich I'm having trouble installing QBD on my Mac. Judging by the descriptions of similar issues posted by other contributors on Slack, installing it isn't exactly easy—it's a real nightmare)))

Would it be possible for you to just add my account to an existing Workspace that already has QBD?

Yeah it's not as simple as the other connections. Unfortunately I don't have a account with an existing QBD connection. Are you able to follow this StackOverflow article? It also looks like @ahmedGaber93 was able to get a connection on this PR, so maybe ask them if that SO doesn't work?

Eskalifer1 · 2026-05-28T20:40:21Z

Yeah it's not as simple as the other connections. Unfortunately I don't have a account with an existing QBD connection.

Oh, okay, I thought you might have had that so as not to bother the other C+ :)

Sure, I'll message him on Slack

Eskalifer1 · 2026-05-28T20:43:20Z

Asked here

ahmedGaber93 · 2026-05-28T21:42:35Z

@Eskalifer1 I added you as admin to Test's Workspace 13. Not sure if you can test this PR with it since I only created initial QBD acount.
If you need to change any settings in the QBD file, I can send you the credentials so you can set them up yourself.

Eskalifer1

I have tested!

LGTM!

melvin-bot · 2026-05-29T10:25:05Z

@cead22 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-05-29T10:25:07Z

🎯 @Eskalifer1, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/642122.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.

Eskalifer1 · 2026-05-29T10:48:06Z

Sorry @cead22. This is already approved. Idk why Melvin asked for review

github-actions · 2026-05-29T18:08:48Z

🚧 @cead22 has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-05-29T18:13:36Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #92004.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-fe174bc428d-2a3bd36-40a269528418172bee5b3d5a2c266caf47af33af/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-fe174bc-2a3bd36-9e99f0778de8f7435ec5b2b63a5e28c767441523/index.html

Web 🕸️
https://92004.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-29T18:15:43Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

blimpich added 10 commits May 28, 2026 10:13

Make onCardReconciliationPagePress optional on AccountingIntegration

c4186db

Gate Card reconciliation menu item on per-integration handler presence

0595476

Remove QBD Card reconciliation menu entry

17f5bd6

Drop QBD case from Card reconciliation auto-sync link switch

e9b5122

Drop QBD Card reconciliation screen from RHP relations

d8e1958

Drop QBD Card reconciliation entry from linking config

8359b1d

Drop QBD Card reconciliation modal stack registration

7a76a0a

Delete unreferenced CardReconciliationQuickbooksDesktopAutoSyncPage

d17e8f7

Remove POLICY_ACCOUNTING_CARD_RECONCILIATION_QUICKBOOKS_DESKTOP_AUTO_…

7cf6714

…SYNC route

Remove CARD_RECONCILIATION_QUICKBOOKS_DESKTOP_AUTO_SYNC screen constant

05eca98

melvin-bot Bot assigned blimpich May 28, 2026

blimpich marked this pull request as ready for review May 28, 2026 17:47

blimpich requested review from a team as code owners May 28, 2026 17:47

melvin-bot Bot requested review from Eskalifer1 and joekaufmanexpensify and removed request for a team May 28, 2026 17:47

melvin-bot Bot removed the request for review from a team May 28, 2026 17:47

chatgpt-codex-connector Bot reviewed May 28, 2026

View reviewed changes

Comment thread src/pages/workspace/accounting/PolicyAccountingPage.tsx

Eskalifer1 reviewed May 28, 2026

View reviewed changes

Eskalifer1 approved these changes May 29, 2026

View reviewed changes

melvin-bot Bot requested a review from cead22 May 29, 2026 10:25

melvin-bot Bot changed the title ~~[NO QA] Remove non-functional QBD Continuous Reconciliation UX~~ [Payment due @Eskalifer1] [NO QA] Remove non-functional QBD Continuous Reconciliation UX May 29, 2026

cead22 approved these changes May 29, 2026

View reviewed changes

cead22 merged commit fe174bc into main May 29, 2026
72 of 78 checks passed

cead22 deleted the blimpich-removeQbdContinuousReconciliationUx branch May 29, 2026 18:06

Conversation

blimpich commented May 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented May 28, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented May 28, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Eskalifer1 commented May 28, 2026

Uh oh!

Eskalifer1 commented May 28, 2026

Uh oh!

Eskalifer1 May 28, 2026

Choose a reason for hiding this comment

Uh oh!

blimpich May 28, 2026

Choose a reason for hiding this comment

Uh oh!

Eskalifer1 May 28, 2026

Choose a reason for hiding this comment

Uh oh!

Eskalifer1 commented May 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

blimpich commented May 28, 2026

Uh oh!

Eskalifer1 commented May 28, 2026

Uh oh!

Eskalifer1 commented May 28, 2026

Uh oh!

ahmedGaber93 commented May 28, 2026

Uh oh!

Eskalifer1 left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented May 29, 2026

Uh oh!

melvin-bot Bot commented May 29, 2026

Uh oh!

Eskalifer1 commented May 29, 2026

Uh oh!

Uh oh!

github-actions Bot commented May 29, 2026

Uh oh!

github-actions Bot commented May 29, 2026

Uh oh!

OSBotify commented May 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

blimpich commented May 28, 2026 •

edited

Loading

codecov Bot commented May 28, 2026 •

edited by github-actions Bot

Loading

Eskalifer1 commented May 28, 2026 •

edited

Loading