[NO QA] Simplify expense details message in English language file#92025
Open
jamesdeanexpensify wants to merge 2 commits into
Open
[NO QA] Simplify expense details message in English language file#92025jamesdeanexpensify wants to merge 2 commits into
jamesdeanexpensify wants to merge 2 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
@MelvinBot apply the Polyglot Parrot translations |
Contributor
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index a1428306253..dd439a4192a 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -1257,7 +1257,7 @@ const translations: TranslationDeepObject<typeof en> = {
pendingMatchSubmitTitle: 'Bericht einreichen',
pendingMatchSubmitDescription: 'Einige Ausgaben warten auf die Zuordnung mit einer Kreditkartentransaktion. Möchten Sie sie als Bar markieren?',
routePending: 'Routing ausstehend ...',
- automaticallyEnterExpenseDetails: 'Concierge wird automatisch die Ausgabendetails für Sie eingeben, oder Sie können sie manuell hinzufügen.',
+ automaticallyEnterExpenseDetails: 'Concierge füllt die Details für Sie aus.',
receiptScanning: () => ({
one: 'Beleg wird gescannt ...',
other: 'Belege werden gescannt …',
diff --git a/src/languages/es.ts b/src/languages/es.ts
index 49c6c41c353..3bceabea196 100644
--- a/src/languages/es.ts
+++ b/src/languages/es.ts
@@ -1224,7 +1224,7 @@ const translations: TranslationDeepObject<typeof en> = {
other: 'Problemas encontrados',
}),
fieldPending: 'Pendiente...',
- automaticallyEnterExpenseDetails: 'Concierge introducirá automáticamente los detalles del gasto por ti, o puedes añadirlos manualmente.',
+ automaticallyEnterExpenseDetails: 'Concierge completará los detalles por ti.',
receiptScanning: () => ({
one: 'Escaneando recibo...',
other: 'Escaneando recibos...',
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index 28fa0270c5c..c403a209c19 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -1261,7 +1261,7 @@ const translations: TranslationDeepObject<typeof en> = {
pendingMatchSubmitTitle: 'Soumettre le rapport',
pendingMatchSubmitDescription: 'Certaines dépenses sont en attente de rapprochement avec une transaction par carte de crédit. Voulez-vous les marquer comme espèces ?',
routePending: 'Acheminement en attente...',
- automaticallyEnterExpenseDetails: 'Concierge saisira automatiquement les détails de la dépense pour vous, ou vous pouvez les ajouter manuellement.',
+ automaticallyEnterExpenseDetails: 'Concierge remplira les détails pour vous.',
receiptScanning: () => ({
one: 'Scan des reçus...',
other: 'Scan des reçus...',
@@ -2814,9 +2814,9 @@ ${amount} pour ${merchant} - ${date}`,
title: 'Modifier l’agent',
agentName: 'Nom de l’agent',
instructions: 'Écrire des instructions personnalisées',
- chatWithAgent: 'Discuter avec l\u2019agent',
+ chatWithAgent: 'Discuter avec l’agent',
copilotIntoAccount: 'Copilote dans le compte',
- deleteAgent: 'Supprimer l\u2019agent',
+ deleteAgent: 'Supprimer l’agent',
deleteAgentTitle: 'Supprimer l’agent ?',
deleteAgentMessage: 'Voulez-vous vraiment supprimer cet agent ? Cette action est irréversible.',
},
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 8ab6b4ea1ee..2b75aa07051 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -1257,7 +1257,7 @@ const translations: TranslationDeepObject<typeof en> = {
pendingMatchSubmitTitle: 'Invia report',
pendingMatchSubmitDescription: 'Alcune spese sono in attesa di abbinamento con una transazione della carta di credito. Vuoi segnarle come contante?',
routePending: 'Instradamento in sospeso...',
- automaticallyEnterExpenseDetails: 'Concierge inserirà automaticamente i dettagli della spesa per te, oppure puoi aggiungerli manualmente.',
+ automaticallyEnterExpenseDetails: 'Concierge compilerà i dettagli per te.',
receiptScanning: () => ({
one: 'Scansione della ricevuta in corso...',
other: 'Scansione delle ricevute in corso...',
@@ -2802,8 +2802,8 @@ ${amount} per ${merchant} - ${date}`,
title: 'Modifica agente',
agentName: 'Nome agente',
instructions: 'Scrivi istruzioni personalizzate',
- chatWithAgent: 'Chatta con l\u2019agente',
- copilotIntoAccount: 'Copilot nell\u2019account',
+ chatWithAgent: 'Chatta con l’agente',
+ copilotIntoAccount: 'Copilot nell’account',
deleteAgent: 'Elimina agente',
deleteAgentTitle: 'Eliminare agente?',
deleteAgentMessage: 'Sei sicuro di voler eliminare questo agente? Questa azione non può essere annullata.',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index c2cd656b7a3..30b436d6be7 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -1243,7 +1243,7 @@ const translations: TranslationDeepObject<typeof en> = {
pendingMatchSubmitTitle: 'レポートを提出',
pendingMatchSubmitDescription: '一部の経費がクレジットカード取引との照合待ちです。現金としてマークしますか？',
routePending: 'ルート保留中…',
- automaticallyEnterExpenseDetails: 'コンシェルジュが自動的に経費の詳細を入力するか、手動で追加することができます。',
+ automaticallyEnterExpenseDetails: 'Concierge が詳細を入力します。',
receiptScanning: () => ({
one: 'レシートをスキャンしています…',
other: 'レシートをスキャンしています…',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 6a1181594d1..18d6aac0a6a 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -1255,7 +1255,7 @@ const translations: TranslationDeepObject<typeof en> = {
pendingMatchSubmitTitle: 'Rapport indienen',
pendingMatchSubmitDescription: 'Sommige uitgaven wachten op koppeling met een creditcardtransactie. Wilt u ze als contant markeren?',
routePending: 'Routeren in behandeling...',
- automaticallyEnterExpenseDetails: 'Concierge zal automatisch de uitgavendetails voor je invoeren, of je kunt ze handmatig toevoegen.',
+ automaticallyEnterExpenseDetails: 'Concierge vult de gegevens voor je in.',
receiptScanning: () => ({
one: 'Bon wordt gescand...',
other: 'Bonnetjes scannen...',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index a7140cf7275..e741ad3b4b6 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -1255,7 +1255,7 @@ const translations: TranslationDeepObject<typeof en> = {
pendingMatchSubmitTitle: 'Wyślij raport',
pendingMatchSubmitDescription: 'Niektóre wydatki oczekują na dopasowanie z transakcją kartą kredytową. Czy chcesz oznaczyć je jako gotówkę?',
routePending: 'Trasa w toku…',
- automaticallyEnterExpenseDetails: 'Concierge automatycznie wprowadzi szczegóły wydatku za Ciebie lub możesz dodać je ręcznie.',
+ automaticallyEnterExpenseDetails: 'Concierge uzupełni szczegóły za ciebie.',
receiptScanning: () => ({
one: 'Skanowanie paragonu...',
other: 'Skanowanie paragonów...',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index d513966555f..c4650375f64 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -1255,7 +1255,7 @@ const translations: TranslationDeepObject<typeof en> = {
pendingMatchSubmitTitle: 'Enviar relatório',
pendingMatchSubmitDescription: 'Algumas despesas estão pendentes de correspondência com uma transação de cartão de crédito. Deseja marcá-las como dinheiro?',
routePending: 'Rota pendente...',
- automaticallyEnterExpenseDetails: 'O Concierge inserirá automaticamente os detalhes da despesa para você, ou você pode adicioná-los manualmente.',
+ automaticallyEnterExpenseDetails: 'O Concierge vai preencher os detalhes para você.',
receiptScanning: () => ({
one: 'Digitalizando recibo...',
other: 'Escaneando recibos...',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 882adf31011..aee71a949ce 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -1217,7 +1217,7 @@ const translations: TranslationDeepObject<typeof en> = {
pendingMatchSubmitTitle: '提交报告',
pendingMatchSubmitDescription: '部分费用正在等待与信用卡交易匹配。您要将它们标记为现金吗？',
routePending: '路由处理中…',
- automaticallyEnterExpenseDetails: 'Concierge 将自动为您输入费用详情，或者您可以手动添加。',
+ automaticallyEnterExpenseDetails: 'Concierge 会帮你填写详细信息。',
receiptScanning: () => ({
one: '正在扫描收据…',
other: '正在扫描收据…',
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
Contributor
|
|
Contributor
Author
|
@MelvinBot apply the Polyglot Parrot translations |
Contributor
|
Please add |
melvin-bot
Bot
requested review from
flaviadefaria and
inimaga
and removed request for
a team
Contributor
Author
|
@inimaga hey! I think MelvinBot is being weird about applying translations. Check this comment out. Any ideas? |
jamesdeanexpensify
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari