Skip to content

InteractionManager migration - ContactMethodDetailsPage #92050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
GCyganek wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −9
Draft

InteractionManager migration - ContactMethodDetailsPage #92050

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2526313
InteractionManager migration - ContactMethodDetailsPage
GCyganek May 29, 2026
0dfb42c
Fix ESlint
GCyganek May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion config/eslint/eslint.seatbelt.tsv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,7 +533,6 @@
"../../src/pages/media/AttachmentModalScreen/routes/hooks/useReportAttachmentModalType.ts" "react-hooks/set-state-in-effect" 1
"../../src/pages/settings/AboutPage/AboutPage.tsx" "react-hooks/refs" 1
"../../src/pages/settings/PaymentCard/ChangeCurrency/index.tsx" "no-restricted-syntax" 1
"../../src/pages/settings/Profile/Contacts/ContactMethodDetailsPage.tsx" "@typescript-eslint/no-deprecated/InteractionManager.runAfterInteractions" 2
"../../src/pages/settings/Profile/Contacts/ContactMethodDetailsPage.tsx" "react-hooks/refs" 3
"../../src/pages/settings/Profile/Contacts/ContactMethodDetailsPage.tsx" "react-hooks/set-state-in-effect" 3
"../../src/pages/settings/Profile/CustomStatus/StatusClearAfterPage.tsx" "react-hooks/set-state-in-effect" 1
Expand Down
10 changes: 2 additions & 8 deletions src/pages/settings/Profile/Contacts/ContactMethodDetailsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
import {useIsFocused} from '@react-navigation/native';
import {Str} from 'expensify-common';
import React, {useCallback, useEffect, useMemo, useRef, useState} from 'react';
// eslint-disable-next-line no-restricted-imports
import {InteractionManager} from 'react-native';
import FullPageNotFoundView from '@components/BlockingViews/FullPageNotFoundView';
import {useDelegateNoAccessActions, useDelegateNoAccessState} from '@components/DelegateNoAccessModalProvider';
import ErrorMessageRow from '@components/ErrorMessageRow';
Expand Down Expand Up @@ -198,9 +196,7 @@ function ContactMethodDetailsPage({route}: ContactMethodDetailsPageProps) {
const turnOnDeleteModal = useCallback(() => {
const openDeleteModal = async () => {
const result = await showRemoveContactMethodModal();
InteractionManager.runAfterInteractions(() => {
validateCodeFormRef.current?.focusLastSelected?.();
});
validateCodeFormRef.current?.focusLastSelected?.();
if (result.action !== ModalActions.CONFIRM) {
return;
}
Expand Down Expand Up @@ -315,9 +311,7 @@ function ContactMethodDetailsPage({route}: ContactMethodDetailsPageProps) {
<ScreenWrapper
shouldEnableMaxHeight
onEntryTransitionEnd={() => {
InteractionManager.runAfterInteractions(() => {
validateCodeFormRef.current?.focus?.();
});
validateCodeFormRef.current?.focus?.();
}}
testID="ContactMethodDetailsPage"
focusTrapSettings={{
Expand Down
Loading