Skip to content

perf: limit updated reports on transaction update in LHN #92072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TMisiukiewicz wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −9
Open

perf: limit updated reports on transaction update in LHN #92072

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions src/hooks/useSidebarOrderedReports.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
import React, {createContext, useCallback, useContext, useEffect, useMemo, useRef, useState} from 'react';
import type {OnyxEntry} from 'react-native-onyx';
import Log from '@libs/Log';
import {getTransactionThreadReportID} from '@libs/MergeTransactionUtils';
import {isOneTransactionReport} from '@libs/ReportUtils';
import SidebarUtils from '@libs/SidebarUtils';
import type {BrickRoad} from '@libs/WorkspacesSettingsUtils';
import {getChatTabBrickRoad} from '@libs/WorkspacesSettingsUtils';
Expand Down Expand Up @@ -125,13 +123,7 @@ function SidebarOrderedReportsContextProvider({
}
}
if (transactionsUpdates) {
// We need to select the report linked to a transaction, to properly recalculate getReceiptUploadErrorReason, which is the expense report if it is isOneTransactionReport
// or the transaction thread report if it is otherwise.
for (const key of Object.values(transactionsUpdates ?? {}).map((transaction) =>
transaction?.reportID && isOneTransactionReport(chatReports?.[`${ONYXKEYS.COLLECTION.REPORT}${transaction.reportID}`])
? `${ONYXKEYS.COLLECTION.REPORT}${transaction?.reportID}`
: `${ONYXKEYS.COLLECTION.REPORT}${getTransactionThreadReportID(transaction)}`,
)) {
for (const key of Object.values(transactionsUpdates ?? {}).map((transaction) => `${ONYXKEYS.COLLECTION.REPORT}${transaction?.reportID}`)) {
reportsToUpdate.add(key);
}
}
Expand Down
Loading