[No QA] Clarify that "Manually" submission frequency still auto-adds expenses to a report#92121
[No QA] Clarify that "Manually" submission frequency still auto-adds expenses to a report#92121MelvinBot wants to merge 4 commits into
Conversation
…o a report Co-authored-by: Stephanie Elliott <stephanieelliott@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
Per feedback on the linked issue, document that toggling Submissions off (not the Manually frequency) is what prevents expenses from being auto-added to a report. Also fix the contradictory "off = submitted instantly" line in Workspace-Workflows so it matches the FAQ behavior. Co-authored-by: Stephanie Elliott <stephanieelliott@users.noreply.github.com>
|
Added the Submissions toggle OFF → Unreported clarification. Two changes pushed in
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
A preview of your ExpensifyHelp changes have been deployed to https://dfd26c3e.helpdot.pages.dev ⚡️ Updated articles: |
HelpDot Documentation ReviewOverall AssessmentThis PR clarifies the behavior of the Manually submission frequency across two help articles, making it explicit that expenses are still auto-added to reports even when Manually is selected. The changes are well-motivated (correcting an LLM misinterpretation) and improve precision. A few issues in the new text need attention before merge. Scores Summary
Key Findings
Recommendations
Files Reviewed
Review based on governance rules defined in docs/HELP_AUTHORING_GUIDELINES.md, docs/HELPSITE_NAMING_CONVENTIONS.md, and docs/TEMPLATE.md. Only proposed changes (diff) were evaluated. |
| - If turned **off**, all reimbursable and non-reimbursable expenses are submitted instantly. | ||
| - Manually – Expenses are still **auto-added to a report** as they're created, but employees must submit the report manually. This frequency only controls **when** reports are submitted, not whether expenses are placed on a report. | ||
|
|
||
| **Note:** If Submissions is turned disabled, expenses stay in the **Unreported** state until a member adds them to a report, and reports must be submitted manually. This is the only configuration that prevents expenses from being auto-added to a report. |
There was a problem hiding this comment.
Grammatical error: "turned disabled" is not valid phrasing. Use either "turned off" or "disabled" — not both together.
| **Note:** If Submissions is turned disabled, expenses stay in the **Unreported** state until a member adds them to a report, and reports must be submitted manually. This is the only configuration that prevents expenses from being auto-added to a report. | |
| **Note:** If Submissions is disabled, expenses stay in the **Unreported** state until a member adds them to a report, and reports must be submitted manually. This is the only configuration that prevents expenses from being auto-added to a report. |
| - By trip – A report is submitted when no new expenses are added for two full days. A new trip report starts after that. | ||
| - Manually – Expenses are auto-added to a report, but employees must submit them manually. | ||
| - If turned **off**, all reimbursable and non-reimbursable expenses are submitted instantly. | ||
| - Manually – Expenses are still **auto-added to a report** as they're created, but employees must submit the report manually. This frequency only controls **when** reports are submitted, not whether expenses are placed on a report. |
There was a problem hiding this comment.
Terminology consistency: This article uses "employees" while the dedicated Submissions article (How-to-Set-Up-Automatic-Report-Submissions.md) uses "members" for the same concept. Per naming conventions, UI-exact terminology should be consistent across articles. Consider using "members" here to match.
| - Manually – Expenses are still **auto-added to a report** as they're created, but employees must submit the report manually. This frequency only controls **when** reports are submitted, not whether expenses are placed on a report. | |
| - Manually – Expenses are still **auto-added to a report** as they're created, but members must submit the report manually. This frequency only controls **when** reports are submitted, not whether expenses are placed on a report. |
| - **Twice a month** — Reports are submitted on the 15th and last day of the month | ||
| - **By trip** — A report is submitted after two full days without new expenses | ||
| - **Manually** — Expenses are auto-added to reports, but members must submit manually | ||
| - **Manually** — Expenses are still **auto-added to a report** as they're created, but members must submit the report manually. |
There was a problem hiding this comment.
Formatting: Trailing whitespace after the period at the end of this line. Remove the extra space.
| - **Manually** — Expenses are still **auto-added to a report** as they're created, but members must submit the report manually. | |
| - **Manually** — Expenses are still **auto-added to a report** as they're created, but members must submit the report manually. |
|
|
||
| {:width="100%"} | ||
|
|
||
| **To stop expenses from being auto-added to a report entirely**, toggle the **Submissions** setting **off**. With Submissions off, new expenses stay in the **Unreported** state until a member adds them to a report, and reports must be submitted manually. The **Manually** frequency above does not have this effect — it only delays submission, expenses are still auto-added to a report. |
There was a problem hiding this comment.
Readability / structure: This paragraph sits as a standalone block between the image and the --- divider, without its own heading. Per the authoring guidelines, content sections should be organized under task-based ## headings. Consider placing this under a heading like ## How to stop expenses from being auto-added to a report so it is scannable and AI-retrievable as its own section.
Explanation of Change
Clarifies the Manually option of the workspace Submissions frequency in two help articles so it is clear that expenses are still auto‑added to a report — the "Manually" frequency only controls when reports are submitted, not whether expenses are placed on a report.
This was prompted by AgentZero recommending that an admin switch from the Weekly auto‑submission cadence to the Manually option so "expenses stay Unreported." Per the existing docs, the Manually option still auto‑adds expenses to reports, so the recommendation did not match the user's intent. AgentZero's logged reasoning shows it conflated the Workspace Workflows FAQ phrase "if no submission frequency is chosen, expenses remain Unreported" with the Manually option in How‑to‑Set‑Up‑Automatic‑Report‑Submissions. Making the Manually bullet more explicit in both articles should reduce that misinterpretation for both customers and the LLM.
Files updated:
docs/articles/new-expensify/reports-and-expenses/How-to-Set-Up-Automatic-Report-Submissions.mddocs/articles/new-expensify/workspaces/Workspace-Workflows.mdFixed Issues
$ https://github.com/Expensify/Expensify/issues/635321
PROPOSAL: https://github.com/Expensify/Expensify/issues/635321#issuecomment-4580434464
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
N/A — documentation-only change.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
N/A — help-site markdown content change.