[No QA] Docs updates for E/A#91201 document Search select all menu options#92194
Draft
MelvinBot wants to merge 1 commit into
Draft
[No QA] Docs updates for E/A#91201 document Search select all menu options#92194MelvinBot wants to merge 1 commit into
MelvinBot wants to merge 1 commit into
Conversation
Update export articles to reflect the new select-all dropdown that offers "Select all on this page" and "Select all" when a search has more results than fit on one page (E/A#91201). Co-authored-by: Emkhalid <emkhalid@users.noreply.github.com>
52 tasks
Contributor
|
A preview of your ExpensifyHelp changes have been deployed to https://70df950f.helpdot.pages.dev ⚡️ Updated articles: |
Contributor
|
@MelvinBot I reviewed the HelpDot changes and they correctly reflect the current behavior from #91201. Please mark this PR ready for review. |
Contributor
|
I think the MelvinBot mentioned me wrongly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Expensify/App#91201 changed the Search list header "select all" checkbox into a dropdown. When a search has more results than fit on one page, clicking the top checkbox now opens a menu with two options:
The existing help articles only said to "use the top checkbox to select all," which no longer reflects this behavior. This PR adds a short note to each affected export article so users know how to select all matching results across pages before exporting.
Files updated:
docs/articles/new-expensify/reports-and-expenses/How-to-Export-Expenses.mddocs/articles/new-expensify/reports-and-expenses/How-to-Export-Reports.mddocs/articles/new-expensify/reports-and-expenses/Search-and-Download-Expenses.mdUI labels were verified against
src/languages/en.tsand the merged source in PR #91201 (SearchSelectAllMenu.tsx).Fixed Issues
$ #88013
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
QA
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
@emkhalid, please review the files changed and confirm they reflect the current behavior. Then mark this PR
Ready for review.