fix: remove per diem expense from self DM after submission to workspace chat#92274
Draft
nabi-ebrahimi wants to merge 3 commits into
Draft
fix: remove per diem expense from self DM after submission to workspace chat#92274nabi-ebrahimi wants to merge 3 commits into
nabi-ebrahimi wants to merge 3 commits into
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
This change fixes an issue where submitting a per diem that started as a tracked expense left the original self-DM tracked expense unresolved. The expense was successfully submitted to the workspace, but the Concierge whisper and action buttons stayed behind because the final per diem submit step was losing the tracking metadata needed to clean up the original item.
The update carries that tracking metadata through the per diem submission flow and reuses the same cleanup behavior already used by normal tracked-expense submissions. It also sends the relevant action IDs with the per diem API request so the cleanup persists after refresh or across clients. This keeps the per diem flow on the existing per diem creation API while making its tracked-expense behavior consistent with other submit flows.
Fixed Issues
$ #87666
PROPOSAL: #87666 (comment)
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-06-01.at.11.49.53.PM.mov