Skip to content

[No QA] Docs updates for E/A#91255 document MCP OAuth connections in Device management#92458

Open
MelvinBot wants to merge 1 commit into
mainfrom
melvin-docs-mcp-oauth-devices
Open

[No QA] Docs updates for E/A#91255 document MCP OAuth connections in Device management#92458
MelvinBot wants to merge 1 commit into
mainfrom
melvin-docs-mcp-oauth-devices

Conversation

@MelvinBot
Copy link
Copy Markdown
Contributor

Explanation of Change

This is a help-site (HelpDot) docs update for the changes shipped in #91255.

That PR made the Device management page (Account > Security > Device management) display MCP OAuth sessions with a friendly label like OAuth - MCP (Claude) instead of blank or garbled text, and started showing OAuth (partnerID 86) sessions in the list at all.

The existing article Manage-Logged-in-Devices.md only described phone/tablet/browser device entries. This update documents the new entry type so members understand what these connections are and that they can revoke them:

  • Added a ## What OAuth and MCP connections appear in Device management section explaining that authorized apps (AI assistants connected via the Model Context Protocol — Claude, Cursor, ChatGPT, etc.) appear with a label like OAuth - MCP (Claude), and that clicking Revoke disconnects them.
  • Updated the FAQ answer for what information appears per device.
  • Added an FAQ entry explaining what OAuth - MCP (Claude) means.
  • Added related keywords (OAuth connection, MCP connection, AI assistant access) for search.

All UI labels were verified against the source: the page title Device management and Revoke button come from src/languages/en.ts, and the OAuth - MCP (<platform>) label text comes verbatim from the merged getDeviceDisplayName() helper in src/libs/UserUtils.ts. The OAuth - MCP (Claude) label itself could not be visually verified in the live UI because that requires an active MCP OAuth session; it is taken directly from the merged code.

The change follows docs/HELPSITE_NAMING_CONVENTIONS.md, docs/HELP_AUTHORING_GUIDELINES.md, and docs/TEMPLATE.md (single # title plus # FAQ, task/question-based ## headings, exact UI labels).

Fixed Issues

$ #92034

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

QA

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.


@marcaaron, please review the files changed and confirm they reflect the current behavior. Then mark this PR Ready for review.

Reflects E/A#91255, which makes the Device management page display MCP
OAuth sessions with a friendly label (e.g. "OAuth - MCP (Claude)").

Co-authored-by: Marc Glasser <marcaaron@users.noreply.github.com>
@MelvinBot MelvinBot requested a review from a team June 3, 2026 00:23
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Jun 3, 2026
@github-actions github-actions Bot changed the title Docs updates for E/A#91255 document MCP OAuth connections in Device management [No QA] Docs updates for E/A#91255 document MCP OAuth connections in Device management Jun 3, 2026
@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Jun 3, 2026

A preview of your ExpensifyHelp changes have been deployed to https://c74c6930.helpdot.pages.dev ⚡️

Updated articles:

Copy link
Copy Markdown
Contributor

@marcaaron marcaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stephanieelliott stephanieelliott marked this pull request as ready for review June 5, 2026 02:50
@stephanieelliott stephanieelliott self-requested a review as a code owner June 5, 2026 02:50
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented Jun 5, 2026

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @greg-schroeder

@melvin-bot melvin-bot Bot requested review from greg-schroeder and truph01 June 5, 2026 02:50
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented Jun 5, 2026

@truph01 @greg-schroeder One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot removed the request for review from a team June 5, 2026 02:50
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 5, 2026

HelpDot Documentation Review

Overall Assessment

This PR adds documentation for MCP OAuth connections appearing in Device management. The change is well-scoped — it adds one explanatory section and two FAQ entries to an existing article, plus expanded keywords. The writing is clear, follows governance conventions closely, and uses verified UI labels.

Scores Summary

  • Readability: 9/10 - The new content is concise, scannable, and action-oriented. FAQ answers are direct and clear. The explanatory section flows logically from what the entries are, to how they appear, to how to disconnect them.
  • AI Readiness: 9/10 - All new headings are question-based and include the feature name ("Device management", "OAuth - MCP"). Keywords were meaningfully expanded with search-relevant terms (OAuth connection, MCP connection, AI assistant access). The existing YAML metadata and internalScope are intact.
  • Style Compliance: 9/10 - UI labels (Revoke, OAuth - MCP (Claude)) are bolded and match the product exactly as verified against source code. No prohibited language, no quotation marks around UI elements, no paraphrased labels. Sentence case is correctly applied throughout.

Key Findings

  • All new ## headings are question-word-based ("What OAuth and MCP connections appear in...", "What does 'OAuth - MCP (Claude)' mean..."), satisfying the task-based heading requirement.
  • UI labels were verified against source code (en.ts and UserUtils.ts), which is a strong practice.
  • The article remains single-workflow focused (managing logged-in devices), with the OAuth/MCP content as a natural extension rather than scope creep.
  • Minor pre-existing issue: The keywords array contains a period instead of a comma (revoke device access. log out remotely should be revoke device access, log out remotely). This existed before this PR but is worth noting since the keywords line was modified — it would be a low-effort fix.
  • The contraction "isn't" in the new section ("If the connected tool isn't recognized") is fine for conversational tone, though the rest of the article generally avoids contractions. Consistency is a minor consideration.

Recommendations

  1. Consider fixing the pre-existing period-instead-of-comma typo in the keywords array since that line was already touched in this PR.
  2. No blocking issues identified. The changes are well-aligned with governance standards.

Files Reviewed

  • docs/articles/new-expensify/settings/Manage-Logged-in-Devices.md — 16 additions, 2 deletions. New OAuth/MCP section, updated FAQ answer, new FAQ entry, expanded keywords. All changes comply with governance rules.

Review based on docs/HELPSITE_NAMING_CONVENTIONS.md, docs/HELP_AUTHORING_GUIDELINES.md, and docs/TEMPLATE.md.

title: Manage Logged-in Devices
description: View signed-in devices and revoke device access for your Expensify account.
keywords: [manage devices, revoke device access. log out remotely, revoke logged-in device, signed in devices, account security, New Expensify]
keywords: [manage devices, revoke device access. log out remotely, revoke logged-in device, signed in devices, account security, OAuth connection, MCP connection, AI assistant access, New Expensify]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metadata issue: There is a period instead of a comma in the keywords list — revoke device access. log out remotely should be revoke device access, log out remotely. Since this line was modified in this PR, it is a good opportunity to fix it.

Suggested change
keywords: [manage devices, revoke device access. log out remotely, revoke logged-in device, signed in devices, account security, OAuth connection, MCP connection, AI assistant access, New Expensify]
keywords: [manage devices, revoke device access, log out remotely, revoke logged-in device, signed in devices, account security, OAuth connection, MCP connection, AI assistant access, New Expensify]

The device list shows the device name, operating system or browser, and the last time the device accessed your account.
The device list shows the device name, operating system or browser, and the last time the device accessed your account. Authorized app connections appear with a label like **OAuth - MCP (Claude)** instead of a device name and operating system.

## What does "OAuth - MCP (Claude)" mean in my device list?
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming and style: Per HELPSITE_NAMING_CONVENTIONS.md, UI labels should not be wrapped in quotation marks — use bold formatting instead. Consider rephrasing this FAQ heading to avoid quoting the label, for example:

Suggested change
## What does "OAuth - MCP (Claude)" mean in my device list?
## What the OAuth - MCP (Claude) label means in your device list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants