Replace modal window.history guard with state.history sentinel (#90776)#92492
Draft
WojtekBoman wants to merge 1 commit into
Draft
Replace modal window.history guard with state.history sentinel (#90776)#92492WojtekBoman wants to merge 1 commit into
WojtekBoman wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Moves
shouldHandleNavigationBackmodals off the directwindow.history.pushStatehack onto a react-navigationstate.historysentinel (TOGGLE_MODAL_WITH_HISTORY), mirroring SidePanel. The router consumes the sentinel on forward navigation souseLinkingreplaces instead of stacking — removing the orphaned entry that caused the double-Back (#90776). AddsuseSyncModalWithHistory; deletes the legacy guards.Fixed Issues
$
PROPOSAL:
Tests
shouldHandleNavigationBackflow (e.g. a value/date picker or a ConfirmModal that routes onward), then a second modal on top of it, and press browser Back.Offline tests
N/A — these changes only affect navigation/browser-history state and do not involve API calls or Onyx data.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari