Fix fragment.text literal and close search RHP after deleting last message#92543
Open
WojtekBoman wants to merge 1 commit into
Open
Fix fragment.text literal and close search RHP after deleting last message#92543WojtekBoman wants to merge 1 commit into
WojtekBoman wants to merge 1 commit into
Conversation
|
@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixes the
"fragment.text"literal showing in chat after deleting a thread conversation: thedefaultcase inReportActionItemFragmentnow renders{fragment?.text ?? ''}instead of the literal string. Additionally, indeleteReportComment, when a report shown in the search RHP (/search/view/:reportID) has no visible actions left after deletion, we pop that RHP screen (keeping any wider RHP below open).Screen.Recording.2026-06-03.at.17.09.44.mov
Fixed Issues
$ #91603
PROPOSAL:
Tests
"fragment.text"does NOT appear anywhere after deleting the thread conversation./search/view/:reportIDis deleted, that RHP screen closes automatically (instead of showing an empty report).Offline tests
/search/view/:reportID) and delete its last visible message."fragment.text"never appears.QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari