Skip to content

Open Concierge RHP for all Track onboarding choices on web #92606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MelvinBot wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −4
Open

Open Concierge RHP for all Track onboarding choices on web #92606

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/hooks/useAutoCreateTrackWorkspace.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import type {OnyxCollection} from 'react-native-onyx';
import isSidePanelReportSupported from '@components/SidePanel/isSidePanelReportSupported';
import Log from '@libs/Log';
import {navigateAfterOnboardingWithMicrotaskQueue} from '@libs/navigateAfterOnboarding';
import isTrackOnboardingChoice from '@libs/OnboardingUtils';
import {createDisplayName} from '@libs/PersonalDetailsUtils';
import {isPaidGroupPolicy, isPolicyAdmin} from '@libs/PolicyUtils';
import {createWorkspace, generateDefaultWorkspaceName, generatePolicyID} from '@userActions/Policy/Policy';
Expand Down Expand Up @@ -103,10 +104,10 @@ function useAutoCreateTrackWorkspace() {

if (isSidePanelReportSupported) {
rhpVariant = extractRHPVariantFromResponse(response);
// TRACK_PERSONAL should also navigate to concierge in RHP, same as TRACK_BUSINESS.
// The backend only returns trackExpensesWithConcierge for TRACK_WORKSPACE (TRACK_BUSINESS),
// so we fall back to it for TRACK_PERSONAL when the backend doesn't set it.
if (!rhpVariant && onboardingPurposeSelected === CONST.ONBOARDING_CHOICES.TRACK_PERSONAL) {
// Every Track onboarding choice should land in the Concierge RHP, but the backend
// doesn't reliably return trackExpensesWithConcierge for all of them, so fall back to it
// whenever the response omits a variant.
if (!rhpVariant && isTrackOnboardingChoice(onboardingPurposeSelected)) {
rhpVariant = CONST.ONBOARDING_RHP_VARIANT.TRACK_EXPENSES_WITH_CONCIERGE;
}
}
Expand Down
Loading